Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
e5c0606c
Commit
e5c0606c
authored
Dec 02, 2021
by
Robert Knight
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add a comment about the reason for the non-robust delivery mechanism
parent
739f4af7
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
0 deletions
+5
-0
frame-error-capture.js
src/shared/frame-error-capture.js
+5
-0
No files found.
src/shared/frame-error-capture.js
View file @
e5c0606c
...
...
@@ -28,6 +28,11 @@ export function captureErrors(callback, context) {
* Errors are delivered on a best-effort basis. If no error handling frame has
* been registered or the frame is still loading, the error will not be received.
*
* Ideally we would use a more robust delivery system which can queue messages
* until they can be processed (eg. using MessagePort). We use `window.postMessage`
* for the moment because we are trying to rule out problems with
* MessageChannel/MessagePort when setting up sidebar <-> host communication.
*
* @param {unknown} error
* @param {string} context - A short message indicating where the error happened.
*/
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment