Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
e8e99cdf
Commit
e8e99cdf
authored
Sep 06, 2022
by
Robert Knight
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add some additional comments to "showAnnotations" handler
parent
ef7a99e1
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
9 additions
and
2 deletions
+9
-2
frame-sync.js
src/sidebar/services/frame-sync.js
+9
-2
No files found.
src/sidebar/services/frame-sync.js
View file @
e8e99cdf
...
...
@@ -372,15 +372,22 @@ export class FrameSyncService {
* to the first annotation in the selection.
*/
(
tags
,
focusFirstInSelection
=
false
)
=>
{
// Since annotations are selected by ID rather than tag, this logic
// currently only supports saved annotations.
const
ids
=
this
.
_store
.
findIDsForTags
(
tags
);
this
.
_store
.
selectAnnotations
(
ids
);
this
.
_store
.
selectTab
(
'annotation'
);
// Attempt to transfer keyboard focus to the first selected annotation.
// This may be blocked in WebKit-based browsers if the user has not
// previously interacted with the frame.
//
// To do this we need to focus both the annotation card and the frame
// itself. It doesn't matter in which order.
if
(
ids
.
length
>
0
&&
focusFirstInSelection
)
{
// Request the annotation card to be focused. This is handled asynchronously.
this
.
_store
.
setAnnotationFocusRequest
(
ids
[
0
]);
// Focus the sidebar frame. This may fail in WebKit-based browsers
// if the user has no interacted with the frame since it loaded.
window
.
focus
();
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment