Remove unused/old `sort-dropdown` component

src/sidebar/components/hypothesis-app.js

@@ -73,16 +73,6 @@ function HypothesisAppController(
     frameSync.connect();
   }
 
-  this.sortKey = function() {
-    return store.getState().sortKey;
-  };
-
-  this.sortKeysAvailable = function() {
-    return store.getState().sortKeysAvailable;
-  };
-
-  this.setSortKey = store.setSortKey;
-
   // Reload the view when the user switches accounts
   $scope.$on(events.USER_CHANGED, function(event, data) {
     self.auth = authStateFromProfile(data.profile);

src/sidebar/components/sort-dropdown.js

-'use strict';
-
-module.exports = {
-  controllerAs: 'vm',
-  controller: function() {},
-  bindings: {
-    /** The name of the currently selected sort key. */
-    sortKey: '<',
-    /** A list of possible keys that the user can opt to sort by. */
-    sortKeysAvailable: '<',
-    /** Called when the user changes the sort key. */
-    onChangeSortKey: '&',
-  },
-  template: require('../templates/sort-dropdown.html'),
-};

src/sidebar/components/test/sort-dropdown-test.js

-'use strict';
-
-const angular = require('angular');
-
-const util = require('../../directive/test/util');
-
-describe('sortDropdown', function() {
-  before(function() {
-    angular
-      .module('app', [])
-      .component('sortDropdown', require('../sort-dropdown'));
-  });
-
-  beforeEach(function() {
-    angular.mock.module('app');
-  });
-
-  it('should update the sort key on click', function() {
-    const changeSpy = sinon.spy();
-    const elem = util.createDirective(document, 'sortDropdown', {
-      sortKeysAvailable: ['Newest', 'Oldest'],
-      sortKey: 'Newest',
-      onChangeSortKey: {
-        args: ['sortKey'],
-        callback: changeSpy,
-      },
-    });
-    const links = elem.find('li');
-    angular.element(links[0]).click();
-    assert.calledWith(changeSpy, 'Newest');
-  });
-});

src/sidebar/index.js

@@ -184,7 +184,6 @@ function startAngularApp(config) {
     )
     .component('sidebarTutorial', require('./components/sidebar-tutorial'))
     .component('shareDialog', require('./components/share-dialog'))
-    .component('sortDropdown', require('./components/sort-dropdown'))
     .component(
       'sortMenu',
       wrapReactComponent(require('./components/sort-menu'))

src/sidebar/templates/hypothesis-app.html

@@ -9,10 +9,7 @@
     is-sidebar="::vm.isSidebar"
     pending-update-count="vm.countPendingUpdates()"
     on-apply-pending-updates="vm.applyPendingUpdates()"
-    search-controller="vm.search"
-    sort-key="vm.sortKey()"
-    sort-keys-available="vm.sortKeysAvailable()"
-    on-change-sort-key="vm.setSortKey(sortKey)">
+    search-controller="vm.search">
   </top-bar>
 
   <div class="content">