Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
C
coopwire-hypothesis
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
孙灵跃 Leon Sun
coopwire-hypothesis
Commits
ee70806a
Commit
ee70806a
authored
Feb 28, 2023
by
Alejandro Celaya
Committed by
Alejandro Celaya
Feb 28, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use boolean values for aria-expanded in JSX
parent
53a1c634
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
9 deletions
+3
-9
TagEditor.tsx
src/sidebar/components/TagEditor.tsx
+1
-1
TagEditor-test.js
src/sidebar/components/test/TagEditor-test.js
+2
-8
No files found.
src/sidebar/components/TagEditor.tsx
View file @
ee70806a
...
...
@@ -273,7 +273,7 @@ function TagEditor({
aria
-
autocomplete=
"list"
aria
-
activedescendant=
{
activeDescendant
}
aria
-
controls=
{
`${tagEditorId}-AutocompleteList`
}
aria
-
expanded=
{
suggestionsListOpen
.
toString
()
}
aria
-
expanded=
{
suggestionsListOpen
}
aria
-
label=
"Add tags"
dir=
"auto"
role=
"combobox"
...
...
src/sidebar/components/test/TagEditor-test.js
View file @
ee70806a
...
...
@@ -466,16 +466,10 @@ describe('TagEditor', () => {
const
wrapper
=
createComponent
();
wrapper
.
find
(
'input'
).
instance
().
value
=
'non-empty'
;
// to open list
typeInput
(
wrapper
);
assert
.
equal
(
wrapper
.
find
(
comboboxSelector
).
prop
(
'aria-expanded'
),
'true'
);
assert
.
equal
(
wrapper
.
find
(
comboboxSelector
).
prop
(
'aria-expanded'
),
true
);
selectOption
(
wrapper
,
'tag4'
);
wrapper
.
update
();
assert
.
equal
(
wrapper
.
find
(
comboboxSelector
).
prop
(
'aria-expanded'
),
'false'
);
assert
.
equal
(
wrapper
.
find
(
comboboxSelector
).
prop
(
'aria-expanded'
),
false
);
});
it
(
'sets the <AutocompleteList> `activeItem` prop to match the selected item index'
,
()
=>
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment