Merge pull request #3441 from hypothesis/sheetaluk/pdf-metadata

Remove path for local pdf files.

h/static/scripts/annotator/plugin/pdf-metadata.js

@@ -49,10 +49,16 @@ PDFMetadata.prototype.getMetadata = function () {
     }
 
     var link = [
-      {href: fingerprintToURN(app.documentFingerprint)},
-      {href: app.url}
+      {href: fingerprintToURN(app.documentFingerprint)}
     ];
 
+    // Local file:// URLs should not be saved in document metadata.
+    // Entries in document.link should be URIs. In the case of
+    // local files, omit the URL.
+    if (app.url.indexOf('file://') !== 0) {
+      link.push({href: app.url});
+    }
+
     return {
       title: title,
       link: link,

h/static/scripts/annotator/plugin/test/pdf-metadata-test.js

@@ -83,6 +83,24 @@ describe('pdf-metadata', function () {
           assert.deepEqual(actualMetadata, expectedMetadata);
         });
       });
+
+      it('does not save file:// URLs in document metadata', function () {
+        var pdfMetadata;
+        var fakePDFViewerApplication = {
+          documentFingerprint: 'fakeFingerprint',
+          url: 'file://fakeUrl',
+        };
+        var expectedMetadata = {
+          link: [{href: 'urn:x-pdf:' + fakePDFViewerApplication.documentFingerprint}],
+        };
+
+        pdfMetadata = new PDFMetadata(fakePDFViewerApplication);
+
+        return pdfMetadata.getMetadata().then(function (actualMetadata) {
+          assert.equal(actualMetadata.link.length, 1);
+          assert.equal(actualMetadata.link[0].href, expectedMetadata.link[0].href);
+        });
+      });
     });
   });
 });