- 30 Jun, 2020 1 commit
-
-
Robert Knight authored
As suggested in PR feedback, this can help readability. We should do the same in parameter lists as well.
-
- 26 Jun, 2020 5 commits
-
-
Robert Knight authored
Enable minimal typechecking for src/sidebar/services. Note that most service factories are missing parameter documentation, so their usage is not checked. - Fix up JSDoc errors and omissions in `src/sidebar/services` - Add types for the `tiny-emitter` npm module. The module does ship with its own types, but doesn't specify the types for the default export - Add additional properties to `Annotation`, `Group` and `Profile` API objects
-
Robert Knight authored
Typecheck `src/annotator/{config, util}` and `src/sidebar/*.js`
-
Robert Knight authored
Simplify `since:<time>` filter query parsing and remove `result:<term>` parsing
-
Robert Knight authored
Enable typechecking for the following directories: - src/annotator/config - src/annotator/util - src/sidebar (excluding `ga.js`, `icons.js` and `index.js`) Many functions in these directories are still not annotated, but this will be added over time. `ga.js` was excluded because it deals with globals added by Google Analytics. `icons.js` was excluded because TS doesn't know how to handle `require('.../some-icon.svg')`. `index.js` was excluded because that imports (and thus triggers checking for) every other file in the sidebar app. It will need to be enabled last.
-
Robert Knight authored
There were no tests for this and this field is not used in the code that consumes the output of filter query parsing (`view-filter.js` and `stream-filter.js`).
-
- 25 Jun, 2020 23 commits
-
-
Kyle Keating authored
Don’t hide the component when `store.isLoading()` is true. This only causes a re-render of that component and momentarily removes it from the DOM. Its not actually invalid to show the filter buttons while loading because the filter is still being applied.
-
Lyza Gardner authored
Extract styles from Annotation Body, License and Quote
-
Lyza Gardner authored
Add utility classes for one-liners
-
Robert Knight authored
Upgrade to ESLint v7.x
-
Robert Knight authored
Update eslint-config-hypothesis which was in turn holding back various other ESLint packages. The newest update to eslint-plugin-react-hooks found an incorrect usage of `useCallback` in `ThreadCard` where `debounce` was being called on ever render instead of only when certain dependencies changed.
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Robert Knight authored
Simplify code in `search-filter.js` in preparation for enabling typechecking of `src/sidebar/services`. - Use a single regex to parse the `<time><unit>` expression rather than two expressions per time unit. - Replace the user of manual offsets to get the field value which is error prone. - Update JSDoc of various functions - Provide a fallback in case a tokenizing regex fails to match. I haven't verified that this fallback ever gets used, but it keeps both TS and the human reader happier
-
Lyza Gardner authored
Add additional atomic mixins, variables
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Robert Knight authored
Enable typechecking for src/boot
-
Lyza Gardner authored
Do additional consolidation with mixins and remove unused CSS
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Gardner authored
Adjust highlight icon styling for better visibility
-
Robert Knight authored
Enable typechecking for `src/shared/*.js`
-
- 24 Jun, 2020 8 commits
-
-
Robert Knight authored
This mainly involved documenting the `config` option that is passed around various functions in `src/boot/boot.js`.
-
Robert Knight authored
Begin to add JSDoc types for client configuration objects
-
Robert Knight authored
Enable typechecking of annotated functions in src/shared/, excluding subdirectories for the moment. This found a few minor mistakes with existing JSDoc usage.
-
Robert Knight authored
The client's "sidebar" and "annotator" applications query configuration from various sources (the host page, the H backend / browser extension build, added dynamically by the app). This commit begins the process of adding a centralized place to document the types of these configuration objects and making typechecked modules in `src/sidebar/util` use them.
-
Lyza Danger Gardner authored
- Make it a bit bigger so you can tell what it is - Adjust baseline via margin to align it better with other row items
-
Robert Knight authored
Add command to typecheck code and enable it for src/sidebar/util/
-
Robert Knight authored
- Ignore an unused function - Use a more modern idiom for setting the default value for a test seam
-
Robert Knight authored
Reading the code it appeared that `getBreakpoint` could return `null`, but this was not actually the case because the last item in `BREAKPOINTS` always matches. Revise the way `getBreakpoint` works to make it more obvious that it will always return a breakpoint.
-
- 23 Jun, 2020 3 commits
-
-
dependabot-preview[bot] authored
Bumps [eslint-plugin-jsx-a11y](https://github.com/evcohen/eslint-plugin-jsx-a11y) from 6.2.3 to 6.3.1. - [Release notes](https://github.com/evcohen/eslint-plugin-jsx-a11y/releases) - [Changelog](https://github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/master/CHANGELOG.md) - [Commits](https://github.com/evcohen/eslint-plugin-jsx-a11y/compare/v6.2.3...v6.3.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
-
dependabot-preview[bot] authored
Bumps [fetch-mock](https://github.com/wheresrhys/fetch-mock) from 9.10.1 to 9.10.2. - [Release notes](https://github.com/wheresrhys/fetch-mock/releases) - [Commits](https://github.com/wheresrhys/fetch-mock/compare/v9.10.1...v9.10.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
-
dependabot-preview[bot] authored
Bumps [terser](https://github.com/terser/terser) from 4.7.0 to 4.8.0. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/compare/v4.7.0...v4.8.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
-