- 13 Apr, 2022 3 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
- 12 Apr, 2022 12 commits
-
-
Robert Knight authored
-
Lyza Danger Gardner authored
It turns out this performance trick is no longer strictly needed for the originally stated reason. The top bar remains cleanly fixed in position when scrolling the page. In Chrome the scrollable content area (the .js-thread-list-scroll-root element) is now in its own compositing layer anyway due to it having overflow: scroll set on it. This in turn appears to force the browser to put the TopBar in its own compositor layer in order to make it render above the scrollable area. When this performance trick was originally added the whole sidebar body scrolled.
-
Lyza Danger Gardner authored
Remove unused `TopBar` SASS module.
-
Lyza Danger Gardner authored
-
dependabot[bot] authored
Bumps [eslint](https://github.com/eslint/eslint) from 8.12.0 to 8.13.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.12.0...v8.13.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [preact](https://github.com/preactjs/preact) from 10.7.0 to 10.7.1. - [Release notes](https://github.com/preactjs/preact/releases) - [Commits](https://github.com/preactjs/preact/compare/10.7.0...10.7.1) --- updated-dependencies: - dependency-name: preact dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.17.8 to 7.17.9. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.17.9/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [npm-packlist](https://github.com/npm/npm-packlist) from 4.0.0 to 5.0.0. - [Release notes](https://github.com/npm/npm-packlist/releases) - [Changelog](https://github.com/npm/npm-packlist/blob/main/CHANGELOG.md) - [Commits](https://github.com/npm/npm-packlist/compare/v4.0.0...v5.0.0) --- updated-dependencies: - dependency-name: npm-packlist dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.19.3 to 6.19.6. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/6.19.3...6.19.6) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [sass](https://github.com/sass/dart-sass) from 1.49.11 to 1.50.0. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](https://github.com/sass/dart-sass/compare/1.49.11...1.50.0) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1106.0 to 2.1111.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.1106.0...v2.1111.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
Robert Knight authored
`replaceLinksWithEmbeds` attempts to compare the href and text of a link in a percent-encoding agnostic way. This can be done by either percent-decoding the href or percent-encoding the text. Both of these approaches can fail, but `encodeURI` has fewer failure modes than `decodeURI`. Switch to using `encodeURI` for this reason, handle failure, and add tests that would cover both implementation approaches. Fixes #4405
-
- 07 Apr, 2022 10 commits
-
-
Lyza Danger Gardner authored
`theme-clean:border` was not enough here to re-enable borders in the clean theme because they had been set to `border: none`, which not only turned off `border-width` but also reset color and style.
-
Robert Knight authored
Update PDF.js using ./scripts/update-pdfjs.
-
Robert Knight authored
Simplify update process slightly and standardize commit message by creating the commit as part of the update-pdfjs script.
-
Robert Knight authored
This required a small change in `FilterStatus` to enable TS to better understand the shape of `buttonProps` depending on which code branch is taken.
-
Robert Knight authored
In particular clarify that references to `annotation` refer to an object with only ID properties and not the whole annotation object.
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
This found apparent missing checks for a null `profile.userid` (ie. current user is logged out) in several places. These places should not be reachable when the user is logged out due to checks elsewhere, but add explicit checks for the user being logged in.
-
Robert Knight authored
Adapt to current naming conventions for identifiers.
-
Lyza Danger Gardner authored
-
- 06 Apr, 2022 15 commits
-
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
Use shared `TextInput` component for presentational consistency.
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
Adjust styling of buttons and link in markdown editor toolbar to better handle touch interfaces and focus rings. Also fix casing in `classnames` import.
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Robert Knight authored
-
Robert Knight authored
This warning is useful to detect situations where the page text and text layer differ beyond just whitespace differences, which will result in misalignment of highlights.
-
Robert Knight authored
Re-use this utility to translate offsets between the original page text and the whitespace-stripped version of the page text. This allows the `stripSpaces` helper to be simplified and avoids creating some offset arrays that are unused.
-
Robert Knight authored
These arose from resolving confusion during a verbal code review.
-
Robert Knight authored
Expand on the choice of "input" and "output" as names for the two string arguments. These could equally have been "source" and "destination" or "stringA" and "stringB".
-
Robert Knight authored
-
Robert Knight authored
When anchoring a quote in a PDF, the quote is first searched in text extracted using PDF.js's `PDFPage.getTextContent` API, and the resulting positions are used to create a range within the hidden text layer of a page. An issue we've seen several times when doing PDF.js upgrades is minor changes to which spaces are included in the text layer. In the past we've adapted our text extraction to match the text layer each time. This slows down the process of upgrading PDF.js and makes maintaining compatibility with a range of PDF.js releases more difficult. In the most recent update, an `includeMarkedContent` option was added to the `getTextContent` API, and the presence of that option could affect whether certain whitespaces are included in the output nor not [1]. Try to address this issue generally by mapping offsets from the page text into offsets in the text layer in a way that ignores whitespace differences. - Add `translateOffsets` utility, which maps a (start, end) pair of offsets in an input string into corresponding offsets in an output string, where the output is a version of the input that has been "corrupted" by the addition or removal of certain characters (eg. whitespace) - Use `translateOffsets` utility in PDF anchoring to map quote offsets in the page text returned by `PDFPage.getTextContent` into offsets in the `textContent` of the text layer element. [1] https://github.com/hypothesis/browser-extension/pull/799#issuecomment-1079864595
-
Robert Knight authored
-