- 21 Oct, 2015 16 commits
-
-
Robert Knight authored
Update to the latest version of the sort/filter toolbar icon from the Trello card. T-91
-
Robert Knight authored
Align the dropdown menu's top arrow with the bottom arrow of the menu. As the styling of the dropdown was adjusted for its new home in the top bar, it became wider and the previous alignment of the menu resulted in it disappearing off the left edge of the sidebar. T-91
-
Robert Knight authored
T-91
-
Robert Knight authored
Dropdown menus were using BEM element naming in some places and tag name selectors in others. This updates the styling to use BEM element naming consistently.
-
Robert Knight authored
Remove the padding from the links in the dropdown menus and apply it to the row itself instead. This makes it easier to keep consistent spacing with different menu item contents in the dropdowns.
-
Robert Knight authored
T-91
-
Robert Knight authored
T-91
-
Robert Knight authored
When the 'Groups' feature is enabled, move the sort menu into a dropdrown triggered via a button in the top bar. T-91
-
Nick Stenning authored
-
Robert Knight authored
Replace client-side profile form
-
Nick Stenning authored
Flash confirmation messages when profile forms are successfully submitted.
-
Nick Stenning authored
Remove the client-side profile forms which are now implemented on the server. This actually removes a couple of dependencies which we can also remove. In particular the "tabbable" directive from angular-bootstrap is no longer needed.
-
Nick Stenning authored
Add server-rendered profile update and notifications settings forms. Unlike the previous changes I've made to form-handling, these are not straightforward translations of the forms that existed in the sidebar, for a couple of different reasons: - The profile update form no longer has a delete account button. The delete account functionality doesn't really do anything: it sets a random password and logs the user out. We haven't removed any of their personally identifying information, and we can't even tell by looking at the database who has attempted to delete their account. We've agreed to remove this button until such time as we can implement the feature properly. In its place is a paragraph inviting users who wish to delete their accounts to email support. - The wording and layout of the notifications update form has been tweaked to read more clearly.
-
Nick Stenning authored
Remove get_by_userid()
-
Nick Stenning authored
Extension build type indicator
-
Sean Hammond authored
Iterate over a copy of the open websockets list
-
- 20 Oct, 2015 4 commits
-
-
Nick Stenning authored
Extract sort dropdown into own component
-
Nick Stenning authored
Extension badge refactor
-
Robert Knight authored
Extract the sort dropdown into a reusable component and add tests. T-91
-
Robert Knight authored
Make BrowserAction actually stateless - its responsibility is just to map the logical H state of a tab (active/inactive/errored, annotation count) to the badge state. * Convert the per-tab state stored in TabState from a string into an object so that we can store additional state, starting with the badge count. * Move the function for fetching the badge's annotation count and updating the H tab state into TabState. This decouples the presentation of the badge from the logic of making network requests and updating the model.
-
- 19 Oct, 2015 8 commits
-
-
Nick Stenning authored
Update npm / python modules before running tests
-
Nick Stenning authored
Fix an issue where clicking the search icon would submit the form
-
Robert Knight authored
Make settings loader CSP-compatible
-
Nick Stenning authored
I forgot about CSP! We disallow inline scripts in the Chrome extension, so 18c47ba broke the extension. This commit replaces an inline script with some JSON data, parsed by the settings factory.
-
Robert Knight authored
Clicking the search icon should only focus the search field, not submit the search. This addresses the issue mentioned at https://github.com/hypothesis/h/pull/2622#issuecomment-148808509
-
Nick Stenning authored
New design for top bar
-
Nick Stenning authored
Add userid_domain config setting
-
Nick Stenning authored
Fix group link not being focused in dropdown menu if group hash IDs started with a number
-
- 16 Oct, 2015 12 commits
-
-
Robert Knight authored
The hash ID was not quoted when constructing the selector used to find the group's link field in order to focus it, resulting in an error depending on the chars in the hash ID.
-
Sean Hammond authored
Revert "Use "should" instead of "must" for search queries"
-
Sean Hammond authored
Add authors to RSS feed
-
Sean Hammond authored
Simplify streamer
-
Robert Knight authored
Override the browser default styling on the search input's width property so that its maximum width will be limited by the available space in the top bar when expanded. Previously it was inflexible due to the browser default styling with the group name being pushed off the left side of the top bar as a result. There is still an issue at the moment in Firefox where the share icon gets covered by the search bar when expanded. T-90
-
Robert Knight authored
When the top-bar is used in the stream, the content needs to be centered above the stream's contents. T-90
-
Robert Knight authored
* Add a couple of missing titles * Fix hover state for share icon when groups is disabled T-90
-
Robert Knight authored
The input field has no padding by default so that it does not take up space when collapsed. When expanded we need some padding between the icon and the input.
-
Robert Knight authored
53bd01169cd8eb00748f953a6b2488f09637b32c incorrectly changed the '.annotator-no-transition' selector which disables the animated width transitions on the sidebar during manual resizes to '.annotator-frame .annotator-no-transition' which meant that it did not take effect. T-90
-
Robert Knight authored
T-90
-
Robert Knight authored
* Make the spacing between the top bar icons consistent * Remove redundant CSS from top-bar.scss The CSS usage here is a little ugly because .top-bar__btn is used inside the <simple-search> directive but at least it is clear where the style comes from.
-
Robert Knight authored
This adds updated icons which were designed together and line up correctly.
-