- 14 Dec, 2023 1 commit
-
-
Robert Knight authored
Refactor query parsing functions in preparation for adding new focus modes: - Use different sets of field names when parsing queries for the sidebar's filter bar and backend search. The supported filters are different. - Make the `focusFilters` argument to `parseFilterQuery` more general so we can support adding in additional filters. The immediate use case is adding in `cfi` and `page` filters to support new focus modes.
-
- 12 Dec, 2023 8 commits
-
-
Robert Knight authored
This matches how page numbers are more typically written in e.g. citations.
-
Robert Knight authored
The warning is correct that this is not really how Reselect is supposed to be used, but it is intentional. Add a suppression with a comment explaining the intent in case we find a nicer approach in future that better aligns with how Reselect is supposed to be used.
-
Robert Knight authored
Fix an issue where the selector would return a new array on each call, even if called with the same arguments. Instead the correct way to capture multiple values from the state is to pass multiple arguments to `createSelector`.
-
Alejandro Celaya authored
-
dependabot[bot] authored
Bumps the redux group with 3 updates: [redux](https://github.com/reduxjs/redux), [redux-thunk](https://github.com/reduxjs/redux-thunk) and [reselect](https://github.com/reduxjs/reselect). Updates `redux` from 4.2.1 to 5.0.0 - [Release notes](https://github.com/reduxjs/redux/releases) - [Changelog](https://github.com/reduxjs/redux/blob/master/CHANGELOG.md) - [Commits](https://github.com/reduxjs/redux/compare/v4.2.1...v5.0.0) Updates `redux-thunk` from 2.4.2 to 3.1.0 - [Release notes](https://github.com/reduxjs/redux-thunk/releases) - [Commits](https://github.com/reduxjs/redux-thunk/compare/v2.4.2...v3.1.0) Updates `reselect` from 4.1.8 to 5.0.1 - [Release notes](https://github.com/reduxjs/reselect/releases) - [Changelog](https://github.com/reduxjs/reselect/blob/master/CHANGELOG.md) - [Commits](https://github.com/reduxjs/reselect/compare/v4.1.8...v5.0.1) --- updated-dependencies: - dependency-name: redux dependency-type: direct:development update-type: version-update:semver-major dependency-group: redux - dependency-name: redux-thunk dependency-type: direct:development update-type: version-update:semver-major dependency-group: redux - dependency-name: reselect dependency-type: direct:development update-type: version-update:semver-major dependency-group: redux ... Signed-off-by: dependabot[bot] <support@github.com>
-
Robert Knight authored
The loose distinction between `util/` and `helpers/` is that `util/` contains more general-purpose code that might be useful outside of the client, whereas `helpers/` contains more app-specific functions. The query parser is really the latter as it is closely linked to the annotation filtering logic implemented in `helpers/filter-annotations.ts`.
-
Robert Knight authored
Rename the module to match the main function it exports. This hopefully make it more obvious what the module does.
-
Robert Knight authored
The difference between `util/search-filter.ts` and `helpers/view-filter.ts` was previously not obvious from the name. One contains code to parse queries entered by the user, the other contains code to filter annotations against the parsed queries. Rename the parsing module and its functions to make it more obvious what they do.
-
- 11 Dec, 2023 10 commits
-
-
Robert Knight authored
Support `cfi:{start}-{end}` queries which filter annotations based on whether they have an associated EPUB CFI which lies in `[start, end)`. This query can be entered manually by the user in the search box, which is useful for testing, but the intent is that this filter would be used in contexts where the query is generated automatically (eg. as a result of a user making a selection from the book's table of contents).
-
Alejandro Celaya authored
-
dependabot[bot] authored
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.3.2 to 5.3.3. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/compare/v5.3.2...v5.3.3) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps the rollup group with 1 update: [rollup](https://github.com/rollup/rollup). - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/rollup/rollup/compare/v4.6.1...v4.8.0) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-minor dependency-group: rollup ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [prettier](https://github.com/prettier/prettier) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/3.1.0...3.1.1) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [preact](https://github.com/preactjs/preact) from 10.19.2 to 10.19.3. - [Release notes](https://github.com/preactjs/preact/releases) - [Commits](https://github.com/preactjs/preact/compare/10.19.2...10.19.3) --- updated-dependencies: - dependency-name: preact dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [npm-packlist](https://github.com/npm/npm-packlist) from 8.0.0 to 8.0.1. - [Release notes](https://github.com/npm/npm-packlist/releases) - [Changelog](https://github.com/npm/npm-packlist/blob/main/CHANGELOG.md) - [Commits](https://github.com/npm/npm-packlist/compare/v8.0.0...v8.0.1) --- updated-dependencies: - dependency-name: npm-packlist dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [gulp-changed](https://github.com/sindresorhus/gulp-changed) from 5.0.1 to 5.0.2. - [Release notes](https://github.com/sindresorhus/gulp-changed/releases) - [Commits](https://github.com/sindresorhus/gulp-changed/compare/v5.0.1...v5.0.2) --- updated-dependencies: - dependency-name: gulp-changed dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1512.0 to 2.1515.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.1512.0...v2.1515.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@npmcli/arborist](https://github.com/npm/cli/tree/HEAD/workspaces/arborist) from 7.2.1 to 7.2.2. - [Release notes](https://github.com/npm/cli/releases) - [Changelog](https://github.com/npm/cli/blob/latest/workspaces/arborist/CHANGELOG.md) - [Commits](https://github.com/npm/cli/commits/arborist-v7.2.2/workspaces/arborist) --- updated-dependencies: - dependency-name: "@npmcli/arborist" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 06 Dec, 2023 5 commits
-
-
Alejandro Celaya authored
-
dependabot[bot] authored
Bumps [tailwindcss](https://github.com/tailwindlabs/tailwindcss) from 3.3.5 to 3.3.6. - [Release notes](https://github.com/tailwindlabs/tailwindcss/releases) - [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/master/CHANGELOG.md) - [Commits](https://github.com/tailwindlabs/tailwindcss/compare/v3.3.5...v3.3.6) --- updated-dependencies: - dependency-name: tailwindcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps the eslint group with 2 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) and [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser). Updates `@typescript-eslint/eslint-plugin` from 6.13.1 to 6.13.2 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.13.2/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 6.13.1 to 6.13.2 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.13.2/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: eslint - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: eslint ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1510.0 to 2.1512.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.1510.0...v2.1512.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
Alejandro Celaya authored
-
- 05 Dec, 2023 3 commits
-
-
Robert Knight authored
-
Robert Knight authored
Support `page:{number}` or `page:{start}-{end}` filters in the sidebar. When the query is a number, it must match the page label exactly. When it is a range, it matches the page number if: - The start and end of the range, and page number, are all numeric - The page number is between the parsed `start` and `end` points, inclusive Part of https://github.com/hypothesis/client/issues/5937.
-
Robert Knight authored
Display page numbers on annotation cards when: - The `page_numbers` feature flag is enabled AND - The annotation has a `PageSelector` selector. This applies to VitalSource books and PDFs. Part of https://github.com/hypothesis/client/issues/5986
-
- 04 Dec, 2023 8 commits
-
-
dependabot[bot] authored
Bumps the sentry group with 2 updates: [@sentry/browser](https://github.com/getsentry/sentry-javascript) and [@sentry/cli](https://github.com/getsentry/sentry-cli). Updates `@sentry/browser` from 7.81.1 to 7.84.0 - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/develop/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/7.81.1...7.84.0) Updates `@sentry/cli` from 2.22.2 to 2.22.3 - [Release notes](https://github.com/getsentry/sentry-cli/releases) - [Changelog](https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-cli/compare/2.22.2...2.22.3) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: sentry - dependency-name: "@sentry/cli" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: sentry ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps the rollup group with 1 update: [rollup](https://github.com/rollup/rollup). - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/rollup/rollup/compare/v4.6.0...v4.6.1) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-patch dependency-group: rollup ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.31 to 8.4.32. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/8.4.31...8.4.32) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps the eslint group with 3 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin), [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) and [eslint](https://github.com/eslint/eslint). Updates `@typescript-eslint/eslint-plugin` from 6.12.0 to 6.13.1 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.13.1/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 6.12.0 to 6.13.1 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.13.1/packages/parser) Updates `eslint` from 8.54.0 to 8.55.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.54.0...v8.55.0) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: eslint - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: eslint - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: eslint ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps the babel group with 2 updates: [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) and [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env). Updates `@babel/core` from 7.23.3 to 7.23.5 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.5/packages/babel-core) Updates `@babel/preset-env` from 7.23.3 to 7.23.5 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.5/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: babel - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: babel ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1503.0 to 2.1510.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.1503.0...v2.1510.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
Robert Knight authored
This was downloaded from https://www.w3.org/WAI/WCAG20/Techniques/working-examples/PDF17/page-numbers.pdf, found via https://www.w3.org/TR/WCAG20-TECHS/PDF17.html.
-
Robert Knight authored
Capture the page number and label for PDF selections using the same `PageSelector` type that we use for selections in PDF-based VitalSource books. This has various uses, but one of the immediate ones is that it will allow us to do some testing of the VS page range behaviors with PDFs, which are more convenient to test with. Related to: - https://github.com/hypothesis/client/issues/5986. - https://github.com/hypothesis/client/issues/3720 (this proposes a more PDF-specific selector that would also capture the page region as a rect).
-
- 30 Nov, 2023 3 commits
-
-
Robert Knight authored
In real EPUB-based VS books, the `index` field of `PageInfo` objects returned by the `getCurrentPage` and `getPages` methods is undefined. Our mock VS book was incorrect in this respect. Correct the mock book to behave like real VS books here, and add a fallback method to obtain a page index for EPUB-based books by looking up the page in the list of pages returned by `MosaicBookElement.getPages`.
-
Robert Knight authored
Previously page number selectors were only added for PDF-based books. We are soon going to want the ability to filter annotations in the sidebar by page number, so record them for EPUB-based books as well. Previously there was a concern about how reliable the page numbers would be. I think the VS documentation for publishers, mentioned in the comments added here, addresses that.
-
Alejandro Celaya authored
-
- 29 Nov, 2023 1 commit
-
-
Alejandro Celaya authored
-
- 28 Nov, 2023 1 commit
-
-
Alejandro Celaya authored
-