- 18 Mar, 2020 2 commits
-
-
Robert Knight authored
- Add tests for multiple modifier keys - Add assertion to a test without any
-
Robert Knight authored
Trigger an error for incorrect use of `matchShortcut` by throwing an error if multiple non-modifier keys are specified.
-
- 13 Mar, 2020 2 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
- 12 Mar, 2020 4 commits
-
-
Robert Knight authored
Allow the user to create an annotation using the keyboard by selecting text (using any available method) and pressing the "a" key, or create a highlight by pressing the "h" key. The shortcuts are only enabled while the adder toolbar is visible. Since the toolbar is only shown for static text selections, I think we will be able to use single keys as the shortcuts without modifiers, and avoid conflicts with browser and OS shortcuts.
-
Robert Knight authored
- `installShortcut` is a function that installs a shortcut key sequence listener on the document body (or other user-specified element) - `useShortcut` is a hook that installs a shortcut when a component is mounted and removes it when the component is unmounted. It can be conditionally disabled by setting the shortcut to `null`, since hooks themselves cannot be called conditionally
-
Kyle Keating authored
Fix useElementShouldClose to work with Escape key
-
Kyle Keating authored
‘keypress’ is not fired for “Escape” key, so we need to listen for ‘keydown’
-
- 11 Mar, 2020 5 commits
-
-
Robert Knight authored
Remove unused array utility function
-
Lyza Danger Gardner authored
-
Lyza Gardner authored
Fix mutation violation when changing focused group
-
Lyza Danger Gardner authored
When the focused group is changed, top-level new annotations should be moved to that newly-focused group, and the newly-focused group should be persisted as the focused-group default for the user. Fix mutation violation when changing the focused group: create new `focus` method in `groups` service; use that to manage the logic of changing to a new focused group. Remove the `GROUP_FOCUSED` event. Manage the persisted focused-group default via the `defaults` store module.
-
Lyza Danger Gardner authored
- Fix naming of `$highlight` property - Add `newPageNote` fixture
-
- 10 Mar, 2020 7 commits
-
-
Robert Knight authored
Support selecting tabs with the keyboard
-
Robert Knight authored
Update a couple of variable names as suggested in PR feedback. - Add `is` prefix to bool prop - Rename `type` to `tabId`
-
Lyza Gardner authored
Extract thread-count functions into utility
-
Lyza Danger Gardner authored
-
Robert Knight authored
Fix hidden text for highlights affecting text selection
-
Robert Knight authored
The hidden "annotation start" and "annotation end" text added before and after highlights was visually hidden using `opacity: 0` but still interfered with text selection, presumably because the hidden text was still "visible" to hit testing. Revise the approach to use the CSS `clip` instead which avoids this problem. Fixes https://github.com/hypothesis/support/issues/92
-
Robert Knight authored
Tab bar buttons responded to mouse/touch press events to make tab switching feel fast and match how eg. browser tabs behave. However these were not triggered when activating the buttons using the keyboard. Resolve the issue by adding the standard click event handler and keeping the mousedown handler as an optimization. Also add a missing test for tab selection behavior.
-
- 09 Mar, 2020 12 commits
-
-
Sean Hammond authored
Bump fetch-mock from 9.0.0 to 9.1.1
-
Sean Hammond authored
Bump cross-env from 7.0.0 to 7.0.2
-
Sean Hammond authored
Bump terser from 4.6.4 to 4.6.6
-
Sean Hammond authored
Bump @sentry/browser from 5.13.0 to 5.13.2
-
dependabot-preview[bot] authored
Bumps [@babel/preset-env](https://github.com/babel/babel) from 7.8.6 to 7.8.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](https://github.com/babel/babel/compare/v7.8.6...v7.8.7) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.630.0 to 2.635.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.630.0...v2.635.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.18.3 to 7.19.0. - [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases) - [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](https://github.com/yannickcr/eslint-plugin-react/compare/v7.18.3...v7.19.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@babel/core](https://github.com/babel/babel) from 7.8.6 to 7.8.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](https://github.com/babel/babel/compare/v7.8.6...v7.8.7) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [cross-env](https://github.com/kentcdodds/cross-env) from 7.0.0 to 7.0.2. - [Release notes](https://github.com/kentcdodds/cross-env/releases) - [Changelog](https://github.com/kentcdodds/cross-env/blob/master/CHANGELOG.md) - [Commits](https://github.com/kentcdodds/cross-env/compare/v7.0.0...v7.0.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.13.0 to 5.13.2. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/5.13.0...5.13.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [terser](https://github.com/terser/terser) from 4.6.4 to 4.6.6. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/compare/v4.6.4...v4.6.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [fetch-mock](https://github.com/wheresrhys/fetch-mock) from 9.0.0 to 9.1.1. - [Release notes](https://github.com/wheresrhys/fetch-mock/releases) - [Commits](https://github.com/wheresrhys/fetch-mock/compare/v9.0.0...v9.1.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
- 06 Mar, 2020 8 commits
-
-
Robert Knight authored
Freeze store state with `immutable` in development builds
-
Robert Knight authored
Deep-freeze the store state after each action in development builds to catch accidental mutation bugs such as #1879. We couldn't do this in the past because the `annotation` component used to mutate newly created annotations. As a result of recent refactoring, this no longer happens.
-
Robert Knight authored
Remove `unloadAnnotations` method from `annotation-mapper`
-
Robert Knight authored
This method inadvertently (?) mutated annotations in the store which caused a crash later. Ultimately this method dispatched an event which was handled only in one place in `root-thread.js` to call `store.removeAnnotations()`. This commit removes the method and associated `ANNOTATIONS_UNLOADED` event and replaces callers with direct calls to `store.removeAnnotations(...)`. All uses of Angular events will soon need to be removed as part of the migration away from Angular JS, but that will happen separately. Fixes #1879
-
Lyza Gardner authored
Bump `eslint-config-hypothesis` and remove redundant `.eslintrc` rule
-
Lyza Danger Gardner authored
Upgrade `eslint-config-hypothesis` and remove the local `env` rule that is handled by it.
-
Robert Knight authored
Convert "adder" toolbar to Preact
-
Robert Knight authored
The adder toolbar used to set the `display` style property on its buttons to resolve an issue with a site that would add `display:none` to them. The linked issue no longer occurs, possibly because the use of Shadow DOM hides the buttons from `document.querySelectorAll(...)`. A timeout that was used to add/remove the `is-active` class from the toolbar appears to be unnecessary. The "grow and fade in" transition when the toolbar is shown works without it.
-