- 01 Apr, 2016 6 commits
-
-
Robert Knight authored
When parsing the '#annotations' fragment, ignore any extra content outside of the url-safe-base64 character set for annotation IDs. This helps in cases where extra content has been appended to the URL fragment after '#annotations:<ID>', before the client loads. This happens at one point during loading of Medium.com pages for example.
-
Nick Stenning authored
Uri normalize unicode
-
Nick Stenning authored
Avoid showing 'Clear Selection' or 'Clear Search' buttons whilst loading
-
Robert Knight authored
When loading annotations whilst a search query is active or selection is present, avoid showing the 'Clear Search' or 'Clear Selection' buttons until the search has actually completed and we know whether any annotations match the query or selection. This fixes the flash of the 'Clear Selection' button when viewing a direct-linked annotation.
-
Robert Knight authored
Fix broken loggedout CTA.
-
Sheetal Umesh Kumar authored
* Create a loggedout-message directive * Move related html to separate template https://trello.com/c/dR3qXaxx/257-add-explanatory-text-below-public-focused-annotation-when-logged-out
-
- 31 Mar, 2016 4 commits
-
-
Sean Hammond authored
Preserve URL fragments when redirecting to PDF.js in extensions
-
Robert Knight authored
Minor copy and style tweaks to the logged-out message
-
Nick Stenning authored
- We prefer "Hypothesis" in prose text to "Hypothes.is" - Remove unwanted padding at the end of anchors. - Say "sign in" rather than "log in," as we do everywhere else in the sidebar. - Slight improvement to readability of call-to-action sentence by separating the "X or Y" clauses. - Add a small gap between the two paragraphs.
-
Nick Stenning authored
Reintegrate annotation/document migration
-
- 30 Mar, 2016 7 commits
-
-
Sean Hammond authored
Preserve selection when switching accounts
-
Robert Knight authored
When visiting a direct-linked annotation (ie. #annotations:<id> is present in the URL) we want to preserve the selection when the user signs in, whether the annotation was private or in a group, in which case they will need to sign in to see it, or public, in which case they might need to sign in to reply. Previously public direct-linked annotations became deselected when signing in because they were unloaded when switching accounts, and this fired the same ANNOTATION_DELETED event as when an annotation is removed, which results in the annotation being removed from the selection. This commit enables the selection to be preserved by introducing a different event within the app when annotations are unloaded vs. deleted. When an annotation is unloaded, it is not removed from the selection.
-
Robert Knight authored
Fix a unicode warning
-
Robert Knight authored
CSP Violation: form input onfocus
-
Robert Knight authored
Merge pull request #3124 from hypothesis/sheetaluk/257-add-explanatory-text-below-public-focused-annotation-when-logged-out Add message when user logged out and directed to an annotation.
-
Sheetal Umesh Kumar authored
When non-hypothesis users(or logged out users) are viewing a direct linked annotation, we want to help them understand what they are looking at and encourage them to sign up(or sign in). Display a CTA message when: * user is logged out * user has landed on a DL * there is a selection * user has permissions to view the selection Also, * Add logo svg * Update icomoon css * Pull variables\.scss from 03cbef2
-
Christof Dorner authored
Fix the signature of NSQ error/exception handlers
-
- 29 Mar, 2016 6 commits
-
-
chdorner authored
Which fixes a CSP violation with having inline JavaScript.
-
Christof Dorner authored
Merge pull request #3146 from hypothesis/sheetaluk/294-as-a-user-i-want-to-be-able-to-find-out-who-is-a-member-of-a-group-i-m-in Show list of group members in the group page.
-
Sheetal Umesh Kumar authored
Users want to see other users in the groups they belong to and annotations each of these users have made and shared with a group. This will help them decide how to share annotations with their groups. https://trello.com/c/rSUQLuos/294-as-a-user-i-want-to-be-able-to-find-out-who-is-a-member-of-a-group-i-m-in
-
Robert Knight authored
List group memberships of user in admin interface
-
Robert Knight authored
Use event constants consistently for events that are emitted via $rootScope.
-
Robert Knight authored
-
- 24 Mar, 2016 6 commits
-
-
Nick Stenning authored
Convert AnnotationUI, AnnotationUISync from CoffeeScript to JS
-
Nick Stenning authored
Add Visual Studio Code project config file for JS
-
Robert Knight authored
Merge pull request #3130 from hypothesis/sheetaluk/303-add-explanation-text-to-the-sharer-on-only-me-and-group-annotations Add message to private and group annotations sharer.
-
Robert Knight authored
Use specific Sentry DSN for the client part of H
-
Robert Knight authored
Fix CSP violation on new homepage
-
chdorner authored
Since we are not allowing inline styles with our CSP policy.
-
- 23 Mar, 2016 5 commits
-
-
Sheetal Umesh Kumar authored
-
Robert Knight authored
rearranging annotation icons
-
Sheetal Umesh Kumar authored
* Rearrange the annotation action icon positions. * Add new colours for annotation action button labels. * Replace icons for reply, edit, delete and share. * Update style for loggedout users too. * Update share icon in top-bar.
-
Robert Knight authored
-
Robert Knight authored
In combination with JSDoc annotations, this enables IntelliSense, project navigation, inline documentation, refactoring and other goodies using Visual Studio Code and other IDEs that integrate with TypeScript's Language Service for JavaScript (aka. 'Salsa'). See https://code.visualstudio.com/docs/languages/javascript The project file can be named either `jsconfig.json` without 'allowJs' or `tsconfig.json` with the 'allowJs' config option enabled. I've opted for `tsconfig.json` because that turns up better documentation on the web and is recognized by more tools. The project config file lives in h/static/scripts so that Visual Studio only tries to parse and process .js files under that directory. The config file does support specifying the set of files to include, but each file currently has to be listed individually. Glob support is planned for the future. See https://github.com/Microsoft/TypeScript/issues/1927
-
- 22 Mar, 2016 6 commits
-
-
Nick Stenning authored
Support filtering test suites to run using '--grep' argument to gulp
-
Robert Knight authored
Remove user status bitfield
-
Nick Stenning authored
Display message if a direct-linked annotation is not available
-
Robert Knight authored
The image is specified using the `background-image` property since that makes it easy to use the same relative URL when the app is served from the extension and when it is served from the site.
-
Robert Knight authored
If an annotation is selected but was not successfully loaded, display a message in the sidebar indicating that the user does not have permission to see that annotation.
-
Robert Knight authored
Add support for filtering the tests that are run by Gulp test tasks using '--grep <pattern>'. This avoids the need to use the `(describe|it).only` test modifiers to filter the tests that are run. The pattern argument is a JS regex expression which is passed directly to mocha as the 'grep' option. eg. To start the app test suite in auto-restart mode, but only run tests for the markdown editor, run: gulp test-watch-app --grep markdown
-