- 14 Jul, 2015 3 commits
-
-
Randall Leeds authored
Rather than having each of the anchoring implementations have different call signatures for their methods, use an options argument that varies in content between the implementations, but probably shares some core options like the root node.
-
Randall Leeds authored
The core of anchoring in the guest code is now asynchronous. - Anchoring annotations happens asynchronously in the setup function. - Creating an annotation is asynchronous, and depends upon the resolution of the targets, which may depend on the resolution of the document metadata. The first events fire only after this happens. - The Anchor API can now optionally return Promises when converting ranges and selectors, though all the present implementations are synchronous.
-
Randall Leeds authored
It went down something like this: :city_sunset::sparkles::alien::sweat_drops::pray::boom::city_sunrise:
-
- 09 Jul, 2015 5 commits
-
-
Randall Leeds authored
s/viewable/visible/
-
judell authored
-
Randall Leeds authored
Proper feature flags
-
Nick Stenning authored
Our first attempt at integrating feature flags with the frontend required a rebuild and redeploy of the extension, which somewhat defeats the purpose of feature flags. This commit wires up the new feature client introduced in the preceding commits, allowing feature toggles to update behaviour of already-deployed clients.
-
Nick Stenning authored
In order to respond to feature flag changes on the frontend, we need a way of knowing what the current feature flag values are on the backend. This commit adds a basic feature flag client that retrieves current feature flag values by making an ajax request to the server. The client also includes a cache, and supports retrieving new value from the server when the cache expires.
-
- 07 Jul, 2015 1 commit
-
-
Randall Leeds authored
Thread collapsing redux
-
- 06 Jul, 2015 3 commits
-
-
Randall Leeds authored
Since there is no username, collapsing a draft when not signed in had been causing the annotation to disappear completely. Now, there is a clear prompt that holds the space.
-
Randall Leeds authored
Make the tags section use .annotation-body (because tags are a form of body) and put the form actions, reply count, and license messages into the footer so that these collpasing properly and uniformly.
-
Jake Hartnell authored
-
- 03 Jul, 2015 4 commits
-
-
Randall Leeds authored
This reverts commit 561544e4d289e728035aa9b549758b3b55d281f0.
-
Randall Leeds authored
This reverts commit 0c6bd1b36e234c43cfdb15edac1d06792c6f259a, reversing changes made to 0ffdda5d6d144d184348574ada953354100788c6.
-
Randall Leeds authored
Be slightly more defensive when processing annotations for the atom feed.
-
Nick Stenning authored
Expand the search API docs
-
- 02 Jul, 2015 7 commits
-
-
Randall Leeds authored
Improve thread collapsing UX.
-
Randall Leeds authored
- Keep the namespaced classes sorted by file - Keep the collapsed annotation overrides in the annotation file - Improve the vertical alignment of the timestamp better - Make margins and elements go away in the collapsed state rather than using negative margins to hide them - Simplify the thread expander styles
-
Jake Hartnell authored
Topbar toolbar harmony
-
Randall Leeds authored
Fix guest embedding
-
Jake Hartnell authored
To prevent an Annotator is undefined error, the constructor class is set by the object returned from the hypothesisConfig function. The documentation has also been updated.
-
Randall Leeds authored
When the search icon is clicked give focus to the search input.
-
Randall Leeds authored
Harmonize the styles of the buttons in the top bar and the toolbar. - Match font size of icons at 18px - Buttons are .btn-clean and have minimum width so icons are square - Transitions for background color - Simplify the styles for the top bar, using the newly consistent clean top bar button styles instead of specific styles for the share button.
-
- 30 Jun, 2015 1 commit
-
-
Jake Hartnell authored
- Threads collapse to single lines. - Use iconograpy consistent with collapsing / expanding UI in other applications - Threads are fully expanded when you click replies on a top level annotation. - Delete old test and add new tests.
-
- 27 Jun, 2015 1 commit
-
-
Randall Leeds authored
-
- 26 Jun, 2015 2 commits
-
-
Randall Leeds authored
Add ability to share via links from the sidebar.
-
Nick Stenning authored
Use of {{angular templates}} causes problems on pages with Annotator enabled due to Annotator's habit of splitting text nodes whenever you select anything. Specifically -- if you select one of the words in this text and then change the privacy setting, it will end up rendering as something like PubliOnly Me Only Melic or similar. Using a span tag and ng-bind is a bit of a hack but it prevents this from happening. Oh, Angular...
-
- 19 Jun, 2015 6 commits
-
-
Randall Leeds authored
Make annotation visibility level more explicit
-
Jake Hartnell authored
- Private annotations have the word private as well as the lock icon on the card - Small styling refinements have been added to make the annotation-license - Show the word private alongside lock icon. - Show message explain visibility setting when editing.
-
Randall Leeds authored
Small ux improvements
-
Jake Hartnell authored
-
Jake Hartnell authored
- Use document plugin to get canonical url for sharing. - Introduce Topbar share icon - Add social media icons to icomoon - Generate via uri in the share-dialog directive - Add sharing via Facebook, Twitter, Google plus, and email - Make account dialog and share dialog consistent - Add information about sharing to the help page. - Add tests (Thanks @nickstenning!)
-
Jake Hartnell authored
-
- 18 Jun, 2015 1 commit
-
-
Jake Hartnell authored
-
- 06 Jun, 2015 1 commit
-
-
Sean Hammond authored
Report form level errors
-
- 05 Jun, 2015 5 commits
-
-
Nick Stenning authored
When we call `form.validate()` and the validation fails, the raised exception is a `deform.ValidationFailure`. This object has an `error` attribute which represents the underlying validation error object for the entire form. Previously, if the validation failure were a result of top-level validation errors (such as the fact that an unactivated user is trying to log in), this error would be lost, because we only reported errors for the forms fields, or "children". This commit changes `h.accounts.views.validate_form` so that it converts the entire `colander.Invalid` object into a dictionary using its `asdict()` instance method. By doing this, we get two immediate benefits: - top-level validation errors are reported in the '' (empty string) field - we avoid the need to aggregate form field errors by hand in ajax_form In addition, we need to deal with this case on the frontend, so this commit also changes the formRespond directive so that if no overall "reason" is provided for failure, then an empty-string member of the "errors" object can set the overall validation status (and error message) for the form.
-
Nick Stenning authored
Refactor search
-
Nick Stenning authored
Ask for "Username or email address" when logging in
-
Sean Hammond authored
-
Sean Hammond authored
-