- 07 May, 2020 1 commit
-
-
Lyza Danger Gardner authored
We’ve had a lot of `codecov` failures that result from tiny apparent coverage fluctuations. Set a threshold to attempt to filter out noisy, meaningless failures.
-
- 06 May, 2020 17 commits
-
-
Lyza Gardner authored
Add `aria-label` and/or `title` to `<button>` elements
-
Lyza Gardner authored
Add `aria-expanded` to excerpt show/hide toggles
-
Lyza Gardner authored
Add more properties to sample config in `dev-server`
-
Lyza Gardner authored
Change show/hide sidebar button label depending on state
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
Only set `aria-label` and `title` attributes on `<button>` elements if they are different from the text displayed in the button.
-
Lyza Danger Gardner authored
For developer convenience, add a few more (commented-out) properties to the config used by the local devserver, and link to more documentation
-
Lyza Danger Gardner authored
-
Lyza Gardner authored
Add word-break rule to prevent long-string overflows
-
Robert Knight authored
Fix "New annotation"/"New page note" label
-
Robert Knight authored
The button label should be "New annotation" if text is selected or "New page note otherwise", but it was the wrong way round. Fixes a regression introduced in #2102
-
Robert Knight authored
Change the sidebar toggle button from being a toggle button with the label "Show annotation sidebar" to a normal button that changes between "Show annotation sidebar" and "Hide annotation sidebar" labels. WAI-ARIA guidelines [1] suggest that both are valid ways of implementing toggle actions and looking around web and native apps on macOS one can find plenty of both for similar actions. The one clear requirement is to use a label change OR aria-pressed, but not both. We think [2] a label change will make the state slightly easier to quickly discern and it provides a more useful tooltip for sighted desktop users. [1] https://www.w3.org/TR/wai-aria-practices-1.1/#button [2] https://github.com/hypothesis/client/issues/2055#issuecomment-622512247 Fixes https://github.com/hypothesis/client/issues/2055.
-
Robert Knight authored
Re-implement the sidebar's vertical toolbar
-
Robert Knight authored
This is addressed by the `if @frame` logic a few lines down which only adds the toolbar if we're providing our own frame.
-
Robert Knight authored
Address PR feedback by rewriting several test descriptions and adding comments.
-
Robert Knight authored
This commit re-implements the vertical toolbar on the left edge of the sidebar to make future changes to the toolbar UI easier (eg. some upcoming a11y changes) and to decouple it from the rest of the annotator application (the toolbar and `Sidebar`/`Guest` classes currently access each other's internals in a rather haphazard way). The new implementation has a similar code structure to the `Adder` toolbar that is shown when selecting text. It consists of: 1. A Preact component in `src/annotator/components/toolbar` which renders the toolbar UI according to the current state 2. A controller class in `src/annotator/toolbar.js` which renders the Preact component into a container element and has provides properties that the `Sidebar` and `Guest` classes can use to update its state. The controller takes only the container element and callbacks associated with each button as inputs, so it no longer calls methods on the Guest/Sidebar. The sidebar and guest now update the toolbar UI by setting properties on the toolbar controller, rather than using a mixture of manual manipulation of the toolbar DOM and publishing events which get eventually translated to method calls on the toolbar. If we convert the remainder of the sidebar UI from jQuery/manual DOM updates to Preact in future, then we can remove the toolbar controller entirely and just render the toolbar component from within the sidebar component.
-
- 05 May, 2020 17 commits
-
-
Kyle Keating authored
allowLeavingGroups is a new service level config setting that can globally override the the UI to hide the leave button for a group. This is necessary for section groups in LMS where groups are indeed private, but also can’t be left.
-
Lyza Danger Gardner authored
Add `word-break` rule to `markdown-view` CSS to prevent long strings of characters, e.g. URLs, from breaking out of the sidebar width in replies. Fixes https://github.com/hypothesis/support/issues/101
-
Robert Knight authored
Cleanup sidebar CSS
-
Robert Knight authored
This rule is already in the user-agent stylesheet for Safari, Chrome and Firefox.
-
Robert Knight authored
This doesn't belong here and we don't have a `<markdown>` element in the app any more.
-
Robert Knight authored
Refactor the styles used by the `HypothesisApp` component and other top-level elements in the sidebar page to follow the conventions used by other components. Also clean up some unused styles. - Rename CSS classes for `HypothesisApp` component to `hypothesis-app*` to follow our normal naming conventions - Consolidate styles for the `body` element in `sidebar.scss` - Consolidate general element styles in `elements.scss`, eliminating `common.scss` - Remove unnecessary styles for `html` and `body` - Move `sheet` styles into `focused-mode-header` class, since these styles were only ever applied to that element - Extract the styles from the `content` class used to center content in the top bar and content area into a mixin and then use that mixin in the component styles for the top bar and content area - Remove unused mixin imports from `sidebar.scss`. These are no longer needed since the transition to the new SASS module system
-
Robert Knight authored
Follow the module naming convention of other components.
-
Robert Knight authored
Remove unused `USER_CHANGED` event
-
Lyza Gardner authored
Improve document outline and stucture
-
Robert Knight authored
Bump puppeteer from 3.0.1 to 3.0.2
-
Robert Knight authored
Bump karma from 5.0.2 to 5.0.4
-
dependabot-preview[bot] authored
Bumps [karma](https://github.com/karma-runner/karma) from 5.0.2 to 5.0.4. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](https://github.com/karma-runner/karma/compare/v5.0.2...v5.0.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
Bump terser from 4.6.12 to 4.6.13
-
Robert Knight authored
Bump karma-mocha from 2.0.0 to 2.0.1
-
dependabot-preview[bot] authored
Bumps [@babel/preset-env](https://github.com/babel/babel) from 7.9.5 to 7.9.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](https://github.com/babel/babel/compare/v7.9.5...v7.9.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@babel/core](https://github.com/babel/babel) from 7.9.0 to 7.9.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](https://github.com/babel/babel/compare/v7.9.0...v7.9.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
Bump postcss from 7.0.27 to 7.0.29
-
- 04 May, 2020 5 commits
-
-
Robert Knight authored
All consumers of this event have now been migrated to watch `store.profile()` and/or `store.hasFetchedProfile()` instead.
-
dependabot-preview[bot] authored
Bumps [postcss](https://github.com/postcss/postcss) from 7.0.27 to 7.0.29. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/master/CHANGELOG.md) - [Commits](https://github.com/postcss/postcss/compare/7.0.27...7.0.29) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.663.0 to 2.669.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.663.0...v2.669.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
Migrate HypothesisApp component and remove AngularJS
-
Robert Knight authored
-