- 26 Nov, 2013 3 commits
-
-
csillag authored
* Updated dom-text-matcher to dd5d2eaf (master branch) * Updated Annotators' FuzzyTextAnchors plugin to e2e98dd8 (typed-packaging branch) Fixes #941.
-
csillag authored
This new version replaces PDF.js's top-level text extraction logic with a manual override, in order to try to avoid concatenated words. Fixes #940.
-
Ujvari Gergely authored
-
- 25 Nov, 2013 2 commits
-
-
Kristof Csillag authored
Incorporate the latest work done on Annotator's typed-packaging branch. There are almost no H-related changes here; it's only about Annotator internal changes. (Packaging and cosmetic fixed, and a few smaller bug fixes.)
-
csillag authored
-
- 22 Nov, 2013 2 commits
- 18 Nov, 2013 1 commit
-
-
csillag authored
* Update Annotator to 62c94fc (typed-anchors-final branch, replacing maintence for now) * Updated guest.coffee Fixes #929.
-
- 16 Nov, 2013 1 commit
-
-
csillag authored
-
- 15 Nov, 2013 3 commits
-
-
csillag authored
-
Kristof Csillag authored
Introducing typed anchor support
-
csillag authored
* Updated Annotator to de4c0dfc (maintenance branch), which has typed anchors support merged. See https://github.com/hypothesis/annotator/pull/18 for explanation. The H specific parts: * Following Annotator API and packaging changes * The heatmap got a lot trickier. Since it can no longer make any assumption about the actual implementation of the highlights and anchors, now it does not rely on any data inside them. That includes the start and stop character offsets, too, which was previously used to find the nearest anchor for the up/down arrows on. We can't assume that all anchors have that data. Unfortunately, the Y coordinate is not always available, because the required part of the DOM might not be rendered yet. So the only data we have is the page number. (All anchors have page numbers). In the first phase, we only collect the anchors from the nearest page. Then we go there, to assure that it's rendered. When all the anchors have been realized, we select the nearest one, and actually scroll to it. This way, we can make it work with all kinds of anchors/highlights.
-
- 12 Nov, 2013 9 commits
-
-
csillag authored
-
csillag authored
This version fixes yet other race condition during initialization. Fixes #892. Hopefully, it really stays dead this time.
-
csillag authored
This version fixes another race condition during initialization. Hopefully fixes #892 for good.
-
csillag authored
This version delays the PDF scanning until the document is ready. Fixes #892.
-
Randall Leeds authored
Add my annotations link under user account menu in sidebar.
-
csillag authored
-
Kristof Csillag authored
Added PDF support - we can now annotate PDF documents
-
csillag authored
* Update dom-text-mapper to fcd26632 (master branch) * Update dom-text-matcher to fcd26632 (master branch) * Update Annotator to f1e08bdd (maintenance branch) * Updated assets.py for the changed Annotator files and libraries * Updated JSChannel with a patch to allow talking to pdf.js * Updated our code to follow Annotator API changess * Updated the heatmap for two-phase anchoring and virtual anchors The change in embed.txt fixes a sporadic code insertation problem. For pages with no script tags, our embed script sometimes crashed. I have already fixed this problem for YepNope (see #607), but now it has come back in our own code. I am not sure why have not this happened before, but it definitely was happening now. I applied the same fix that worked with YepNope. It worked again.
-
Randall Leeds authored
This reverts commit ba92681d2fed403a00b49e13697b13aa37e0e855, reversing changes made to 71dd9111bad26d5d4235ecdd1b42c60591cd2f35.
-
- 11 Nov, 2013 9 commits
-
-
gergely-ujvari authored
CodeAuth plugin (user authentication functions for host side)
-
csillag authored
If you load this plugin (which is disabled by default), these methods can be used for integrating H login mechanism with code living on the host page: * annotator.getLoginStatus() * annotator.loginWithUsernameAndPassword(username, password) * annotator.logout() * annotator.registerUser(username, email, password) These all return promises. Furtheremore, the following events have been introduced: * annotatorLogin, upon successfull login * annototorLogout, upon log out Note: these events are *not* fired in cases when the events were triggered by a call from the given host/guest-side annotator instance; use the promises to react those events. The events only happen if these events were triggered from the sidebar, or from other host/guest frames.
-
csillag authored
-
gergely-ujvari authored
If sidebar is closed, display flash messages in the host frame
-
csillag authored
In sidebar: * Save our H instance as window.annotator * Add isOpen() method to test if the sidebar is open * Removed unused draft dependency from controller In host document: * Add support for showing the flash messages * Save the Annotator class as @Annotator * Redefine the notification level constants in Annotator.Notification so that they are consistent with the ones used in the sidebar Flash message service: * Add workaround for duplicate "invalid uname or pw" error message, and also swallow the "your submission was invalid" in this case. * When the sidebar is closed, pass the message to the host frame instead. Fixes #886.
-
csillag authored
-
RawKStar77 authored
Added fix for github issue 885, and fixed another bug I found whereby a long string of characters unbroken by white space wouldn't wrap on the stream page.
-
csillag authored
There were some cases when we tried to reload the annotations (upon detecting auth state) even before the store plugin was initialized, and this caused an error message. This check works around this problem. Fixes #899.
-
csillag authored
-
- 10 Nov, 2013 4 commits
-
-
Kristof Csillag authored
Lookup exact username from the db for stream-search
-
Ujvari Gergely authored
When a force login is in effect H removes all annotations and reloads them. In the reload process if the clickAdder() call is happenning too soon then an empty reference will be put in a heatmap bucket instead of the newly created annotation, thus resulting a "zombi" in the Viewer. This may help for #881
-
Ujvari Gergely authored
-
Ujvari Gergely authored
Sometimes this call could get undefined elements (already deleted) in its annotations argument. This change filters these and only displays valid annotations. One tricky source to create these undefined elements is: trying to create a new annotation when no user is logged in and also H is in dynamic bucket mode. Here when we realize that a login is needed, we already have an annotation stub, which we delete in the login process but the heatmap annotation items in the _fillDynamicBucket() before the login and an undefined empty stub survives. This will be an 'undefined' item in the updateViewer(annotations) call. Fixes #897
-
- 07 Nov, 2013 1 commit
-
-
csillag authored
Fixes #697 (also known as #879).
-
- 31 Oct, 2013 1 commit
-
-
Randall Leeds authored
Adjusted tab positioning at the request of @dwhly.
-
- 30 Oct, 2013 1 commit
-
-
RawKStar77 authored
-
- 28 Oct, 2013 1 commit
-
-
csillag authored
since our updated Angular.js version has it now. Fixes #854. Thanks to @gergely-ujvari for the tip.
-
- 27 Oct, 2013 2 commits
-
-
Randall Leeds authored
Fixes #858
-
csillag authored
Don't use single-phase fuzzy matching for quotes shorter than 32 characters. Fixes #853.
-