1. 18 Nov, 2016 2 commits
  2. 17 Nov, 2016 1 commit
  3. 16 Nov, 2016 1 commit
  4. 15 Nov, 2016 1 commit
  5. 08 Nov, 2016 2 commits
    • Robert Knight's avatar
      Fix incorrect usage of Sinon assertions (#162) · 6975c449
      Robert Knight authored
      This fixes a couple of incorrect usages of Sinon assertions which
      resulted in test failures with the latest patch version of Sinon.
      
       * assert.calledOnce() only takes one argument
      
       * Sinon assertions do not take a message argument as Chai assertions
         do. See http://sinonjs.org/docs/#assertions
      6975c449
    • Robert Knight's avatar
      Remove AnnotationUISync service (#127) · bb71cd77
      Robert Knight authored
      * Move event handlers out of AnnotationUISync
      
      As a step towards having all bridge event handlers in one place, move
      these event handlers into frameSync.
      
       * Add tests for findIDsForTags() and for re-exporting of this
         function from annotationUI
      
      * Move sidebarOpened event handler to FrameSync service
      
      * Remove the AnnotationUISync service
      
      Its functionality has now been moved into the FrameSync service, except
      for the logic that was intended to synchronize the "Show Annotation
      Highlights" logic across multiple frames, since this is clearly broken
      [1].
      
      The two pieces of functionality related to this we need to support at
      the moment are:
      
       1. The `showHighlights` config option to set whether highlights are
          initially visible.
      
       2. The highlight toggle button in the sidebar's outer frame
      
      Both of these work without the sidebar app's involvement.
      
      [1] See https://github.com/hypothesis/h/issues/3433 and
          https://github.com/hypothesis/h/pull/3295
      bb71cd77
  6. 04 Nov, 2016 4 commits
  7. 28 Oct, 2016 2 commits
  8. 25 Oct, 2016 5 commits
  9. 24 Oct, 2016 4 commits
  10. 21 Oct, 2016 5 commits
  11. 20 Oct, 2016 2 commits
  12. 19 Oct, 2016 4 commits
  13. 17 Oct, 2016 3 commits
  14. 14 Oct, 2016 2 commits
    • Robert Knight's avatar
      Add a set of HTML anchoring tests with expected failures · 025d41e2
      Robert Knight authored
      Add a set of tests which check that Ranges within a DOM tree are
      correctly 'described' as selectors and then successfully converted back to
      Range objects by anchoring.
      
      The tests are derived from the suite of test cases collected for the
      Annotator project at
      https://github.com/openannotation/annotator/blob/v1.2.x/test/spec/range_spec.coffee
      
      These tests found failures in describing ranges with position and quote
      selectors in many cases and with a range selector in one case. The test
      lists and checks these expected failures.
      025d41e2
    • Robert Knight's avatar
      Fix formatting changes made via toolbar buttons not persisting · 3e084ccb
      Robert Knight authored
      When making formatting changes to the text of an annotation with the
      toolbar button without subsequently making a manual edit before clicking
      Preview or Save, the onEditText() callback was never triggered and so
      the unsaved changes were reverted when exiting edit mode.
      
      This happened because onEditText() was only fired in response to the
      'input' event which only occurs in response to programmatic, not manual
      changes to the input's value.
      
      Fixes #147
      3e084ccb
  15. 13 Oct, 2016 1 commit
  16. 12 Oct, 2016 1 commit