Skip to content

C
coopwire-hypothesis
Switch branch/tag
  1. 19 Nov, 2019 3 commits
    • Robert Knight's avatar
      Improve search input UX on mobile · 29f15b4a
      Robert Knight authored 
       - Set an `action` on the form so that the virtual keyboard shows a
   submit button, which makes it easier to trigger a search

 - Use a larger font size for readability and to prevent iOS from
   zooming into the field on desktop websites
      29f15b4a
    • Robert Knight's avatar
      Improve mobile UX of markdown editor · 71d828a7
      Robert Knight authored 
       - Increase the font size of the input field to make the text easier to
   read, and more importantly, stop iOS from zooming into the text field
   on mobile-optimized sites (ie. those with `<meta name="viewport"
   content="width=device-width, initial-scale=1">` in the host page)

 - Make the toolbar buttons bigger when using touch input and add space
   below the toolbar so that the browser can differentiate taps on the
   buttons from taps on text selection handles

 - Prevent toolbar overflowing annotation card on small screens.
   We use either horizontal scrolling or wrapping depending on the input mode
   (touch/non-touch). Scrolling saves vertical space, but could be inconvenient
   to use with a mouse or touchpad.

fixup! - Update comments
      71d828a7
    • Robert Knight's avatar
      Merge pull request #1479 from hypothesis/annotator-toolbar-focus-ring · 73e0e81a
      Robert Knight authored 
      Show focus ring on annotator toolbar buttons when using keyboard focus
      73e0e81a
  3. 18 Nov, 2019 19 commits
  5. 15 Nov, 2019 5 commits
  7. 14 Nov, 2019 1 commit
    • Lyza Danger Gardner's avatar
      Prevent errors arising from applying private permissions to anonymous annotations · 8ca4773b
      Lyza Danger Gardner authored 
      As a convenience, the app retains the last permissions level used by a user when publishing an annotation. For example, if a user creates and saves and annotation that is set to “only me”/private, the app stashes that as a pseudo-preference in `localStorage` and the next time a user creates a new annotation, that will be the default permissions level applied to it. This makes it easier to create several subsequent annotations that have the same permissions/sharing setting.

There is a bug in this approach, however, which before this patch happened when:

* A Hypothesis user creates an annotation and sets the permissions to “private” (only me) and saves the annotation successfully to the `h` service, then;
* The Hypothesis user logs out, then;
* The same person in the same browser (now an anonymous user from Hypothesis’ perspective) selects some text and clicks “annotate., then;
* The user is shown an error message that they must log in to create annotations: they click “Log In”

Before this fix, the user then would see an error “Cannot read property ‘split’ of null” in an error flash and the login process would not successfully complete. The only workaround was to reload the browser window and try again.

After this fix, the user will not see an error after the sequence detailed above and the login process will complete.

This fix is achieved by preventing the app from attempting to apply default permissions of “only me”/private when no `userid` is available. Doing so creates corrupted permissions on the annotation which throw `TypeError`s when later iterated over.

There are several further fixes necessary to fully clean up this situation, but this patches over the immediate user-visible bug.

Fixes https://github.com/hypothesis/client/issues/1221
      8ca4773b
  9. 13 Nov, 2019 3 commits
  11. 12 Nov, 2019 7 commits
  13. 11 Nov, 2019 2 commits