1. 06 Apr, 2020 1 commit
    • Robert Knight's avatar
      Improve readability of nested highlights in PDFs · 2d296040
      Robert Knight authored
      In PDFs, highlights are drawn in an otherwise-transparent text layer _on
      top_ of a canvas which displays the text that the user sees. Therefore
      highlights reduce the contrast of the text below and more than two
      levels starts to make the text very difficult to read.
      
      The ideal solution would be to draw the highlights below the text, but
      that's not trivial.
      
      As a simple step to improve the situation, make nested highlights that
      are 3+ levels deep transparent. This limits the amount of contrast
      reduction that overlapping highlights can cause.
      
      In web pages, the highlights are drawn _behind_ the text, so contrast is
      not reduced as much, but the same change is applied there for a
      consistent experience and also because it is easier to implement.
      
      Partially addresses:
      
       - https://github.com/hypothesis/client/issues/1995
       - https://github.com/hypothesis/client/issues/408
      2d296040
  2. 03 Apr, 2020 6 commits
    • Robert Knight's avatar
      Merge pull request #1991 from hypothesis/fix-hammerjs-error · 918025f4
      Robert Knight authored
      Fix Hammer.JS error on web pages that use Require.JS
      918025f4
    • Robert Knight's avatar
      Merge pull request #1931 from hypothesis/add-view-annotations-to-toolbar · a137343e
      Robert Knight authored
      Add button to adder toolbar to show annotations for selection
      a137343e
    • Robert Knight's avatar
      c7d1d031
    • Robert Knight's avatar
      Improve a JSDoc comment · 4a9fe98d
      Robert Knight authored
      4a9fe98d
    • Lyza Gardner's avatar
      Merge pull request #1990 from hypothesis/remove-annotation-header-prop · 3bc4c028
      Lyza Gardner authored
      Remove `onReplyCountClick` prop and use store method instead
      3bc4c028
    • Robert Knight's avatar
      Add "Show" button to adder toolbar · c827754c
      Robert Knight authored
      Add a button to the adder toolbar to show the existing annotations that
      relate to the selected text, along with a keyboard shortcut (the "s"
      key) to trigger it. This provides a way to filter annotations in the
      sidebar to those that correspond to a particular highlight or region of
      text using only the keyboard.
      
      Instead of an icon the "Show" toolbar button displays a badge whose
      label is the number of annotations associated with the selection, as
      that is more informative.
      
      In implementing this, the CSS for the adder toolbar was refactored to
      make the effects of several rules easier to follow and improve readability of
      toolbar button labels:
      
       - Use of `!important` was removed. This used to be for the purpose of
         overriding any page styles which affected the adder. That issue no
         longer applies in most browsers due to the use of Shadow DOM to
         isolate the adder from the page's styles.
      
         This may cause a regression on some pages in older browsers which don't
         support Shadow DOM, if those pages' have generic CSS rules which
         style generic elements.
      
       - To make the label easier to read, the font size was slightly
         increased
      c827754c
  3. 02 Apr, 2020 11 commits
  4. 01 Apr, 2020 10 commits
  5. 31 Mar, 2020 5 commits
  6. 30 Mar, 2020 7 commits