- 27 Nov, 2016 1 commit
-
-
Robert Knight authored
Use the same trick that was applied to the adder in d9644a80 to reduce the likelihood of the page's own CSS styling modifying the appearance of highlights. Compared to alternative methods which would raise the precedence of highlight styling (inline styles, !important !all !the !things, selector precedence hacks), this approach is simpler as it makes the conflicting rule from the page's own styling not apply at all. Fixes hypothesis/h#3520
-
- 18 Nov, 2016 2 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
- 17 Nov, 2016 1 commit
-
-
Robert Knight authored
Added links to help center from help panel
-
- 16 Nov, 2016 1 commit
-
-
Sean Roberts authored
-
- 15 Nov, 2016 1 commit
-
-
Christof Dorner authored
Fix Jenkins builds failing if package.json or shrinkwrap change after branch is initially pushed
-
- 08 Nov, 2016 2 commits
-
-
Robert Knight authored
This fixes a couple of incorrect usages of Sinon assertions which resulted in test failures with the latest patch version of Sinon. * assert.calledOnce() only takes one argument * Sinon assertions do not take a message argument as Chai assertions do. See http://sinonjs.org/docs/#assertions
-
Robert Knight authored
* Move event handlers out of AnnotationUISync As a step towards having all bridge event handlers in one place, move these event handlers into frameSync. * Add tests for findIDsForTags() and for re-exporting of this function from annotationUI * Move sidebarOpened event handler to FrameSync service * Remove the AnnotationUISync service Its functionality has now been moved into the FrameSync service, except for the logic that was intended to synchronize the "Show Annotation Highlights" logic across multiple frames, since this is clearly broken [1]. The two pieces of functionality related to this we need to support at the moment are: 1. The `showHighlights` config option to set whether highlights are initially visible. 2. The highlight toggle button in the sidebar's outer frame Both of these work without the sidebar app's involvement. [1] See https://github.com/hypothesis/h/issues/3433 and https://github.com/hypothesis/h/pull/3295
-
- 04 Nov, 2016 4 commits
-
-
Robert Knight authored
Jenkins is currently configured to re-use workspaces between builds of the same branch. Run `make clean` at the start of the build to ensure that any artefacts from the previous build of the branch are removed.
-
Robert Knight authored
With the following steps, the second invocation of `make` should trigger installation of npm dependencies: 1. Run `make` 2. Edit dependencies in `package.json` 3. Run `make` again
-
Robert Knight authored
The shrinkwrap was not updated when `requests` was updated from v2.71.0 to v2.72.0.
-
Lena Gunn authored
-
- 28 Oct, 2016 2 commits
-
-
Sean Roberts authored
Fix normalization of ranges that start at an element node with no children
-
Robert Knight authored
This isn't needed since we're not translating error messages.
-
- 25 Oct, 2016 5 commits
-
-
Robert Knight authored
Rename the `$$tag` annotation property to `$tag`.
-
Robert Knight authored
The range normalization code failed to take account of ranges where the start container was an empty element with no children. Fixes #73
-
Robert Knight authored
Replace the Range functions from the compiled version of Annotator 1.2.x with the latest CoffeeScript source from the v1.2.x branch of Annotator, plus the fix added in b3056d27 This includes fixes for BrowserRange#normalize from https://github.com/openannotation/annotator/commit/9bec776511a717ef944b36ed7cca3d107bd95c88 In addition, this removes the dependency on the Annotator framework from annotator/anchoring and the highlighter, getting us closer to a point where we can remove the dependency of the annotation layer on Annotator. Fixes #109
-
Sean Roberts authored
Adding code coverage reporting to Karma tests
-
Sean Roberts authored
-
- 24 Oct, 2016 4 commits
-
-
Sheetal Umesh Kumar authored
This property previously had a "$$" prefix instead of the conventional single "$" prefix for local-only properties of annotations for historical reasons. This is a followup PR to: https://github.com/hypothesis/client/pull/126
-
Robert Knight authored
-
Robert Knight authored
* Rename the annotation property storing the local tag to `$tag` This property previously had a "$$" prefix instead of the conventional single "$" prefix for local-only properties of annotations for historical reasons. * Remove explicit copying of the `$tag` property in Object.assign() calls The `$tag` property is now enumerable.
-
Robert Knight authored
-
- 21 Oct, 2016 5 commits
-
-
Sean Roberts authored
Update proxyquire
-
Sean Roberts authored
Fallback to last text node when we will fall into a null sibling node situation
-
Sean Roberts authored
-
Sean Roberts authored
Add PDF anchoring unit tests
-
Robert Knight authored
Add a set of tests using a fake implementation of PDF.js' PDFViewerApplication interface. The initial set of tests simulate a nice born-digital PDF in which the text layer of the PDF contains one <div> per line. In future we can easily extend this to emulate the kind of structure that would be seen when working with eg. an OCR-ed PDF
-
- 20 Oct, 2016 2 commits
-
-
Robert Knight authored
Update this dependency in preparation for updating the dom-anchor-text-{quote, position} libraries. The previous version indirectly used an old version of combine-source-map that is not compatible with the inline source maps in the newest versions of the dom-anchor-* libraries.
-
Sean Roberts authored
Remove the "-app" suffix from Gulp tasks
-
- 19 Oct, 2016 4 commits
-
-
Sean Roberts authored
Remove AnnotationUIController
-
Robert Knight authored
This is a holdover from when the Hypothesis service front-end and client application lived in the same repository and the "-app" suffix was used to indicate client-specific tasks. Removing this gives the tasks more obvious names - "build", "build-js", "test" etc.
-
Robert Knight authored
All of the functionality in this module is either unused or duplicated elsewhere: * The $scope.{selectedAnnotations, focusedAnnotations, selectedAnnotationsCount} properties were unused. Note that there is a very similarly named `selectedAnnotationCount` scope property defined in `WidgetController` which _is_ used * The ANNOTATION_DELETED event handler duplicated another one in root-thread.js
-
Robert Knight authored
This function expects an ID, not an Annotation
-
- 17 Oct, 2016 3 commits
-
-
Sean Roberts authored
Add a set of HTML anchoring tests with expected failures
-
Sean Roberts authored
Fix formatting changes made via toolbar buttons not persisting
-
Sean Hammond authored
Add application state debugging utility
-
- 14 Oct, 2016 2 commits
-
-
Robert Knight authored
Add a set of tests which check that Ranges within a DOM tree are correctly 'described' as selectors and then successfully converted back to Range objects by anchoring. The tests are derived from the suite of test cases collected for the Annotator project at https://github.com/openannotation/annotator/blob/v1.2.x/test/spec/range_spec.coffee These tests found failures in describing ranges with position and quote selectors in many cases and with a range selector in one case. The test lists and checks these expected failures.
-
Robert Knight authored
When making formatting changes to the text of an annotation with the toolbar button without subsequently making a manual edit before clicking Preview or Save, the onEditText() callback was never triggered and so the unsaved changes were reverted when exiting edit mode. This happened because onEditText() was only fired in response to the 'input' event which only occurs in response to programmatic, not manual changes to the input's value. Fixes #147
-
- 13 Oct, 2016 1 commit
-
-
Robert Knight authored
This adds a debug utility which prints the application state before and after each action to the console when `window.debug` is set to a truthy value.
-