1. 02 Aug, 2016 1 commit
    • Nick Stenning's avatar
      Update npm-shrinkwrap.json · 2ea88e19
      Nick Stenning authored
      I'm not really sure I understand the mechanism by which this is out of
      date or even what the changes here imply, but this is the result of
      running
      
          npm shrinkwrap --dev
      
      with latest npm (3.10.5), and the output appears to be stable --
      multiple runs do not change it further.
      
      In addition, installing new packages and rerunning `npm shrinkwrap
      --dev` appears to generate a minimal diff after this one-off update.
      2ea88e19
  2. 01 Aug, 2016 3 commits
  3. 29 Jul, 2016 1 commit
    • Robert Knight's avatar
      Make the adder a self-contained component (#48) · dbd16d1d
      Robert Knight authored
      * Make the adder a self-contained component
      
      Move adder event handling and UI creation to Adder component, so that
      Guest does not need to know about its internal structure or handle
      events for it. Instead it just supplies callbacks to invoke when the
      Annotate and Highlight buttons are clicked.
      
      This makes it easier to test event handling for the adder and to make
      future changes to the UI of the Adder.
      
      This commit removes a piece of logic that stopped propagation of
      'mouseup' events from the adder because I couldn't find a clear
      explanation in the code or commit history of why that was done.
      
      * Remove a couple of misplaced assertions from tests
      
      Remove assertions checking the horizontal position of the adder in tests
      which are only concerned with the vertical position of the adder
      relative to the selection.
      dbd16d1d
  4. 27 Jul, 2016 5 commits
  5. 26 Jul, 2016 1 commit
  6. 25 Jul, 2016 1 commit
    • Nick Stenning's avatar
      Ensure that frame-rpc event listeners are correctly torn down · 6ca273c1
      Nick Stenning authored
      When the client is destroyed, it's important that we correctly tear down
      the frame-rpc event listeners (bound to the document's `onmessage`
      event).
      
      These event listeners are responsible for relaying messages from the
      frame-rpc mechanism to various parts of the code on either side of the
      frame boundary, including the `AnnotationSync` component. If the
      frame-rpc channels aren't correctly torn down, they will hold a
      reference to the `Bridge` object, which in turn holds a reference to the
      `AnnotationSync` object, and thus old copies of `AnnotationSync` which
      should have been garbage-collected will continue to receive events from
      the brand new Hypothesis client.
      
      The most visible result of this problem was that repeated activation and
      deactivation of the client would result in increasing numbers of
      highlights being drawn on annotated text, as reported in
      hypothesis/h#3096.
      
      Fixes hypothesis/h#3096.
      6ca273c1
  7. 22 Jul, 2016 3 commits
    • Robert Knight's avatar
      0.35.0 · 429009ca
      Robert Knight authored
      429009ca
    • Robert Knight's avatar
      Update CHANGELOG.md · a18345d9
      Robert Knight authored
      a18345d9
    • Robert Knight's avatar
      Remove PhantomJS-specific polyfills (#45) · 6656a63f
      Robert Knight authored
      PhantomJS supports ES5 fully and does not require specific polyfills for
      it. This means that we can use exactly the same polyfill script in both
      our unit tests and the actual app, which reduces the chances of breakage
      due to mismatches.
      
      Additionally, the broken URL constructor could potentially affect other
      browsers, so it makes sense to include it in the main polyfill script.
      6656a63f
  8. 21 Jul, 2016 6 commits
  9. 19 Jul, 2016 5 commits
  10. 15 Jul, 2016 14 commits