- 05 Dec, 2014 3 commits
-
-
Aron Carroll authored
Rather than the thread-reply and thread-load-more elements having one set of conditions on the parent and one on the child we now ensure that the entire element is always shown/hidden.
-
Aron Carroll authored
Rename Heatmap -> BucketBar.
-
Randall Leeds authored
Ref #1236
-
- 04 Dec, 2014 3 commits
-
-
Aron Carroll authored
Don't use target="_blank" for feedback email.
-
Nick Stenning authored
-
Randall Leeds authored
Consolidate code paths around deciding about PDF.js
-
- 03 Dec, 2014 13 commits
-
-
csillag authored
-
Randall Leeds authored
Rename rpc methods to be more consistent
-
csillag authored
Annotator's PDF.js plugin replaces the document plugin for PDF.js, so when we are using the PDF plugin, we don't want to load the document plugin. For this, we are removing it from the options, in presence of PDF. This commit changes how we test for PDF. Earlier, we were simply testing for the presence of the global PDF.js object, but it's better to actually use the test already implemented inside the PDF plugin. This has two benefits: * If the PDF plugin is not present, we won't mistakenly remove the document plugin. * If the PDF plugin decides that it can't deploy, for whatever reason, we won't mistakenly remove the document plugin.
-
Gergely Ujvari authored
Between guests <-> sidebar - `showViewer()` to `showAnnotations()` - `updateViewer()` to `updateAnnotations()` - `toggleViewerSelection()` to `toggleAnnotationSelection()` All these renames were to enforce encapsulation and these calls are more like APIs. To guest side really do not have to know anything what the sidebar has or does.
-
gergely-ujvari authored
Renamed a few methods to be more consistent
-
csillag authored
(As previously discussed with @tilgovi) Sidebar -> Document RPC methods: * Renamed `scrollTo()` to `scrollToAnnotation()` (to be consistent with `focusAnnotations()` Guest methods: * Renamed `showViewer()` to `showAnnotations()` (to be consistend with `focusAnnotations()`) * Renamed `updateViewer()` to `updateAnnotations()` (same reason) * Renamed `toggleVIewerSelection()` to `toggleAnnotationSelection()` (same reason)
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
This reverts commit eb3c486991d921a1f2342a289cb9755d9d76459e. I don't think this fixed anything because the permissions plugin should still have been setting the permissions to empty.
-
Randall Leeds authored
-
Randall Leeds authored
It is fine if the permissions are initially undefined. Fix #1747
-
Randall Leeds authored
-
- 02 Dec, 2014 14 commits
-
-
Randall Leeds authored
Create reindex.py, add warning on mapping conflict
-
Randall Leeds authored
Update License and Notice files
-
Randall Leeds authored
Highlight state considation
-
Randall Leeds authored
Re-implement hiliting annotation cards on hover
-
gergely-ujvari authored
Remove strings from the privacy template
-
Aron Carroll authored
Instead we use a method on the scope to determine the current permission level.
-
Randall Leeds authored
Focus share link when pop-up opens
-
Randall Leeds authored
Sticky privacy on the browser
-
Randall Leeds authored
Use an object for privacy level models
-
Randall Leeds authored
-
Aron Carroll authored
-
Randall Leeds authored
Rename some things to be consistent about how we treat highlight states. - Use blue highlights for focus no matter whether active highlights are on or off. - Use `setFocused` instead of `setActive` when setting the focus. - Rather than `setViewerFocus` and `setFocusedHighlights` have symmetrical RPC calls named 'focusAnnotations` in both directions. - Get rid of the multiple highlight levels for focus. When showing the focus it's not important to darken inner highlights. The highlights visible mode still has multiple levels, all yellow. - Remove the "annotator-hl-temporary" styles since we never call `setTemporary` anymore. - Remove the "finalizeHighlights" event because nothing listens for it. - Rename the scope method `isFocused` to `hasFocus` because I have a general preference against participial adjectives. It is much easier to remember always to use the basic verb or noun meaning of focus, with no ending. `hasFocus`, `focusAnnotations`, etc. Removing dead code from our annotator branch and dropping the '-ed' suffix from class names is left out for simplicity of managing a single PR against one repo for the moment, but may be advisable.
-
Randall Leeds authored
Provide a feedback button in the interface
-
Randall Leeds authored
This makes the association between the level key name and the display text explicit and tight in the code.
-
- 01 Dec, 2014 2 commits
-
-
RawKStar77 authored
Meant to resolve #1653. As per @dwhly's suggestion the dropdown menu is now accessible even when not logged in. Note: items relevant to only logged in users are not shown.
-
Gergely Ujvari authored
-
- 28 Nov, 2014 5 commits
-
-
Randall Leeds authored
-
csillag authored
So that - Instead of a map, we now store a list of focused tags - The check for being focused has been moved into a method in the controller - The sidebar now exepts simply a list of tags to focus on (no more add/remove tags to existing list)
-
csillag authored
Don't bother looking up the annotations (for the tags), since we only need the list of tags anyway. (It was different when we worked with the IDs, but we moved to use tags instead, so the actual annotations are no longer needed.)
-
Nick Stenning authored
Restructure Chrome Extension
-
csillag authored
... because new and deleted annotations don't have IDs, only tags, assigned by the bridge.
-