- 23 Sep, 2015 7 commits
-
-
Nick Stenning authored
In preparation for making some substantial changes to this piece of code, I'm translating it to JS.
-
Nick Stenning authored
-
Robert Knight authored
Consolidate .gitignore files
-
Nick Stenning authored
Auto re-install Python, Node deps if out of date
-
Nick Stenning authored
Having these scattered about across the repository makes it hard to work out where something is ignored, and most tools/editors that read .gitignore files don't pay attention to those not in the repository root.
-
Nick Stenning authored
T87 - Improve group scope dropdown ui
-
Robert Knight authored
For IE 10 and Safari < 9 support, use prefixed flexbox. For now, this duplicates the flexbox declarations as is done in topbar.scss. I will look into using autoprefixer for this separately. Card 87
-
- 22 Sep, 2015 14 commits
-
-
Nick Stenning authored
cf410d0 broke standalone annotation pages by changing `threadRoot.children` from an array into a thread container. Unsurprisingly, `children` is supposed to be an array.
-
Robert Knight authored
* Use the singular 'groupList' everywhere * Simplify the logic for stopping click propagation when toggling the selected group * Remove underscore prefix for Controller classes as per the PR discussion. Card 87
-
Robert Knight authored
Card 87
-
Sean Hammond authored
Fix detection of PDF URIs
-
Robert Knight authored
Card 87
-
Nick Stenning authored
*N.B.* This does not fix the underlying problem, but it does make it possible to deploy the existing codebase without breaking everything in production.
-
Nick Stenning authored
70c9b9b broke a number of features of the h client that were toggled on for PDF documents, by renaming the Annotator PDF plugin from `Annotator.Plugin.PDF` to `Annotator.Plugin.Pdf`. While it's certainly an ugly side-effect of a straightforward rename, the problem is that `Guest#getDocumentInfo` (to pick one example) used `@plugins.PDF?` to determine whether to use the PDF metadata (provided by the PDF.js `PDFViewerApplication`). In the absence of PDF metadata, `getDocumentInfo` falls back to using `window.location.href`, which explains the behaviour identified in #2506. Fixes #2506.
-
Robert Knight authored
Add a test for the controller part of the <groups-list> directive. We have a couple of different patterns for testing directive controllers in the code, the approach taken here follows the privacy dropdown's directive in simply exporting the controller's constructor as a 'private' export and referencing it directly in the test. * Rename the exports in the 'directive/privacy' module for consistency
-
Robert Knight authored
* Restructure the 'New group' item to make icon and label align with the items above it * Make the whole 'New group' section clickable * Make 'New group' icon bold for visual consistency with other icons * Use the prerendered group URL from the API instead of generating it locally Card 87
-
Robert Knight authored
* Use an element directive for <group-list> for consistency with the <privacy> directive and because the directive has its own template. * Use flexbox for easier layout of items in the groups dropdown list. * Update the hover and selection states of items in the dropdown list as per the mocks. * Add descriptive titles to all links in the list Card 87
-
Robert Knight authored
* Use the brand color for hovered items, including selected items. Card 87
-
Robert Knight authored
Use nesting for readability. Card 87
-
Robert Knight authored
Use a light grey background. Card 87
-
Nick Stenning authored
Add make target to run karma tests with auto-watch enabled
-
- 21 Sep, 2015 6 commits
-
-
Sean Hammond authored
Show orphan annotations with a notice
-
Randall Leeds authored
The positions of the anchors are no longer needed.
-
Robert Knight authored
This provides a convenient way to start Karma tests and auto-run them when test files are changed. Because the test files are incorporated into a Browserify bundle by karma-browserify which watches files for changes via watchify(), we can turn off Karma's own watching of the test files. This fixes a problem where changing a test spec file would result in Karma running all the tests twice, once after the test spec file changed and then again afterwards due to the browserify bundle being updated a second or two after the test spec file changes.
-
Nick Stenning authored
DRY in .editorconfig and add SCSS settings
-
Nick Stenning authored
cf410d0 broke thread sorting by interfering with the (admittedly arcane) sort apparatus. There is a scope.watch in the AppController which is responsible for filling the `predicate` field of the `sort` object when the `name` field changes. In order for this to work, the controllers in child scopes (namely StreamController or WidgetController) need to modify the `name` property of the `sort` object in the parent scope, via prototypal inheritance, rather than replacing the entire `sort` object.
-
Nick Stenning authored
Clean up socket, threading, mapper with routing
-
- 18 Sep, 2015 1 commit
-
-
Randall Leeds authored
Move all the logic required to set up a clean environment for the client views into the dependency resolution mechanism of ngRoute. The annotation mapper gains an unloadAnnotations method to make the isolated code cleaner. Use angular-websocket to remove the need for our own socket class. The AppController becomes much more sane.
-
- 17 Sep, 2015 4 commits
-
-
Nick Stenning authored
Merge pull request #2475 from hypothesis/oWe60V8v-signal-when-there-are-public-annotations-on-a-page Signal when there are public annotations on a page in the Chrome extension icon
-
Sean Hammond authored
I was getting multiple test fails on Travis that were not failing locally, due to differences between my local Sinon and Travis's. Pinning Sinon to the latest version fixes this.
-
Sean Hammond authored
Add a simple user info dashboard for admins
-
Randall Leeds authored
-
- 16 Sep, 2015 1 commit
-
-
Nick Stenning authored
Allows administrators to look up user information from the administration panel.
-
- 15 Sep, 2015 7 commits
-
-
Randall Leeds authored
Close #1916
-
Randall Leeds authored
Installation docs corrections
-
Randall Leeds authored
Split host / sidebar and clean up plugin loading
-
Randall Leeds authored
-
Randall Leeds authored
Improve factoring of search/filtering
-
Randall Leeds authored
Refactor Pyramid routing and view configuration
-
Nick Stenning authored
Lenient search
-