- 15 Sep, 2015 2 commits
-
-
Nick Stenning authored
Lenient search
-
Randall Leeds authored
More variable substitution becomes available.
-
- 12 Sep, 2015 3 commits
-
-
Randall Leeds authored
Keep weaning off jQuery.
-
Randall Leeds authored
-
Randall Leeds authored
Fix issues with Object.getOwnPropertyNames under PhantomJS.
-
- 11 Sep, 2015 4 commits
-
-
Randall Leeds authored
Let each frame just emit the event locally and invoke its own local method in response to the RPC call. The widget, acting as the hub of the communication bridge, stops infinite RPC loop by only propagating the call when it would change the state.
-
Randall Leeds authored
Publish to a group
-
Sean Hammond authored
-
Sean Hammond authored
Features ======== 1. If you have a group selected in the groups dropdown when you create an annotation, the annotation will be created in that group. 2. Only users who are members of the group can see the group's annotations. 3. An annotation can be separately set to public or private, whether it is in a group or not, using the separate visibility dropdown on the annotation card when creating or editing an annotation. Private means viewable by the user only, public means viewable by the group or by everyone if the annotation has no group. When in a group the group's name appears instead of "Public" in the user interface (and with a group icon instead of the public icon). So for example if I make an annotation in group Foobar I can set its visibility to Only Me or to Foobar. 4. New icons and styles for all the group-related parts of the UI, should look the same as in Jake's mockups now. Implementation Notes ==================== Auth ---- - We add `"group:<hashid>"` principals to `request.effective_principals` for each group the user is a member of. - The existing `"group:admin"` and `"group:staff"` principals are renamed to `"group:__admin__"` and `"group:__staff__"` so that they never clash with group hashids (hashids never contain _'s). - A user may only create an annotation in group "x" if they are themselves a member of group "x". This is enforced by an ACL in `h.api.resources`. - Users may only view annotations in groups of which they are members. This is enforced by a query filter in search: `h.api.groups.search`. - In `h.api.groups.logic`: A reply's group is always set to that of its parent, server-side. It doesn't matter what the client sends. Search Filtering ---------------- - Whether an annotation belongs to a group is recorded in a top-level `group` field in the annotation. The value of this field is the group's hashid. For example, it is currently possible to have a private annotation (visible only to the user who created it) within a group. This allows users to use the privacy controls for "drafting" group annotations and replies, only sharing them with the group when they're ready. It also allows users to keep private replies to group annotations. When the sidebar is focused on a group (not yet implemented), the search will filter the annotations to those that have the group's hashid in the group field, regardless of whether the annotation's permissions are private to the user or shared with the group. - The groups search filtering (`h.api.groups.search`) uses the top-level groups field to filter out annotations that belong to groups that the user isn't a member of. - Annotations that are public simply have a group field containing `__world__`. Client-Side ----------- - `annotation.coffee` sets the group field on the annotation before saving it. - There's a new group-list-controller to handle the now more interactive groups dropdown. - And a group-service to share state about which group is currently focused with different parts of the code. Misc ---- - `h.streamer`: Infinite scroll and live updates filter out annotations from groups the user isn't a member of, as well. - `h.api.search.transform`: the API adds group: '__world__' to any annotations without a group field before returning them to the client.
-
- 10 Sep, 2015 2 commits
-
-
Randall Leeds authored
-
Randall Leeds authored
-
- 29 Aug, 2015 1 commit
-
-
Randall Leeds authored
Add clickToClose option
-
- 28 Aug, 2015 3 commits
-
-
Randall Leeds authored
Don't show CC0 license on Only Me annotations
-
Sean Hammond authored
-
Jake Hartnell authored
-
- 25 Aug, 2015 10 commits
-
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
The js-polyfills library is a nice one. It provides enough for PhantomJS and it provides the URL polyfill. However, we keep core-js since for production it's better to have the lightweight requirement of just the es6.promise module without global namespace pollution. We tolerate pollution of the global namespace for browsers with a broken or absent URL constructor implementation.
-
Randall Leeds authored
Annotating under IE10 works now!
-
Randall Leeds authored
With this change, there is no longer any patching of the global object from node-iterator-shim. I believe that's the end of all the global patching in all of our code. Only Annotator and jQuery remain in the global space, but both are removed with noConflict. Nice and clean.
-
Randall Leeds authored
-
Randall Leeds authored
The scroll-into-view module already depends on raf, it's tiny, and this lets us drop the bundled vendor lib. It also makes the guest and host tests more consistent.
-
Randall Leeds authored
-
Randall Leeds authored
This lets us require Promise without polluting the global namespace. Additionally, the core-js implementation has immediacy hacks that will make it more performant for IE. This also caught some issues with our async tests. And hey, it's about 700 bytes smaller, too!
-
Randall Leeds authored
-
- 24 Aug, 2015 1 commit
-
-
Randall Leeds authored
This fixes the dialogs to have the same space around them as the main content. It's a bit like re-introducing the #wrapper, but with a class this time that's re-used by the topbar for sizing its content.
-
- 20 Aug, 2015 2 commits
-
-
Randall Leeds authored
This is a little bit confusing, but it is better this way. It's confusing because webassets doesn't set the compass image directory, so the paths still have an "images/" prefix. However, the cssrewrite filter uses the output URL from webassets and that will be an absolute URL at request time. The compass filter uses only the base URL from the environment configuration, which is relative. Letting compass do the rewriting therefore results in merged compass files having correct, but relative, paths regardless of whether the assets are generated at the command line or at request time. This should make it possible to pre- compile the assets before the first request without generating bad URLs, and to virtual host the application under multiple URLs.
-
Randall Leeds authored
In order to upgrade clean-css it is necessary to import the filter definition from the future version of webassets. This version takes extra arguments in the filter configuration, allowing us to disable the advanced optimizations that became the default in 3.0+ but that breaks some of our styles.
-
- 19 Aug, 2015 12 commits
-
-
Randall Leeds authored
-
conordelahunty authored
Fix #2452
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
-
Randall Leeds authored
This lets the top bar set a font size for its inner content while still matching the padding to the rest of the page.
-
Randall Leeds authored
-
Randall Leeds authored
This is much neater. Since the scale origin is the center of the icon this will scale around the center of the line, avoiding any messy vertical alignment nonsense. This works much better than vertical-align middle and font-size because vertical-align middle puts the center of the element at the x-height, rather than the middle of the line. This is much cleaner.
-