- 27 Jun, 2017 12 commits
-
-
Sean Roberts authored
-
Sean Roberts authored
Multiple frame detection improvements
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Improve tests for different localStorage-not-accessible situations
-
Robert Knight authored
Run all of the existing tests to check behavior when localStorage is not accessible, for the case where accessing `window.localStorage` throws. The previous tests for this situation only tested the behavior of the service constructor.
-
Robert Knight authored
Use fallback when local storage throws
-
Sean Roberts authored
Whitelist config settings needed by multi-frame support
-
Juan Corona authored
Better differentiation from .isLoaded
-
Juan Corona authored
The tests are in a response to an issue found when frames get added/removed in quick succession. It was due to the timing of the debounce used in FrameObserver. This also works to test against possible edge cases and ensures robustness of the feature by going full circle.
-
Juan Corona authored
Reduces the footprint of CrossFrame by shifting away responsibility into this new module.
-
Juan Corona authored
To my knowledge this is temporarily until a better flagging or set of options comes by
-
- 26 Jun, 2017 7 commits
-
-
Sean Roberts authored
Use CrossFrame to show/hide the Sidebar
-
Sean Roberts authored
-
Sean Hammond authored
Enable feature flagged highlighter interface
-
Sean Roberts authored
-
Robert Knight authored
-
Robert Knight authored
-
Sean Hammond authored
Fix sidebar app failing to load in Firefox extension.
-
- 25 Jun, 2017 1 commit
-
-
Randall Leeds authored
In some environments, accessing the "localStorage" property of the window is enough to throw an error.
-
- 24 Jun, 2017 3 commits
-
-
Robert Hodan authored
-
Juan Corona authored
`Sidebar` no longer handles the click/touchstart on the document itself, therefore the test for this was replaced with a test in `Guest`, a test for if it’s sending “hideSidebar” event via `CrossFrame` when the document is clicked
-
Robert Hodan authored
-
- 23 Jun, 2017 5 commits
-
-
Sean Roberts authored
-
Sean Hammond authored
Convert "flash" service to JS
-
Sean Hammond authored
Enable feature flagging in the annotation layer
-
Sean Roberts authored
-
Robert Knight authored
Angular has a check for Chrome Packaged Apps in its `$sniffer` service which changes the behavior of the $location service and in the Firefox extension, triggers a redirect from `/client/app.html` to `/#client/app.html` on startup, breaking the sidebar app. This commit works around the problem by adding a fake `window.chrome.app` object to convince Angular that the Firefox extension is not a Chrome Packaged App. Issue reported upstream at https://github.com/angular/angular.js/issues/16068
-
- 21 Jun, 2017 1 commit
-
-
Robert Knight authored
Remove `angular.bind` dependency since `Function.prototype.bind` is now ubiquitous.
-
- 20 Jun, 2017 4 commits
-
-
Robert Knight authored
Upgrade Sinon.JS to its latest version
-
Sean Hammond authored
-
Sean Hammond authored
Rename config.app to sidebarAppUrl
-
Sean Hammond authored
The code in `src/boot/` reads the `sidebarAppUrl` setting from `js-hypothesis-config` JSON objects in the host page (defaulting to the value of the build-time `__SIDEBAR_APP_URL__` template variable, if there's no `sidebarAppUrl` setting in the host page). `boot/` then writes `sidebarAppUrl` as the value of the `href` of a `<link type="application/annotator+html">` element that it injects into the host page. Later, the code in `src/annotator/` reads this `<link>` element's `href` in as the `config.app` setting, which it uses as the `src` of the sidebar app's `<iframe>` that it injects into the host page. So the variable that's named `sidebarAppUrl` / `__SIDEBAR_APP_URL__` at boot / build time* gets renamed to `config.app` when it makes it into the `src/annotator` code. Fix this by renaming `config.app` in `src/annotator` to `config.sidebarAppUrl` so that the variable is named consistently. `*` In the build-time code there's also a `defaultSidebarAppUrl` variable, and an `H_SERVICE_URL` environment variable, which also belong to the same sidebarAppUrl config setting.
-
- 19 Jun, 2017 7 commits
-
-
Sean Roberts authored
-
Sean Roberts authored
-
Robert Knight authored
Add showHighlights() settings function
-
Sean Hammond authored
-
Sean Hammond authored
Return null, rather than undefined, if a host page setting isn't defined in the host page. This is because null, rather than undefined, is commonly used in this codebase to explicitly denote "not found".
-
Sean Hammond authored
strictEqual() can tell the difference between null and undefined, whereas equal() can't.
-
Robert Knight authored
Rename H_SERVICE_URL to SIDEBAR_APP_URL
-