- 02 Feb, 2022 2 commits
-
-
Robert Knight authored
-
Robert Knight authored
Change how the guest notifies other frames, specifically the sidebar and host, when it is unloaded. The host and sidebar now receive a `frameDestroyed` message from the corresponding guest port, which allows them to easily close the right port and remove it from the list of active guest ports. Due to a Safari bug (see code comments) we can't send the `frameDestroyed` messages from the guest frame while it is being unloaded. However it is possible to first transfer the port to the host frame and then have the host frame send the message on the same port. I also tried sending the message from the guest frame, and then transferring the port to the host frame but that didn't work. This workaround has the advantage that it is transparent to the receiver of the `frameDestroyed` message. This change is also a step towards possibly not relying on user-provided guest frame identifiers in the sidebar, which only become available once the `documentInfoChanged` call has been received. Instead the sidebar could use its own internal IDs for guest frames, avoiding the possibility for conflicts. Changes in detail: - Add `disconnect` method to PortRPC - When guest is unloaded, transfer ports to the host frame in a `hypothesisGuestUnloaded` message, and make the host frame dispatch `frameDestroyed` calls on these ports. - Handle `frameDestroyed` in sidebar by closing port, removing it from the active guest list and removing the associated frame from the store - Handle `frameDestroyed` in host frame by closing port and removing it from the active guest list
-
- 01 Feb, 2022 15 commits
-
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Eduardo Sanz García authored
Unless the actual name is really verbose or conflicts with another variable, we prefer to avoid import aliases.
-
Eduardo Sanz García authored
-
Eduardo Sanz García authored
Made some very minor changes to avoid import aliases.
-
Eduardo Sanz García authored
-
Eduardo Sanz García authored
This is the convention that I followed to export objects in the `src/sidebar/store/modules`: name of the file plus the word `Module`. For example, `direct-linked.js` exports `directLinkedModule`.
-
Eduardo Sanz García authored
-
Eduardo Sanz García authored
-
Eduardo Sanz García authored
-
Eduardo Sanz García authored
-
Eduardo Sanz García authored
-
Eduardo Sanz García authored
-
Eduardo Sanz García authored
The unused type referred to a class that has been deleted.
-
- 31 Jan, 2022 19 commits
-
-
Eduardo Sanz García authored
-
Eduardo Sanz García authored
-
Eduardo authored
Co-authored-by: Robert Knight <robertknight@gmail.com>
-
Eduardo Sanz García authored
The functionality to compute the buckets has been split in two steps: 1. Guest frame computes and sends a list of the anchors's top/bottom positions with the `anchorsChanged` RPC event. 2. In the host frame, `BucketBar` uses the list anchor's positions to compute the buckets. There is one issue with the current approach: if an iframe doesn't cover the entire host frame's viewport buckets can appear offset.
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1062.0 to 2.1066.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.1062.0...v2.1066.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@sentry/cli](https://github.com/getsentry/sentry-cli) from 1.72.0 to 1.72.1. - [Release notes](https://github.com/getsentry/sentry-cli/releases) - [Changelog](https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-cli/compare/1.72.0...1.72.1) --- updated-dependencies: - dependency-name: "@sentry/cli" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [sinon](https://github.com/sinonjs/sinon) from 12.0.1 to 13.0.0. - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/master/docs/changelog.md) - [Commits](https://github.com/sinonjs/sinon/compare/v12.0.1...v13.0.0) --- updated-dependencies: - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [rollup](https://github.com/rollup/rollup) from 2.66.0 to 2.66.1. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/rollup/rollup/compare/v2.66.0...v2.66.1) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [karma](https://github.com/karma-runner/karma) from 6.3.11 to 6.3.12. - [Release notes](https://github.com/karma-runner/karma/releases) - [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md) - [Commits](https://github.com/karma-runner/karma/compare/v6.3.11...v6.3.12) --- updated-dependencies: - dependency-name: karma dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [commander](https://github.com/tj/commander.js) from 8.3.0 to 9.0.0. - [Release notes](https://github.com/tj/commander.js/releases) - [Changelog](https://github.com/tj/commander.js/blob/master/CHANGELOG.md) - [Commits](https://github.com/tj/commander.js/compare/v8.3.0...v9.0.0) --- updated-dependencies: - dependency-name: commander dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [preact](https://github.com/preactjs/preact) from 10.6.4 to 10.6.5. - [Release notes](https://github.com/preactjs/preact/releases) - [Commits](https://github.com/preactjs/preact/compare/10.6.4...10.6.5) --- updated-dependencies: - dependency-name: preact dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
Robert Knight authored
Rename the module to match the `src/shared/messaging` directory name. We've considered moving the integration test under `src/shared/messaging/test` but have punted on that for now.
-
Robert Knight authored
Make it easier for future developers to understand the inter-frame communication code by grouping it in a directory with a short README and an index module that defines the API for use by other parts of the client.
-
dependabot[bot] authored
Bumps [tailwindcss](https://github.com/tailwindlabs/tailwindcss) from 3.0.15 to 3.0.18. - [Release notes](https://github.com/tailwindlabs/tailwindcss/releases) - [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/master/CHANGELOG.md) - [Commits](https://github.com/tailwindlabs/tailwindcss/compare/v3.0.15...v3.0.18) --- updated-dependencies: - dependency-name: tailwindcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.17.0 to 6.17.3. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/6.17.0...6.17.3) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 13.1.1 to 13.1.3. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md) - [Commits](https://github.com/puppeteer/puppeteer/compare/v13.1.1...v13.1.3) --- updated-dependencies: - dependency-name: puppeteer dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [chai](https://github.com/chaijs/chai) from 4.3.4 to 4.3.6. - [Release notes](https://github.com/chaijs/chai/releases) - [Changelog](https://github.com/chaijs/chai/blob/4.x.x/History.md) - [Commits](https://github.com/chaijs/chai/compare/v4.3.4...v4.3.6) --- updated-dependencies: - dependency-name: chai dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [eslint](https://github.com/eslint/eslint) from 8.7.0 to 8.8.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.7.0...v8.8.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.3.4 to 2.3.5. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](https://github.com/cure53/DOMPurify/compare/2.3.4...2.3.5) --- updated-dependencies: - dependency-name: dompurify dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 28 Jan, 2022 1 commit
-
-
Lyza Danger Gardner authored
Replace use of local utility classes with tailwind utility classes that do the same thing. Structure the utilities layer for both sidebar and annotator.
-
- 27 Jan, 2022 1 commit
-
-
Lyza Danger Gardner authored
-
- 26 Jan, 2022 2 commits
-
-
Robert Knight authored
-
Robert Knight authored
Clarify what happens if we try to test whether a VitalSource frame contains "real content", before it has finished loading.
-