- 10 May, 2018 2 commits
-
-
Robert Knight authored
Initial automated CoffeeScript => JS conversion using: ``` decaffeinate <CoffeeScript file> eslint --fix <JS file> ```
-
Robert Knight authored
Fix document metadata tests in chrome
-
- 09 May, 2018 2 commits
-
-
Robert Knight authored
Update Yarn lockfile following addition of cross-env in previous commit.
-
Robert Knight authored
issue #659 make build platform independent by using cross-env
-
- 08 May, 2018 1 commit
-
-
Ronald Denaux authored
-
- 01 May, 2018 3 commits
-
-
Robert Knight authored
A `<link>` tag with a relative URL from a previous test was causing problems in Chrome when testing the behavior of `Document#uri` in documents with a non-HTTP/file `<base>`. That is an edge case which we may want to cover at some point, but the more significant issue is that the `Document#uri` tests were not isolated from the earlier ones. Modify the `createDoc` helper so that it uses a blank HTML document instead of using the global `document` object.
-
Robert Knight authored
The `Document` class for reading DOM document metadata takes an optional DOM `Document` constructor argument as a test seam. However the actual code only used the injected document in some places, in others it used jQuery which in turn reads from the global `window.document`. Refactor this code to use the injected DOM Document everywhere and remove the jQuery dependency.
-
Robert Knight authored
-
- 30 Apr, 2018 2 commits
-
-
Robert Knight authored
Upgrade dependencies to fix compatibility with Node v10
-
Robert Knight authored
Upgrade dependencies using `yarn upgrade`. This fixes dependency installation with Node v10.
-
- 25 Apr, 2018 2 commits
-
-
Sean Hammond authored
change links in help panel
-
katelyn authored
"send a suppport ticket" now leads to `https://web.hypothes.is/get-help` and "visit our help documents" leads to `https://web.hypothes.is/help`
-
- 20 Apr, 2018 6 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Fix group focus change checks
-
Robert Knight authored
The focused group change check had several issues: - The `prevFocused` variable was not updated after the focused group changed, so the `GROUP_FOCUSED` event was emitted every time the app state changed. - Groups were compared by reference rather than by ID, which means that a change which modified a property of the group but not its ID would cause the event to fire. The first issue made it impossible to create annotations because the unnecessary `GROUP_FOCUSED` event triggered a cascade of reactions which crashed the app.
-
Robert Knight authored
-
Robert Knight authored
-
- 19 Apr, 2018 5 commits
-
-
Robert Knight authored
Modernize PDFMetadata class
-
Robert Knight authored
-
Robert Knight authored
- Convert `PDFMetadata` to an ES2015 class - Convert the ad-hoc type documentation to tool-readable JSDoc - Add a little more detail in doc comments about what `documentFingerprint` is
-
Robert Knight authored
Move focused group and list of loaded groups to store
-
Robert Knight authored
As noted in CR feedback, having a selector named `focusedGroup` which returns a `Group` and a state property named `focusedGroup` is `string|null` is confusing. Also change a `g` variable to `group` for clarity.
-
- 18 Apr, 2018 1 commit
-
-
Lyza Gardner authored
Also bring `yarn.lock` into sync
-
- 17 Apr, 2018 5 commits
-
-
Sheetal Umesh Kumar authored
-
Sheetal Umesh Kumar authored
-
Sheetal Umesh Kumar authored
Remove outdated April fool joke.
-
Sheetal Umesh Kumar authored
-
Sheetal Umesh Kumar authored
Use group.links\.html instead of group\.url
-
- 16 Apr, 2018 3 commits
-
-
Sheetal Umesh Kumar authored
Remove used used scss block causing invalid css error after upgrading…
-
Sheetal Umesh Kumar authored
-
- 13 Apr, 2018 5 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Add organization logos to groups menu
-
Sean Hammond authored
Resolve relative URLs when getting PDF URL from PDF.js
-
Lyza Danger Gardner authored
-
- 12 Apr, 2018 3 commits
-
-
Lyza Gardner authored
-
Robert Knight authored
If PDF.js is launched with a `file` query-string parameter that is a relative URL, then `window.PDFViewerApplication.url` will be that relative URL. When capturing the metadata from the PDF in order to search for annotations or find relevant groups, we want to use an absolute URL. This commit uses the existing `normalizeURI` helper to resolve the possibly-relative URL. Fixes https://github.com/hypothesis/product-backlog/issues/579
-
Robert Knight authored
Extract the existing `normalizeURI` function from guest.coffee into a utility module and re-use it in document.coffee to convert relative URLs to absolute ones. Also implement some direct tests for this function.
-