- 11 Aug, 2016 1 commit
-
-
Robert Knight authored
In browsers that support Shadow DOM (currently only Chrome, plus Firefox behind a feature flag), use it to isolate the adder from the host page's CSS. This fixes various problems where very generic CSS on the page could affect the adder's styling.
-
- 09 Aug, 2016 4 commits
-
-
Sheetal Umesh Kumar authored
-
Sheetal Umesh Kumar authored
-
Robert Knight authored
- Only mark annotations as orphans after a timeout in the sidebar, not in the stream where anchoring does not happen. - Do not filter annotations by type on the stream, where annotation tabs are not displayed.
-
Robert Knight authored
When the orphans feature flag is not set, do not indicate orphans in annotation cards by striking through their quotes. The feature flag is hoisted outside of the `isOrphan` call because I recall that `flagEnabled` was actually quite an expensive call in the past so we want to avoid invoking it during every digest cycle.
-
- 08 Aug, 2016 5 commits
-
-
Sheetal Umesh Kumar authored
-
Sheetal Umesh Kumar authored
-
Robert Knight authored
If an annotation is loaded and then quickly removed before the anchoring timeout expires, the call to `findByID()` will return null, causing an error when trying to check the `$orphan` flag in `isWaitingToAnchor`. Fix this by ignoring annotations which no longer exist when the timeout expires.
-
Sheetal Umesh Kumar authored
-
Sheetal Umesh Kumar authored
-
- 05 Aug, 2016 6 commits
-
-
Robert Knight authored
If anchoring an annotation fails to complete within 500ms then assume that an error occurred during anchoring and that the annotation is therefore an orphan. If it later turns out that anchoring just took a long time then the annotation will simply move from the Orphans tab to the Annotations tab once anchoring completes. A timeout within the sidebar app is used rather than relying on the page code to send back a message if an error occurs during anchoring because the code that runs in the page context could fail in arbitrary ways due to interactions with JavaScript on the page.
-
Robert Knight authored
-
Robert Knight authored
Remove the 'selection_tabs' feature flag
-
Nick Stenning authored
This is now enabled for all users.
-
Robert Knight authored
Separate anchored and unanchored annotations into tabs.
-
Robert Knight authored
Avoid problems due to loss of type information when passing config options from the page to the sidebar app by serializing the app config object as a JSON string and then de-serializing it in app.js
-
- 04 Aug, 2016 7 commits
-
-
Robert Knight authored
When there are no orphans, the Orphans tab is not shown, so we need to switch back to the Annotations tab in that case.
-
Robert Knight authored
Refactor some repetition in the functions that produced the counts for the Annotations, Page Notes and Orphans tabs and extract it into a separate module where it is easier to test. Moving this into a single function also makes it easier to memoize later, so we can avoid recalculating it when the list of annotations has not changed between two app states.
-
Robert Knight authored
-
Sheetal Umesh Kumar authored
Default to the annotations tab when user switches between groups, clears a selection or reloads a page. The ANNOTATIONS_SYNCED event is emitted when annotations for a document have finished anchoring. Because annotations are not marked as orphans until they fail to anchor, select the annotations tab after they have finished anchoring. Test cases: ------------- 1. On page load localhost:3000 annotations tab is selected. clicking on new note switches to the notes tab with a new draft created. switching between tabs maintains tab selection, if notes or annotations. when tab selected is orphans, changing groups defaults to the annotations tab. 2. On page load localhost:3000/#annotations:<id> clicking on new page note should select the notes tab. When an annotation/note is selected, the tab selection carries between group changes. all tests listed in #1 above should apply. 3. On page load localhost:3000/#annotations:<orphan_id> clicking on “show all annotations and notes” selects the annotations tab and displays all annotations. all tests listed in #1 and #2 above should apply. switching between groups selects the annotations tab by default https://trello.com/c/1NVK2jwv/400-add-a-tab-for-unanchored-annotations https://trello.com/c/OLdLTlLT/342-separate-annotations-and-notes Hide orphans tab behind orphans_tab flag. Fix bug where notes tab isn't selected when user attempts to create a new page note.
-
Robert Knight authored
Update an annotation's anchoring status and local tag via a Redux action rather than just direct assignment to the annotation's properties. This ensures that store subscribers and a digest cycle happen after the anchoring status changes. This in turn ensures that the UI state is kept in sync. This also brings us another step closer to being able to make annotation objects immutable within the sidebar app.
-
Robert Knight authored
Add a service which maps named, parameterized routes to corresponding URLs on the Hypothesis service. This makes it easier to identify which URLs the client links to on the service and update all uses of a particular URL.
-
Sheetal Umesh Kumar authored
-
- 03 Aug, 2016 3 commits
-
-
Robert Knight authored
Replace "firstRun" config option with "openSidebar" and "openLoginForm"
-
Robert Knight authored
Update npm-shrinkwrap.json
-
Robert Knight authored
Embed release version in built package
-
- 02 Aug, 2016 4 commits
-
-
Robert Knight authored
Fix incorrect usages of the $rootScope
-
Nick Stenning authored
I'm not really sure I understand the mechanism by which this is out of date or even what the changes here imply, but this is the result of running npm shrinkwrap --dev with latest npm (3.10.5), and the output appears to be stable -- multiple runs do not change it further. In addition, installing new packages and rerunning `npm shrinkwrap --dev` appears to generate a minimal diff after this one-off update.
-
Nick Stenning authored
Rather than relying on the release version being passed in as config, build the current release version (as read from `package.json`) into the bundle. We use browserify-versionify for this, rather than simply requiring `package.json`, as our current build toolchain does not support any kind of tree-shaking, so `require('package.json')` would pull the whole of the `package.json` file into the bundle.
-
Alice Wyan authored
-
- 01 Aug, 2016 7 commits
-
-
Nick Stenning authored
-
Nick Stenning authored
This commit deprecates the confusingly-named "firstRun" embed script option with two which actually describe the relevant actions triggered. Unfortunately, at the moment this requires a fairly horrific check that the string value of a config option is not the literal 'false', due to the way that the Host code passes configuration from the page frame to the sidebar frame (using URL query string parameters).
-
Nick Stenning authored
Use shared ESLint config
-
Alice Wyan authored
-
Alice Wyan authored
As described on the trello card: https://trello.com/c/2NHJkRLa/407-audit-client-for-incorrect-rootscope-usage there are components or controllers subscribing to events directly on the root scope via `$rootScope.$on()`. This patch moves those hooks to the correct `$scope` and causes those events to be `$broadcast` instead of `$emit` to the root scope.
-
Robert Knight authored
Fix up indentation using `eslint . --fix`
-
Robert Knight authored
Use the shared `hypothesis` ESLint config for consistency with our other projects
-
- 29 Jul, 2016 1 commit
-
-
Robert Knight authored
* Make the adder a self-contained component Move adder event handling and UI creation to Adder component, so that Guest does not need to know about its internal structure or handle events for it. Instead it just supplies callbacks to invoke when the Annotate and Highlight buttons are clicked. This makes it easier to test event handling for the adder and to make future changes to the UI of the Adder. This commit removes a piece of logic that stopped propagation of 'mouseup' events from the adder because I couldn't find a clear explanation in the code or commit history of why that was done. * Remove a couple of misplaced assertions from tests Remove assertions checking the horizontal position of the adder in tests which are only concerned with the vertical position of the adder relative to the selection.
-
- 27 Jul, 2016 2 commits
-
-
Robert Knight authored
-
Robert Knight authored
-