1. 25 Oct, 2017 1 commit
    • Robert Knight's avatar
      Strip unknown query params when generating Internet Archive embed URLs · 4d05b426
      Robert Knight authored
      Internet Archive details pages may include params in the query string
      as well as "start" and "end" params in the path. In that case invalid
      URLs were being generated.
      
      Use a more robust approach to generating embed URLs and add some missing
      test cases. Any unrecognized query params are ignored when generating
      the embed URLs.
      4d05b426
  2. 23 Oct, 2017 4 commits
  3. 20 Oct, 2017 1 commit
  4. 09 Oct, 2017 2 commits
  5. 03 Oct, 2017 3 commits
  6. 29 Sep, 2017 1 commit
    • Sean Hammond's avatar
      Send search URIs to other frames by postMessage() · 9ea6b7d4
      Sean Hammond authored
      Add support for receiving postMessage() requests from other windows or
      frames and responding by sending the list of search URIs that the client
      is using for the current document to search the Hypothesis API for
      annotations.
      
      This can be used by our LTI app to get the search URIs when the student
      submits an assignment. The app needs the search URIs to later search the
      API for the student's annotations.
      9ea6b7d4
  7. 27 Sep, 2017 1 commit
  8. 22 Sep, 2017 8 commits
    • Robert Knight's avatar
      1.46.0 · 23163ab2
      Robert Knight authored
      23163ab2
    • Robert Knight's avatar
      Update Change Log · 36269c27
      Robert Knight authored
      36269c27
    • Robert Knight's avatar
      Merge pull request #552 from hypothesis/fetch-anns-on-user-change · 75ac6801
      Robert Knight authored
      Make re-fetching of annotations when the logged-in user ID changes work with OAuth
      75ac6801
    • Robert Knight's avatar
      Avoid fetching annotations twice if user ID and focused group change at the same time · 9970a294
      Robert Knight authored
      The sidebar had two separate watchers checking for a change in the
      current user ID and focused group, each of which independently called
      `loadAnnotations`. Therefore if both changed at the same time,
      annotations could be loaded twice. This happens when logging out if a
      private group was selected prior to doing so, since the group switches
      to "Public" at the same time as the userid becomes `null`.
      
      This commit fixes the issue by consolidating the check for a change in
      group ID and a change in user ID into a single watcher. If either or
      both change, `loadAnnotations` will only be called once.
      9970a294
    • Robert Knight's avatar
      Make re-fetching of annotations when the logged-in user ID changes work with OAuth · 6775fda1
      Robert Knight authored
      Refetching of annotations when the logged-in user ID changes was
      previously triggered by a complete reload of the `<sidebar-content>`
      component via a `$route.reload()` call. This happened in response to a
      `USER_CHANGED` event except for the first time that the profile was
      fetched.
      
      When using OAuth this broke because the test for whether this was the
      first profile fetch or not was based on a change from null => non null
      CSRF token (see `isInitialLoad` initialization). When using OAuth
      however, there is no CSRF token.
      
      This commit reworks refetching of annotations to remove the route
      reloading and instead trigger it in the same way that it is triggered
      when frames connect or disconnect, by calling
      `SidebarContentController#loadAnnotations` when the logged-in userid
      changes.
      6775fda1
    • Robert Knight's avatar
      1.45.0 · dfe7fe05
      Robert Knight authored
      dfe7fe05
    • Robert Knight's avatar
      Update Change Log · 3c8baccb
      Robert Knight authored
      3c8baccb
    • Robert Knight's avatar
      Merge pull request #551 from hypothesis/remove-iframe-size-check · ce69ce41
      Robert Knight authored
      Remove iframe size check
      ce69ce41
  9. 21 Sep, 2017 3 commits
    • Robert Knight's avatar
      Remove iframe size check · d8eedc34
      Robert Knight authored
      Since we now only enable annotation of iframes that are explicitly opted
      in by the containing page, we can avoid checking the size of the iframe
      as well. That check was originally added to filter out ads and hidden
      iframes.
      
      This resolves an issue with Epub.js where an iframe initially has zero
      width. This is because book content is laid out into a variable number
      of fixed-width columns and the iframe's width is set to the total width
      of all columns. Until the content is loaded, the number of columns and
      hence the width, is zero.
      d8eedc34
    • Sean Hammond's avatar
      Merge pull request #549 from hypothesis/remove-window-annotator-export · 0c73c43e
      Sean Hammond authored
      Stop exporting the main annotation layer object as `window.annotator`
      0c73c43e
    • Robert Knight's avatar
      Stop exporting the main annotation layer object as `window.annotator` · 0033f774
      Robert Knight authored
      The main application object in the code which runs in the host page was
      made visible to other code on the page as `window.annotator`.
      
      This export existed for legacy reasons (the client's Annotator.js
      heritage), is not part of the public API of the client and we do not
      make any effort to avoid breaking changes to it between releases.
      Removing this export should prevent third parties writing code which
      depends on its interface.
      0033f774
  10. 20 Sep, 2017 4 commits
  11. 18 Sep, 2017 5 commits
  12. 15 Sep, 2017 4 commits
  13. 14 Sep, 2017 3 commits