- 25 Oct, 2017 1 commit
-
-
Robert Knight authored
Internet Archive details pages may include params in the query string as well as "start" and "end" params in the path. In that case invalid URLs were being generated. Use a more robust approach to generating embed URLs and add some missing test cases. Any unrecognized query params are ignored when generating the embed URLs.
-
- 23 Oct, 2017 4 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Add comments to clarify several issues raised during PR #554. Also add a missing test case and a small cleanup for the function. The conversion of start time and end time path params into query string params is still not particularly robust but it is good enough for us to do some initial testing in production.
-
Robert Knight authored
embed internet archive videos
-
- 20 Oct, 2017 1 commit
-
-
judell authored
-
- 09 Oct, 2017 2 commits
- 03 Oct, 2017 3 commits
-
-
Sean Hammond authored
-
Sean Hammond authored
-
Sheetal Umesh Kumar authored
Send search URIs to other frames by postMessage()
-
- 29 Sep, 2017 1 commit
-
-
Sean Hammond authored
Add support for receiving postMessage() requests from other windows or frames and responding by sending the list of search URIs that the client is using for the current document to search the Hypothesis API for annotations. This can be used by our LTI app to get the search URIs when the student submits an assignment. The app needs the search URIs to later search the API for the student's annotations.
-
- 27 Sep, 2017 1 commit
-
-
judell authored
-
- 22 Sep, 2017 8 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Make re-fetching of annotations when the logged-in user ID changes work with OAuth
-
Robert Knight authored
The sidebar had two separate watchers checking for a change in the current user ID and focused group, each of which independently called `loadAnnotations`. Therefore if both changed at the same time, annotations could be loaded twice. This happens when logging out if a private group was selected prior to doing so, since the group switches to "Public" at the same time as the userid becomes `null`. This commit fixes the issue by consolidating the check for a change in group ID and a change in user ID into a single watcher. If either or both change, `loadAnnotations` will only be called once.
-
Robert Knight authored
Refetching of annotations when the logged-in user ID changes was previously triggered by a complete reload of the `<sidebar-content>` component via a `$route.reload()` call. This happened in response to a `USER_CHANGED` event except for the first time that the profile was fetched. When using OAuth this broke because the test for whether this was the first profile fetch or not was based on a change from null => non null CSRF token (see `isInitialLoad` initialization). When using OAuth however, there is no CSRF token. This commit reworks refetching of annotations to remove the route reloading and instead trigger it in the same way that it is triggered when frames connect or disconnect, by calling `SidebarContentController#loadAnnotations` when the logged-in userid changes.
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Remove iframe size check
-
- 21 Sep, 2017 3 commits
-
-
Robert Knight authored
Since we now only enable annotation of iframes that are explicitly opted in by the containing page, we can avoid checking the size of the iframe as well. That check was originally added to filter out ads and hidden iframes. This resolves an issue with Epub.js where an iframe initially has zero width. This is because book content is laid out into a variable number of fixed-width columns and the iframe's width is set to the total width of all columns. Until the content is loaded, the number of columns and hence the width, is zero.
-
Sean Hammond authored
Stop exporting the main annotation layer object as `window.annotator`
-
Robert Knight authored
The main application object in the code which runs in the host page was made visible to other code on the page as `window.annotator`. This export existed for legacy reasons (the client's Annotator.js heritage), is not part of the public API of the client and we do not make any effort to avoid breaking changes to it between releases. Removing this export should prevent third parties writing code which depends on its interface.
-
- 20 Sep, 2017 4 commits
-
-
Robert Knight authored
Adjust the preferred initial size of the OAuth popup window.
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Fix timestamp tooltips in annotation cards
-
- 18 Sep, 2017 5 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Sheetal Umesh Kumar authored
Rewrite viewFilter service and fix incorrect handling of any-field query terms in client-side search
-
Sheetal Umesh Kumar authored
Use profile display name in account menu
-
Robert Knight authored
Add more vertical and horizontal space per the designs for what the popup view should ideally look like [1], if the screen size is large enough and the user agent permits it. [1] https://github.com/hypothesis/product-backlog/issues/348
-
- 15 Sep, 2017 4 commits
-
-
Robert Knight authored
Timestamps on annotation cards are supposed to display the full date and time in the tooltip. This didn't work because `ng-title` is not a thing.
-
Robert Knight authored
-
Robert Knight authored
-
Sheetal Umesh Kumar authored
Render display name in new annotations
-
- 14 Sep, 2017 3 commits
-
-
Sheetal Umesh Kumar authored
Render the display name if set
-
Robert Knight authored
Populate the `user_info` field for new annotations from the logged-in user's profile. This enables new annotation cards to render the user's display name instead of their username if they have set one. This logic is currently in the annotation component init function for consistency with how the `user` field is initialized. However, it really ought to be in the code that handles the `addAnnotations` Redux action.
-
Robert Knight authored
-