- 04 Jan, 2024 1 commit
-
-
Robert Knight authored
A boolean `HTMLIntegration._sideBySideEnabled` flag has been retained in case a developer wants an easy way to turn this off for debugging. Fixes https://github.com/hypothesis/client/issues/5664
-
- 02 Jan, 2024 11 commits
-
-
dependabot[bot] authored
Bumps the sentry group with 2 updates: [@sentry/browser](https://github.com/getsentry/sentry-javascript) and [@sentry/cli](https://github.com/getsentry/sentry-cli). Updates `@sentry/browser` from 7.84.0 to 7.91.0 - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/develop/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/7.84.0...7.91.0) Updates `@sentry/cli` from 2.22.3 to 2.23.1 - [Release notes](https://github.com/getsentry/sentry-cli/releases) - [Changelog](https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-cli/compare/2.22.3...2.23.1) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: sentry - dependency-name: "@sentry/cli" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: sentry ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [tailwindcss](https://github.com/tailwindlabs/tailwindcss) from 3.3.6 to 3.4.0. - [Release notes](https://github.com/tailwindlabs/tailwindcss/releases) - [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/master/CHANGELOG.md) - [Commits](https://github.com/tailwindlabs/tailwindcss/compare/v3.3.6...v3.4.0) --- updated-dependencies: - dependency-name: tailwindcss dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
Robert Knight authored
Both `@sentry/browser` and `@hypothesis/frontend-shared` define items with the name `Dialog`. Rollup renames the one from `@hypothesis/frontend-shared` which changes its `Function.prototype.name` property, breaking tests which attempt to find it by name. The workaround is to find by value instead. The `Dialog` component from Sentry comes from the new feedback feature [1], which uses a component "framework" that looks like React, but it actually just a small wrapper around `document.createElement`. [1] https://github.com/getsentry/sentry-javascript/blob/develop/packages/feedback/src/widget/Dialog.ts
-
dependabot[bot] authored
Bumps the sentry group with 2 updates: [@sentry/browser](https://github.com/getsentry/sentry-javascript) and [@sentry/cli](https://github.com/getsentry/sentry-cli). Updates `@sentry/browser` from 7.84.0 to 7.88.0 - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/develop/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/7.84.0...7.88.0) Updates `@sentry/cli` from 2.22.3 to 2.23.0 - [Release notes](https://github.com/getsentry/sentry-cli/releases) - [Changelog](https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-cli/compare/2.22.3...2.23.0) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: sentry - dependency-name: "@sentry/cli" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: sentry ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [sass](https://github.com/sass/dart-sass) from 1.69.5 to 1.69.6. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](https://github.com/sass/dart-sass/compare/1.69.5...1.69.6) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps the rollup group with 1 update: [rollup](https://github.com/rollup/rollup). Updates `rollup` from 4.9.1 to 4.9.2 - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/rollup/rollup/compare/v4.9.1...v4.9.2) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-patch dependency-group: rollup ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps the redux group with 1 update: [redux](https://github.com/reduxjs/redux). Updates `redux` from 5.0.0 to 5.0.1 - [Release notes](https://github.com/reduxjs/redux/releases) - [Changelog](https://github.com/reduxjs/redux/blob/master/CHANGELOG.md) - [Commits](https://github.com/reduxjs/redux/compare/v5.0.0...v5.0.1) --- updated-dependencies: - dependency-name: redux dependency-type: direct:development update-type: version-update:semver-patch dependency-group: redux ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps the eslint group with 2 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) and [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser). Updates `@typescript-eslint/eslint-plugin` from 6.14.0 to 6.16.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.16.0/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 6.14.0 to 6.16.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.16.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: eslint - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: eslint ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps the babel group with 2 updates: [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) and [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env). Updates `@babel/core` from 7.23.6 to 7.23.7 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.7/packages/babel-core) Updates `@babel/preset-env` from 7.23.6 to 7.23.7 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.7/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: babel - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: babel ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [axe-core](https://github.com/dequelabs/axe-core) from 4.8.2 to 4.8.3. - [Release notes](https://github.com/dequelabs/axe-core/releases) - [Changelog](https://github.com/dequelabs/axe-core/blob/develop/CHANGELOG.md) - [Commits](https://github.com/dequelabs/axe-core/compare/v4.8.2...v4.8.3) --- updated-dependencies: - dependency-name: axe-core dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1520.0 to 2.1528.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.1520.0...v2.1528.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 18 Dec, 2023 8 commits
-
-
Alejandro Celaya authored
-
dependabot[bot] authored
Bumps the rollup group with 2 updates: [@rollup/plugin-json](https://github.com/rollup/plugins/tree/HEAD/packages/json) and [rollup](https://github.com/rollup/rollup). Updates `@rollup/plugin-json` from 6.0.1 to 6.1.0 - [Changelog](https://github.com/rollup/plugins/blob/master/packages/json/CHANGELOG.md) - [Commits](https://github.com/rollup/plugins/commits/url-v6.1.0/packages/json) Updates `rollup` from 4.8.0 to 4.9.1 - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/rollup/rollup/compare/v4.8.0...v4.9.1) --- updated-dependencies: - dependency-name: "@rollup/plugin-json" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: rollup - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-minor dependency-group: rollup ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps the eslint group with 3 updates: [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin), [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) and [eslint](https://github.com/eslint/eslint). Updates `@typescript-eslint/eslint-plugin` from 6.13.2 to 6.14.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.14.0/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 6.13.2 to 6.14.0 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.14.0/packages/parser) Updates `eslint` from 8.55.0 to 8.56.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/compare/v8.55.0...v8.56.0) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: eslint - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor dependency-group: eslint - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-minor dependency-group: eslint ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps the babel group with 2 updates: [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) and [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env). Updates `@babel/core` from 7.23.5 to 7.23.6 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.6/packages/babel-core) Updates `@babel/preset-env` from 7.23.5 to 7.23.6 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.6/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: babel - dependency-name: "@babel/preset-env" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: babel ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1515.0 to 2.1520.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.1515.0...v2.1520.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@hypothesis/frontend-shared](https://github.com/hypothesis/frontend-shared) from 7.0.1 to 7.1.0. - [Release notes](https://github.com/hypothesis/frontend-shared/releases) - [Changelog](https://github.com/hypothesis/frontend-shared/blob/main/docs/releases.md) - [Commits](https://github.com/hypothesis/frontend-shared/compare/v7.0.1...v7.1.0) --- updated-dependencies: - dependency-name: "@hypothesis/frontend-shared" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
Robert Knight authored
Remove the annotation privacy information from this component, since that status is already provided by the lock icon next to the username, and update the component to reflect its current purpose.
-
Robert Knight authored
This is now enabled for everyone.
-
- 15 Dec, 2023 3 commits
-
-
Alejandro Celaya authored
-
Robert Knight authored
These will be used in EPUB and PDF-based books respectively in LMS assignments configured to focus on a specific chapter or page range.
-
Robert Knight authored
-
- 14 Dec, 2023 4 commits
-
-
Alejandro Celaya authored
-
Robert Knight authored
These tests used to be different before the status related to the search query was split into a separate component, as one group tested output with a search query active and the other with no query.
-
Robert Knight authored
-
Robert Knight authored
Refactor query parsing functions in preparation for adding new focus modes: - Use different sets of field names when parsing queries for the sidebar's filter bar and backend search. The supported filters are different. - Make the `focusFilters` argument to `parseFilterQuery` more general so we can support adding in additional filters. The immediate use case is adding in `cfi` and `page` filters to support new focus modes.
-
- 12 Dec, 2023 8 commits
-
-
Robert Knight authored
This matches how page numbers are more typically written in e.g. citations.
-
Robert Knight authored
The warning is correct that this is not really how Reselect is supposed to be used, but it is intentional. Add a suppression with a comment explaining the intent in case we find a nicer approach in future that better aligns with how Reselect is supposed to be used.
-
Robert Knight authored
Fix an issue where the selector would return a new array on each call, even if called with the same arguments. Instead the correct way to capture multiple values from the state is to pass multiple arguments to `createSelector`.
-
Alejandro Celaya authored
-
dependabot[bot] authored
Bumps the redux group with 3 updates: [redux](https://github.com/reduxjs/redux), [redux-thunk](https://github.com/reduxjs/redux-thunk) and [reselect](https://github.com/reduxjs/reselect). Updates `redux` from 4.2.1 to 5.0.0 - [Release notes](https://github.com/reduxjs/redux/releases) - [Changelog](https://github.com/reduxjs/redux/blob/master/CHANGELOG.md) - [Commits](https://github.com/reduxjs/redux/compare/v4.2.1...v5.0.0) Updates `redux-thunk` from 2.4.2 to 3.1.0 - [Release notes](https://github.com/reduxjs/redux-thunk/releases) - [Commits](https://github.com/reduxjs/redux-thunk/compare/v2.4.2...v3.1.0) Updates `reselect` from 4.1.8 to 5.0.1 - [Release notes](https://github.com/reduxjs/reselect/releases) - [Changelog](https://github.com/reduxjs/reselect/blob/master/CHANGELOG.md) - [Commits](https://github.com/reduxjs/reselect/compare/v4.1.8...v5.0.1) --- updated-dependencies: - dependency-name: redux dependency-type: direct:development update-type: version-update:semver-major dependency-group: redux - dependency-name: redux-thunk dependency-type: direct:development update-type: version-update:semver-major dependency-group: redux - dependency-name: reselect dependency-type: direct:development update-type: version-update:semver-major dependency-group: redux ... Signed-off-by: dependabot[bot] <support@github.com>
-
Robert Knight authored
The loose distinction between `util/` and `helpers/` is that `util/` contains more general-purpose code that might be useful outside of the client, whereas `helpers/` contains more app-specific functions. The query parser is really the latter as it is closely linked to the annotation filtering logic implemented in `helpers/filter-annotations.ts`.
-
Robert Knight authored
Rename the module to match the main function it exports. This hopefully make it more obvious what the module does.
-
Robert Knight authored
The difference between `util/search-filter.ts` and `helpers/view-filter.ts` was previously not obvious from the name. One contains code to parse queries entered by the user, the other contains code to filter annotations against the parsed queries. Rename the parsing module and its functions to make it more obvious what they do.
-
- 11 Dec, 2023 5 commits
-
-
Robert Knight authored
Support `cfi:{start}-{end}` queries which filter annotations based on whether they have an associated EPUB CFI which lies in `[start, end)`. This query can be entered manually by the user in the search box, which is useful for testing, but the intent is that this filter would be used in contexts where the query is generated automatically (eg. as a result of a user making a selection from the book's table of contents).
-
Alejandro Celaya authored
-
dependabot[bot] authored
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.3.2 to 5.3.3. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/compare/v5.3.2...v5.3.3) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps the rollup group with 1 update: [rollup](https://github.com/rollup/rollup). - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](https://github.com/rollup/rollup/compare/v4.6.1...v4.8.0) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-minor dependency-group: rollup ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [prettier](https://github.com/prettier/prettier) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/3.1.0...3.1.1) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-