- 24 Jan, 2018 1 commit
-
-
Robert Knight authored
- Use the term "auth" for consistency with the `authorize` method and use the verb "open" to clarify that the popup window is being both created and shown. - Clarify the relation of the `$window` parameter to the returned window.
-
- 22 Jan, 2018 1 commit
-
-
Robert Knight authored
hypothesis/client#603 broke the login popup window in Firefox and IE because the call to `window.open` no longer happens in the same turn of the event loop as the user's click on the "Login" link. It is therefore no longer considered in FF to have happened "in response to a user gesture". This PR fixes the issue by separating creation and use of the popup window into separate functions and moving creation to happen earlier, in the same event loop turn as the "Login" button click. Fixes #534
-
- 19 Jan, 2018 1 commit
-
-
katelyn authored
Now there are two separate links for requesting an invite to our public Slack workspace (slack.hypothes.is) and accessing the workspace once you already have an account (hypothesis-open.slack.com)
-
- 10 Jan, 2018 2 commits
-
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
- 09 Jan, 2018 1 commit
-
-
Lyza Gardner authored
Allow whitelisted URL params in YouTube embeds add support for `t`, `start` and `end` query params for embedded YouTube videos.
-
- 19 Dec, 2017 11 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Sheetal Umesh Kumar authored
Update reference to annotator CSS bundle.
-
Robert Knight authored
`adder.js` contains a reference to the main CSS bundle generated from src/styles/annotator which was not updated when the CSS bundle's name was changed in f0b61e6a
-
Sheetal Umesh Kumar authored
Rename JS bundles to match corresponding source directory
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Rename the "injector" and "app" bundles to "annotator" and "sidebar" respectively to match the source directory which produces those bundles.
-
Sheetal Umesh Kumar authored
Rename entry point for annotator CSS bundle
-
Sheetal Umesh Kumar authored
Restructure sidebar styles in source tree
-
Sheetal Umesh Kumar authored
Rename entry points for annotator and sidebar bundles to 'index.js'
-
- 12 Dec, 2017 2 commits
-
-
Robert Knight authored
Update the docs for config options available to third party publishers.
-
Sheetal Umesh Kumar authored
-
- 11 Dec, 2017 6 commits
-
-
Robert Knight authored
Rename the entry point for the annotator CSS bundle so that it matches the name of the source directory from which the bundle is compiled and also the name of the corresponding JS bundle once that is renamed by hypothesis/client#633
-
Robert Knight authored
- Move the sidebar-specific styles into `styles/sidebar` and the component-specific styles into `styles/sidebar/components`. This mirrors the structure of the JS code in `src/`. - Rename the entry point for the sidebar's style bundle from "app.scss" to "sidebar.scss" to make it more obvious what is in the generated "sidebar.css" bundle. This move highlights some inappropriate dependencies between style modules and an unclearly structured assortment of "stuff" shared by both annotator and sidebar bundles in shared files in `src/styles`. There is probably a fair amount of unused code in there as well. Cleaning that up will happen in separate commits.
-
Robert Knight authored
Rename the entry points to the more conventional 'index.js' for the benefit of new visitors to the codebase and also for consistency across the different bundles that make up the client.
-
Robert Knight authored
-
Robert Knight authored
-
Sean Hammond authored
Remove create account banner
-
- 07 Dec, 2017 4 commits
-
-
Robert Knight authored
The template no longer uses this property.
-
Robert Knight authored
The text is potentially inappropriate in the context of publisher-managed accounts where the account might not be free and the user might not be able to create one themselves. In the first party account context we agreed that the banner is a bit redundant anyway. See https://hypothes-is.slack.com/archives/C07NXBDNW/p1510080494000386
-
Sean Hammond authored
-
Sean Hammond authored
-
- 06 Dec, 2017 11 commits
-
-
Robert Knight authored
Disable close btn when the classic theme is on. Also fix errors with …
-
Sheetal Umesh Kumar authored
Disable close btn when the classic theme is on. Also fix errors with the preferences object being obsent from session state initially.
-
Robert Knight authored
Remove unnecessary config in test.
-
Sheetal Umesh Kumar authored
-
Robert Knight authored
Bundle the clean theme related config options into the theme = 'clean…
-
Sheetal Umesh Kumar authored
Some of the config settings don't work well with the clean theme. Some others don't work without the clean theme. It would be better to remove the following config options and have each of these elements tied to the over all 'theme' of the sidebar for consistency: disableToolbarCloseBtn disableToolbarMinimizeBtn disableToolbarHighlightsBtn disableToolbarNewNoteBtn disableBucketBar enableSidebarDropShadow enableCleanOnboardingTheme See https://github.com/hypothesis/product-backlog/issues/380
-
Sheetal Umesh Kumar authored
Show the shorter version of the empty annotations/notes message when …
-
Sean Hammond authored
Don’t link tags to activity pages on eLife
-
Sean Hammond authored
The stream page was replaced by the search page. Update some old references to the stream in the tests.
-
Sean Hammond authored
Tag search pages aren't supported for third-party annotations in h, so don't link to them from the client. Fixes https://github.com/hypothesis/client/issues/616
-
Robert Knight authored
Fix out of date account-id fake
-