- 25 Apr, 2022 6 commits
-
-
Robert Knight authored
Co-authored-by: Lyza Gardner <439947+lyzadanger@users.noreply.github.com>
-
Robert Knight authored
Split the `useStoreProxy` hook into a generic/base `useStore` hook that handles wrapping a store created with `createStore`, and a `useSidebarStore` hook that handles looking up the sidebar's main store via `useService('store')` and passing it to the base hook. This follows the existing separation of responsibilities between `createStore` vs `createSidebarStore`, and would potentially allow us to split the generic store infrastructure code into a separate package for use in other projects in future.
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
Show Notebook option in UserMenu regardless of feature-flag status.
-
- 22 Apr, 2022 2 commits
-
-
Robert Knight authored
The reference to "config fragment" may be unclear here, so just leave it out. Someone interested in the details of how configuration is passed to applications on launch can read the code that uses this config type.
-
Robert Knight authored
Various functions and constructors in the annotator code accepted a `config` parameter with an uninformative `Record<string, any>` type. Replace these types with more specific ones that specify required / known optional properties directly and use `Record<string, unknown>` for properties which are forwarded to other contexts. Also improve the documentation for the `getConfig` function which serves as the entry point for reading configuration in the annotator.
-
- 21 Apr, 2022 20 commits
-
-
Robert Knight authored
Use the suffix "Response" rather than "Result" for consistency with other API response types.
-
Robert Knight authored
Make `fetchJSON` return `Promise<unknown>` rather than `Promise<any>` and add appropriate types and casts for the remaining API / OAuth responses that didn't have them.
-
Robert Knight authored
When declaring a prop or parameter callback whose result is unused, the return type should be `void` rather than `any`. In this context the return type specifies what the callee _requires_, not what the caller _provides_.
-
Robert Knight authored
-
Robert Knight authored
Add spec link and mark `params` as optional.
-
Robert Knight authored
This option is enabled by default when `strict` is set [1], so just remove the override in src/tsconfig.json that turned it off. Also remove the `tsconfig.no-any.json` auxilliary configuration that was used during the migration. Fixes https://github.com/hypothesis/client/issues/3918 [1] https://www.typescriptlang.org/tsconfig#noImplicitAny
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Robert Knight authored
- Add missing types in MarkdownEditor implementation - Simplify `onEditText` prop to take a single `text` string argument instead of an object with a `text` property
-
- 20 Apr, 2022 5 commits
-
-
Robert Knight authored
When traversing the RouteMap there are three possibilities: - There is no route that matches the path segment - There is a child `RouteMap` that matches the path segment - There is a child `RouteMetadata` that matches the path segment, in which case we should only return it if we reached the end of the path Rewrite `findRouteMetadata` to handle these possibilities more explicitly. We already had tests that covered the expected behavior, this rewrite just avoid a cast which is technically incorrect.
-
Robert Knight authored
Fix remaining errors needed to make this directory typecheck with `noImplicitAny`. - Add missing types - Use `Object.entries` instead of `for..in` for record iteration in several places. Add an `entries` utility to make iteration over `Record<Key, Value>` types more convenient where `Key` is more specific than just a string. - Change localStorage fallback to use a Map rather than object for temporary data storage
-
Lyza Danger Gardner authored
Use shared `Card` component for styling
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
- 19 Apr, 2022 7 commits
-
-
Robert Knight authored
- Include all src/types/*.d.ts files when typechecking with the main tsconfig.json config. Previously some of these were only included when using tsconfig.no-any.json. - Update our custom types for lodash.debounce to support arguments. This is needed by some of the `Thread*` components. I added the `leading` and `trailing` options for completeness, though we don't use them anywhere. - Add missing types in debounced callbacks in ThreadCard. These are now required due to the previous change.
-
dependabot[bot] authored
Bumps [@sentry/cli](https://github.com/getsentry/sentry-cli) from 1.74.3 to 2.0.2. - [Release notes](https://github.com/getsentry/sentry-cli/releases) - [Changelog](https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-cli/compare/1.74.3...2.0.2) --- updated-dependencies: - dependency-name: "@sentry/cli" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [eslint-plugin-mocha](https://github.com/lo1tuma/eslint-plugin-mocha) from 10.0.3 to 10.0.4. - [Release notes](https://github.com/lo1tuma/eslint-plugin-mocha/releases) - [Changelog](https://github.com/lo1tuma/eslint-plugin-mocha/blob/master/CHANGELOG.md) - [Commits](https://github.com/lo1tuma/eslint-plugin-mocha/compare/10.0.3...10.0.4) --- updated-dependencies: - dependency-name: eslint-plugin-mocha dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [redux](https://github.com/reduxjs/redux) from 4.1.2 to 4.2.0. - [Release notes](https://github.com/reduxjs/redux/releases) - [Changelog](https://github.com/reduxjs/redux/blob/master/CHANGELOG.md) - [Commits](https://github.com/reduxjs/redux/compare/v4.1.2...v4.2.0) --- updated-dependencies: - dependency-name: redux dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [sass](https://github.com/sass/dart-sass) from 1.50.0 to 1.50.1. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](https://github.com/sass/dart-sass/compare/1.50.0...1.50.1) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@types/escape-html](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/escape-html) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/escape-html) --- updated-dependencies: - dependency-name: "@types/escape-html" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [sinon](https://github.com/sinonjs/sinon) from 13.0.1 to 13.0.2. - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md) - [Commits](https://github.com/sinonjs/sinon/compare/v13.0.1...v13.0.2) --- updated-dependencies: - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-