- 30 Sep, 2015 2 commits
-
-
Nick Stenning authored
Fix a bug where canceling changes did not reset the text
-
Robert Knight authored
AnnotationController.revert() reverted changes to the annotation in the editor by copying across properties from the saved annotation to the draft. Any properties which were _added_ in the draft but not set in the saved version, such as the text when the text is empty, were not reverted. Fixes #2561
-
- 29 Sep, 2015 4 commits
-
-
Sean Hammond authored
Fix email notifications
-
Nick Stenning authored
Add guidelines for writing model code and db migrations
-
Sean Hammond authored
Update instructions for running front-end tests.
-
Sean Hammond authored
Make auth.effective_principals do what it says
-
- 28 Sep, 2015 1 commit
-
-
Jake Hartnell authored
Automatically convert URLs in annotation text to links
-
- 26 Sep, 2015 1 commit
-
-
Robert Knight authored
Only URLs with a scheme or beginning with 'www.' are processed. Fixes #2505
-
- 25 Sep, 2015 9 commits
-
-
Nick Stenning authored
(see 9d57500)
-
Nick Stenning authored
(Because compiling assets is something we do in production.)
-
Sean Hammond authored
Fix comments (AKA "page notes") with search_normalized
-
Nick Stenning authored
Previously, an annotation with a selectorless target (such as a comment or "page note") would be marked as an orphan. This commit adjusts the orphan detection code so that an annotation is marked as an orphan only if both of the following conditions are met: - it has at least one target with selectors (an "anchorable target") - none of the anchorable targets have successfully anchored
-
Nick Stenning authored
In order for comments (AKA "page notes") to be discoverable with the search logic implemented in #2413 (cc4ca35), they need to have at least one target with a source field. Previously a comment was defined as an annotation - with a `uri` - without any targets - without any references (no targets but with references == a reply) Now comments have a single target with a single field, `source`. This finally puts us in a position where we can consider deprecating the `uri` field.
-
Nick Stenning authored
If one of these asserts fails, then this test will timeout (taking 2 seconds to do so). By using a small helper (`timeoutPromise`) to implement the "next tick" functionality that was previously achieved with `setTimeout`, this is improved: we return a promise from the test function and a failure will be reported immediately. See https://mochajs.org/#working-with-promises for more on returning promises from mocha test functions.
-
Nick Stenning authored
It's not at all clear from the code that the singular "selector" is in fact an array of selectors referring to a single target. Add a few comments to help understanding this until we can sort out a better refactoring/naming.
-
Nick Stenning authored
The last thing that used this was removed in 7829cc1.
-
Nick Stenning authored
Change $anchored -> $orphan
-
- 24 Sep, 2015 5 commits
-
-
Sean Hammond authored
-
Sean Hammond authored
Instead of setting $anchored=true on anchored annotations, set $orphan=true on orphaned (i.e. unanchored) ones as we used to do. Orphaned annotations are the exception: we don't show them, or if show_unanchored_annotations is one then we show them with a warning. It's simpler and less buggy to add $orphan=true onto the exceptional annotations than to try to add $anchored=true onto all of the unexceptional ones. Fixes #2525. Fixes #2541.
-
Nick Stenning authored
Fix document title and domain for local file PDF annotations
-
Sean Hammond authored
This fixes two issues on the annotation cards for some annotations: 1. If the annotated document has a non-http(s) URI (e.g. a local file:// URI) then don't hyperlink the document's title to that URI 2. If the annotated document has no .domain value or its domain is the same as its title then don't display anything, instead of displaying a pair of emtpy braces (). To fix this move the logic for formatting an annotation's document's title and domain into AngularJS filters where it can be tested, instead of in the template.
-
Nick Stenning authored
Use autoprefixer to add vendor prefixes to CSS
-
- 23 Sep, 2015 13 commits
-
-
Robert Knight authored
Translate annotation mapper
-
Nick Stenning authored
Hide unanchored warnings when not sidebar
-
Sean Hammond authored
Don't show the "We can't find the exact position of this annotation" warnings on unanchored annotations when on the stream or individual annotation pages - only show them in the sidebar.
-
Robert Knight authored
Fix an issue where the group details container could horizontally overflow the dropdown menu. In IE 10 the text did not automatically wrap. Add flex-shrink so that it will collapse if necessary. Card 87
-
Nick Stenning authored
In preparation for making some substantial changes to this piece of code, I'm translating it to JS.
-
Nick Stenning authored
In preparation for making some substantial changes to this piece of code, I'm translating it to JS.
-
Robert Knight authored
Use postcss and the autoprefixer plugin to post-process CSS to add vendor prefixes and remove use of compass mixins which did the same thing. This moves compatibility concerns out of our styling and down to a post-processor whose options can be adjusted as necessary and moves us a step towards removing the build dependency on compass. Looking at the generated output, it fixes several issues where we were inconsistent about which prefixes were used. Pyramid webassets does have an autoprefixer filter but it was written for an older version of autoprefixer which was a standalone tool rather than a postcss plugin. In future this also paves the way to replacing the cleancss asset filter with an optional step in the postcss-filter.js script.
-
Nick Stenning authored
-
Robert Knight authored
Consolidate .gitignore files
-
Nick Stenning authored
Auto re-install Python, Node deps if out of date
-
Nick Stenning authored
Having these scattered about across the repository makes it hard to work out where something is ignored, and most tools/editors that read .gitignore files don't pay attention to those not in the repository root.
-
Nick Stenning authored
T87 - Improve group scope dropdown ui
-
Robert Knight authored
For IE 10 and Safari < 9 support, use prefixed flexbox. For now, this duplicates the flexbox declarations as is done in topbar.scss. I will look into using autoprefixer for this separately. Card 87
-
- 22 Sep, 2015 5 commits
-
-
Nick Stenning authored
cf410d0 broke standalone annotation pages by changing `threadRoot.children` from an array into a thread container. Unsurprisingly, `children` is supposed to be an array.
-
Robert Knight authored
* Use the singular 'groupList' everywhere * Simplify the logic for stopping click propagation when toggling the selected group * Remove underscore prefix for Controller classes as per the PR discussion. Card 87
-
Robert Knight authored
Card 87
-
Sean Hammond authored
Fix detection of PDF URIs
-
Robert Knight authored
Card 87
-