- 30 Jul, 2020 10 commits
-
-
Kyle Keating authored
-
Kyle Keating authored
-
Kyle Keating authored
-
Kyle Keating authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
The way that the search interface is currently implemented, clicking on the "search" icon in the top bar actually submits the search form (with an empty query). Ignoring empty queries if a query has not yet been set alleviates "searching" for nothing. This also prevents expanded threads from being re-collapsed when clicking on the search icon.
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
dependabot-preview[bot] authored
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3. **This update includes a security fix.** - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
- 29 Jul, 2020 5 commits
-
-
Kyle Keating authored
- add props for annotation-action-bar - add props for annotation-document-info - dependency fixes: - add selector types for groups stores - fixup errors discovered in annotation-share-control - fixup errors in util/permissions
-
Kyle Keating authored
-
Kyle Keating authored
This causes several issues and its not immediately clear this needs or should be required
-
Robert Knight authored
Naming the variable `createElement` caused a crash when running `yarn lint` with eslint-plugin-react v7.20.4, presumably because it was being treated like the `createElement` import from Preact/React.
-
dependabot-preview[bot] authored
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.20.3 to 7.20.4. - [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases) - [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](https://github.com/yannickcr/eslint-plugin-react/compare/v7.20.3...v7.20.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
- 28 Jul, 2020 6 commits
-
-
Kyle Keating authored
-
dependabot-preview[bot] authored
Bumps [fetch-mock](https://github.com/wheresrhys/fetch-mock) from 9.10.4 to 9.10.5. - [Release notes](https://github.com/wheresrhys/fetch-mock/releases) - [Commits](https://github.com/wheresrhys/fetch-mock/compare/v9.10.4...v9.10.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [commander](https://github.com/tj/commander.js) from 5.1.0 to 6.0.0. - [Release notes](https://github.com/tj/commander.js/releases) - [Changelog](https://github.com/tj/commander.js/blob/master/CHANGELOG.md) - [Commits](https://github.com/tj/commander.js/compare/v5.1.0...v6.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 5.1.0 to 5.2.1. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Commits](https://github.com/puppeteer/puppeteer/compare/v5.1.0...v5.2.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [codecov](https://github.com/codecov/codecov-node) from 3.7.1 to 3.7.2. - [Release notes](https://github.com/codecov/codecov-node/releases) - [Commits](https://github.com/codecov/codecov-node/compare/v3.7.1...v3.7.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.19.2 to 5.20.1. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/5.19.2...5.20.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
- 27 Jul, 2020 3 commits
-
-
dependabot-preview[bot] authored
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 18.0.1 to 18.0.3. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](https://github.com/octokit/rest.js/compare/v18.0.1...v18.0.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.715.0 to 2.720.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.715.0...v2.720.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Kyle Keating authored
- Add types for each store including most of their selectors and actions. - Not every selector and action is completed, but this covers most of them and serves as a first step to typing all the selectors / actions
-
- 24 Jul, 2020 2 commits
-
-
Robert Knight authored
Generalize the code for converting URLs of the form `https://<hostname>/<path containing a video ID>` into media player iframes and add support for Flipgrid videos. Fixes https://github.com/hypothesis/product-backlog/issues/1125
-
Robert Knight authored
-
- 23 Jul, 2020 9 commits
-
-
Robert Knight authored
Avoid video embeds being cut off in narrow viewports
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
- Add tests for `useRootThread`, using `threadAnnotations`
-
Lyza Danger Gardner authored
This functionality is now handled by a util
-
Lyza Danger Gardner authored
* Establish a `root-thread` utility that is pure and takes its state as a single argument; wrap with `memoize` and export * Create a memoized rootSelector in the `selection` module that composes the state needed by the `root-thead` utility * The `useRootThread` hook uses the selector and the `root-thread` util
-
Lyza Danger Gardner authored
Refactor root-thread usage by UI components to be via a preact hook
-
Robert Knight authored
Embeds can end up taking up a lot of screen space in the single annotation view and stream on desktop, so cap their width. Unfortunately this has to be done in a slightly roundabout way due to the way that the height of video embeds is set.
-
Robert Knight authored
Previously video embeds were given a fixed with of 369px, which is close to the width available to annotation content at the sidebar's default width (~380px). On narrower viewports the video would get cut off. Fix this by setting the width of video embeds to `100%` and using a CSS hack [1] to set the height of the video such that the embed has a 16:9 aspect ratio, which is what YouTube optimizes for. - Set `width: 100%` on `excerpt__content` and `markdown-view` so that the annotation content always fills the available width. - Add support for specifying a class name for embed containers when calling `replaceLinksWithEmbeds` and use that to give embeds rendered in `MarkdownView` a `width` of 100%. - Change `replaceLinksWithEmbeds` to wrap iframes with an aspect-ratio box (see [1]) which causes the iframe's height to be adjusted as the width changes to have a 16:9 aspect ratio. Adding this container required changes in `media-embedder-test` to allow the `<iframe>` to be wrapped in a container element. [1] https://css-tricks.com/aspect-ratio-boxes/
-
- 22 Jul, 2020 2 commits
-
-
Kyle Keating authored
- TagList - TagEditor - MarkdownEditor - Excerpt - AutocompleteList - AnnotationBody
-
Kyle Keating authored
Add SidebarStore type. This is an aggregation of the base ReduxStore + each one of our stores baked in. The fist store added here is simply the Activity store (as a first example) There are some assumptions when making store types: 1. It is assumed they are transformed in `createStore` where the selectors and actions are flattened. 2. Some meta data (namely, the init method, namespace and update method) are refactored or removed. These transformations are implied through the typing which explicitly ignores these methods and structure of the raw store before the transformation in create-store.
-
- 21 Jul, 2020 3 commits
-
-
Robert Knight authored
Bump codecov from 3.7.0 to 3.7.1
-
Robert Knight authored
Convert store selectors to receive local rather than root state
-
Robert Knight authored
Since selectors are attached to the `store` as methods, selectors from different modules are not allowed to have the same name.
-