- 16 Feb, 2018 7 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Sheetal Umesh Kumar authored
Only wait for document URI before fetching groups in sidebar
-
Robert Knight authored
Fixes a regression after 36c46608 where the stream and single annotation page views failed to load. 36c46608 made the groups service wait for the host page's document URI to be determined before making a call to the `/api/groups` endpoint passing that URI as a parameter. In the stream (`/stream`) and single annotation page routes, there is no host page and so the promise returned by `getDocumentUriForGroupSearch` never resolved. Avoid waiting for this URI in that case and avoid passing the `document_uri` parameter to the `/api/groups` endpoint. This commit introduces a new `isSidebar` test rather than using `annotationUI.isSidebar` because that piece of app state is not yet initialized at the point when `groups.load()` is called in the route's `resolve` function in src/sidebar/index.js.
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Get the list of groups from the new endpoint and update it where applicable
-
- 15 Feb, 2018 1 commit
-
-
Sheetal Umesh Kumar authored
Fetch the list of groups from the new `/api/groups` endpoint instead of using the groups list returned in the `/api/profile` result. This supports providing the current document URI as a parameter, which enables the server to change the list of open groups returned depending on the current URL. In order to update the groups list correctly, taking into account the current document URI, when the user joins or leaves a group, the `streamer` service now handles "session change" notifications by triggering a re-fetch of groups from the `/api/groups` endpoint instead of updating the groups directly from the payload of the WebSocket message. Co-authored-by: Robert Knight <robertknight@gmail.com>
-
- 13 Feb, 2018 4 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Sean Hammond authored
Update to Angular 1.6.9
-
Sean Hammond authored
Fix spinner animation
-
- 12 Feb, 2018 4 commits
-
-
Robert Knight authored
Fix a test failure due to a subtle issue with the interaction between the `$q` service, `AnnotationController#delete` and `$timeout.flush` in tests. Instantiating the rejected promise _before_ calling `$timeout.flush` resulted in Angular's unhandled promise checking code being triggered in the test.
-
Robert Knight authored
Fix occurrences of a "multilink" [1] error during test for the annotation save button. Replace calls to the link function with direct assignments to controller properties. [1] https://code.angularjs.org/1.6.9/docs/error/$compile/multilink
-
Robert Knight authored
The main change that affects us is that component inputs/bindings are no longer available as controller properties in the constructor by default. Instead this logic should go in a controller's `$onInit` method. In this commit use the `$compileProvider.preAssignBindingsEnabled` compatibility helper which preserves the Angular <= 1.5 behavior. This is being removed in Angular 1.7.
-
Robert Knight authored
`@keyframes($name)` is not legal syntax. I'm unsure if this ever worked in the past in older browsers or if it was previously converted by a post-processor to valid syntax.
-
- 09 Feb, 2018 1 commit
-
-
Sheetal Umesh Kumar authored
Refactor export of bound selectors from Redux store
-
- 06 Feb, 2018 1 commit
-
-
Robert Knight authored
Group the selectors in each Redux module together in a `selectors` object so they can be re-exported as methods on the Redux store without having to list each of them manually. This also just makes it easier to visually see which exported functions from a Redux module are selectors.
-
- 30 Jan, 2018 4 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Sean Hammond authored
Hide the direct-link CTA for third party accounts
-
Robert Knight authored
The CTA message shown when an anonymous user visits a direct link contains links to the Hypothesis site and makes other assumptions, such as the user being able to create accounts and those accounts being free, which may not be applicable on sites that use third party accounts. For now, just hide this CTA if the page uses third party accounts. Fixes #656 Fixes #657
-
- 29 Jan, 2018 1 commit
-
-
Robert Knight authored
Add script to initiate a client release
-
- 25 Jan, 2018 4 commits
-
-
Robert Knight authored
Add a script to handle creating a new client release using yarn, ensuring that the Git tag is signed. Unfortunately yarn's default is for this setting to be turned off. Also unlike `npm version`, `yarn version` does not support automatically incrementing the package version.
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Fix login flow triggering popup blocker in Firefox and IE
-
- 24 Jan, 2018 2 commits
-
-
Robert Knight authored
Use the verb form for correctness in context and consistency with text on the h web pages.
-
Robert Knight authored
- Use the term "auth" for consistency with the `authorize` method and use the verb "open" to clarify that the popup window is being both created and shown. - Clarify the relation of the `$window` parameter to the returned window.
-
- 22 Jan, 2018 1 commit
-
-
Robert Knight authored
hypothesis/client#603 broke the login popup window in Firefox and IE because the call to `window.open` no longer happens in the same turn of the event loop as the user's click on the "Login" link. It is therefore no longer considered in FF to have happened "in response to a user gesture". This PR fixes the issue by separating creation and use of the popup window into separate functions and moving creation to happen earlier, in the same event loop turn as the "Login" button click. Fixes #534
-
- 19 Jan, 2018 1 commit
-
-
katelyn authored
Now there are two separate links for requesting an invite to our public Slack workspace (slack.hypothes.is) and accessing the workspace once you already have an account (hypothesis-open.slack.com)
-
- 10 Jan, 2018 2 commits
-
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
- 09 Jan, 2018 1 commit
-
-
Lyza Gardner authored
Allow whitelisted URL params in YouTube embeds add support for `t`, `start` and `end` query params for embedded YouTube videos.
-
- 19 Dec, 2017 6 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Sheetal Umesh Kumar authored
Update reference to annotator CSS bundle.
-
Robert Knight authored
`adder.js` contains a reference to the main CSS bundle generated from src/styles/annotator which was not updated when the CSS bundle's name was changed in f0b61e6a
-
Sheetal Umesh Kumar authored
Rename JS bundles to match corresponding source directory
-
Robert Knight authored
-