- 03 Jan, 2023 13 commits
-
-
Robert Knight authored
In preparation for enabling the `book_as_single_document` feature for everyone, enable capturing the EPUBContentSelector selector whether the feature flag is enabled or not. Once this is released, all new VS annotations will have all the data they will need after they are migrated to the new format [1] and only the annotation URL will need to be changed. This will leave us with only a fixed set of older annotations for which we will need to obtain the missing CFI and chapter title data. [1] See https://github.com/hypothesis/h/issues/7709
-
Robert Knight authored
-
Robert Knight authored
Change `EPUBContentSelector` selectors captured in VS books to include the resolved URL of the content document (eg. "https://jigsaw.vitalsource.com/books/{book_id}/...") rather than just the path ("/books/{book_id}/..."). This may make it easier to work with these URLs outside of the VitalSource viewer, and should also make these URLs more consistent with `EPUBContentSelector` selectors captured in other ebook readers in future.
-
Robert Knight authored
For text selection to work well it is important that `<hypothesis-text-word>` elements do not span multiple lines. Previously the layout analysis only created new words after a space. Since most lines end with a whole word, this was sufficient in most cases. However this doesn't work if a word is broken across multiple lines (eg. with a hyphen). To handle this case, also create a word break if the current character does not vertically overlap the previous character. This may create some false positives (ie. unnecessary word breaks), but that doesn't harm text selection. Fixes #5066
-
dependabot[bot] authored
Bumps [sass](https://github.com/sass/dart-sass) from 1.56.2 to 1.57.1. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md) - [Commits](https://github.com/sass/dart-sass/compare/1.56.2...1.57.1) --- updated-dependencies: - dependency-name: sass dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [prettier](https://github.com/prettier/prettier) from 2.8.0 to 2.8.1. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](https://github.com/prettier/prettier/compare/2.8.0...2.8.1) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1277.0 to 2.1286.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.1277.0...v2.1286.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.46.1 to 5.47.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.47.1/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@types/katex](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/katex) from 0.14.0 to 0.16.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/katex) --- updated-dependencies: - dependency-name: "@types/katex" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@sentry/cli](https://github.com/getsentry/sentry-cli) from 2.10.0 to 2.11.0. - [Release notes](https://github.com/getsentry/sentry-cli/releases) - [Changelog](https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-cli/compare/2.10.0...2.11.0) --- updated-dependencies: - dependency-name: "@sentry/cli" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 7.27.0 to 7.28.1. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/7.27.0...7.28.1) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.20.5 to 7.20.7. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.20.7/packages/babel-core) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
Robert Knight authored
-
- 19 Dec, 2022 8 commits
-
-
dependabot[bot] authored
Bumps [@rollup/plugin-json](https://github.com/rollup/plugins/tree/HEAD/packages/json) from 5.0.2 to 6.0.0. - [Release notes](https://github.com/rollup/plugins/releases) - [Changelog](https://github.com/rollup/plugins/blob/master/packages/json/CHANGELOG.md) - [Commits](https://github.com/rollup/plugins/commits/url-v6.0.0/packages/json) --- updated-dependencies: - dependency-name: "@rollup/plugin-json" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [sinon](https://github.com/sinonjs/sinon) from 15.0.0 to 15.0.1. - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md) - [Commits](https://github.com/sinonjs/sinon/compare/v15.0.0...v15.0.1) --- updated-dependencies: - dependency-name: sinon dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [mocha](https://github.com/mochajs/mocha) from 10.1.0 to 10.2.0. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](https://github.com/mochajs/mocha/compare/v10.1.0...v10.2.0) --- updated-dependencies: - dependency-name: mocha dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.1262.0 to 2.1277.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.1262.0...v2.1277.0) --- updated-dependencies: - dependency-name: aws-sdk dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 5.44.0 to 5.46.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v5.46.1/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 7.24.2 to 7.27.0. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/7.24.2...7.27.0) --- updated-dependencies: - dependency-name: "@sentry/browser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@rollup/plugin-replace](https://github.com/rollup/plugins/tree/HEAD/packages/replace) from 5.0.1 to 5.0.2. - [Release notes](https://github.com/rollup/plugins/releases) - [Changelog](https://github.com/rollup/plugins/blob/master/packages/replace/CHANGELOG.md) - [Commits](https://github.com/rollup/plugins/commits/json-v5.0.2/packages/replace) --- updated-dependencies: - dependency-name: "@rollup/plugin-replace" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
-
dependabot[bot] authored
Bumps [@rollup/plugin-commonjs](https://github.com/rollup/plugins/tree/HEAD/packages/commonjs) from 23.0.4 to 24.0.0. - [Release notes](https://github.com/rollup/plugins/releases) - [Changelog](https://github.com/rollup/plugins/blob/master/packages/commonjs/CHANGELOG.md) - [Commits](https://github.com/rollup/plugins/commits/commonjs-v24.0.0/packages/commonjs) --- updated-dependencies: - dependency-name: "@rollup/plugin-commonjs" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
-
- 16 Dec, 2022 1 commit
-
-
Robert Knight authored
Co-locate these types with other types that are determined by the VitalSource book reader, as opposed to us. This also gives us a single module (types/vitalsource.ts) that we can point to in order to explain which APIs from Bookshelf we rely on.
-
- 15 Dec, 2022 3 commits
-
-
Robert Knight authored
This is in response to https://github.com/hypothesis/client/pull/5065#pullrequestreview-1219224635.
-
Robert Knight authored
In PDF-based VitalSource books, each page has a different CFI, but many pages may belong to the same logical book chapter and thus share the same chapter title. In the sidebar we only want to show one heading per chapter. Therefore add logic in ThreadList to avoid showing the same heading multiple times in succession. Fixes https://github.com/hypothesis/client/issues/5064
-
Robert Knight authored
This should have been removed in 2e30052d.
-
- 14 Dec, 2022 5 commits
-
-
Robert Knight authored
Extract the type definitions for the `<mosaic-book>` element provided by VitalSource into `src/types/vitalsource.ts` and use JSDoc + TS to typecheck the fake implementation in vitalsource-mosaic-book-element.js. Extracting the definitions into a standalone module avoids the need for TS to process all of the transitive dependencies of src/annotator/integrations/vitalsource.ts when processing the dev-server/tsconfig.json project.
-
Robert Knight authored
This isn't currently used, but it is marked as a required property in the `TableOfContentsEntry` interface in src/annotator/integrations/vitalsource.ts.
-
Robert Knight authored
This API is now called when creating annotations.
-
Robert Knight authored
Work around an issue where the `getCurrentPage` API can return incorrect chapter titles [1] by using titles from the `getTOC` API instead. [1] https://github.com/hypothesis/client/issues/4986
-
Robert Knight authored
Move these functions so they can be used by EPUB integrations in the annotator code.
-
- 13 Dec, 2022 10 commits
-
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
Rename internal component to avoid type conflict with external `ToastMessage` type
-
Lyza Danger Gardner authored
-
Robert Knight authored
This reverts commit 9ecedcf4.
-
Robert Knight authored
The `formatDate` test failed for me locally due to Chrome using a "\u202F" (Narrow non-breaking space) char between "11:02" and "PM", instead of a regular space. Apply unicode normalization to ignore this difference.
-