- 12 Jul, 2016 2 commits
-
-
Robert Knight authored
Use anchor rather than link elements for the tab bar items so that they are focusable via keyboard navigation. Also follow code conventions and use 'is-<state>' for element states set in JS.
-
Robert Knight authored
Focus the Annotation and Notes tabs on touch or mouse down rather than click. This makes the tabs act more like tabs in native apps and feel more responsive. Since Angular does not provide a built-in attribute directive for handling touch events, implement a custom one.
-
- 11 Jul, 2016 2 commits
-
-
Robert Knight authored
Selection tabs tweaks.
-
Sheetal Umesh Kumar authored
Fix PR comments including some UI tweaks and bug fixes. Hide no annotations/notes message when annotations are still loading. When the annotations are still loading, a 0 annotations message shows for a flash of a second before the list loads. Avoid this by only displaying the 0 state after the annotations have finished loading. If selected annotation/note is deleted, default selected tab to annotation. If a user lands on a direct link for a deleted annotation, the button to take the user back to the list of annotations/notes should by default be for annotations. On clearning the selection, filter annotations according to the selected tab type. Fix broken standalone page for notes. selectedTab was set to annotations by default, even for standalone pages. selectedTab should be undefined for a standalone page because there are no tabs to select from. select the annotations tab by default for the sidebar alone. Change copy for empty annotaitons/notes state.
-
- 08 Jul, 2016 2 commits
-
-
Robert Knight authored
-
Robert Knight authored
Add a set of `npm version` scripts which can be used to tag and publish a new release of the client with: npm version major|minor|patch npm publish Where most releases will use `npm version minor`.
-
- 07 Jul, 2016 2 commits
-
-
Sheetal Umesh Kumar authored
Add a change log
-
Robert Knight authored
Add a change log for the Hypothesis client, following the format suggested at http://keepachangelog.com/
-
- 06 Jul, 2016 1 commit
-
-
Robert Knight authored
This was a workaround for an issue with proxyquire and PhantomJS 1.9. It is no longer needed following the upgrade to PhantomJS 2.x
-
- 05 Jul, 2016 13 commits
-
-
Christof Dorner authored
For now we only build the client and run the tests.
-
Sean Hammond authored
Remove the ban on using console.log() in tests
-
Sean Hammond authored
Simplify request preparation in `store.js`
-
Robert Knight authored
This was intended to prevent console.{log,warn,...} calls accidentally being left in test code. However the result was very confusing for H developers who only occassionally worked with the H client test suite. This problem is better solved by a linter.
-
Sean Hammond authored
Upgrade PhantomJS from 1.x to 2.x
-
Sean Hammond authored
Fix new replies being moved to the newly focused group
-
Robert Knight authored
Use "log in"/"log out"/"sign up" consistently
-
Nick Stenning authored
-
Nick Stenning authored
-
Nick Stenning authored
-
Robert Knight authored
Unless there is a clear reason not to do so, it is generally preferred to use methods from the ECMA standard lib.
-
Robert Knight authored
Rather than using a $http request transform to preprocess the data, just pass the data object into the `stripInternalProperties` function directly.
-
Robert Knight authored
Previously the `group` and `permissions` properties of new replies were set _after_ creating the reply with `createAnnotation()`. This meant that the new reply did not have the correct group and permissions when it was filtered for the first time by the `buildThread()` function.
-
- 04 Jul, 2016 7 commits
-
-
Robert Knight authored
Work around a bug in Karma 1.10 [1] which caused console messages from tests not to be propagated to the terminal. A fix has been accepted upstream and this workaround can be removed when the next release of Karma is made. [1] See https://github.com/litixsoft/karma-mocha-reporter/issues/67
-
Robert Knight authored
Under PhantomJS 2.x `new URL(uri)` works, so the feature test in `polyfills.js` passes, but the resulting URL object is an apparently empty object. Properties such as `hostname` and `href` are missing for example. Load the URL polyfill explicitly in the Karma-specific polyfill module.
-
Robert Knight authored
Under PhantomJS 2.x, the output of `Date.toLocaleTimeString()` includes 'GMT+01:00', where the '+' needs to be escaped.
-
Robert Knight authored
* Upgrade Karma from v0.13 -> 1.10 * Upgrade from PhantomJS 1.9.x to latest 2.x This fixes an issue where the gulp process would hang after tests ran when using a current version of Node.
-
Robert Knight authored
Only new top level annotations should be moved to the new group when switching groups. Fixes hypothesis/h#3559
-
Sean Hammond authored
Simplify annotation component by removing duplicated state
-
Robert Knight authored
Remove site scripts and assets
-
- 01 Jul, 2016 11 commits
-
-
Nick Stenning authored
-
Nick Stenning authored
-
Nick Stenning authored
-
Robert Knight authored
The correct fix would be to remove new annotations with an empty draft in the reducer function that handles new annotations being created. That is not currently possible because drafts are not stored in the Redux store. Therefore this commit just manually de-registers the listener when <annotation> goes out of scope.
-
Robert Knight authored
-
Robert Knight authored
The `updateViewModel()` function was responsible for computing several pieces of data (links, document domain and title) used by the annotation template. Since we can now rely on vm.annotation being immutable, we can just compute this data lazily when we need it and use memoization to avoid unnecessary recalculation.
-
Robert Knight authored
Replace `updateDomainModel()` with a simpler function which returns a copy of the input annotation with the changes from the editor applied.
-
Robert Knight authored
These variables duplicated the information from the current draft for an annotation. Instead of restoring a draft when an annotation card is created and saving it when the annotation card is destroyed, just update the draft whenever the tags, text or privacy of the annotation is changed. The text/tags/privacy shown in the card are determined by `vm.state()` which merges the annotation and the draft. Removing these variables lets us also remove or simplify the tests that checked that everything remained in sync.
-
Robert Knight authored
Instead of maintaining a state flag indicating whether an annotation is being viewed, edited or created, derive that state from whether the annotation has an ID and whether it has an unsaved draft or not. In the process this commit simplifies the tests for reverting edits and adds a missing test that the annotation is deleted if new when clicking the Cancel button.
-
Robert Knight authored
As a step towards making <annotation> stateless or nearly-stateless and instead just a display of an annotation derived from the current annotation instance and its draft, remove the `domainModel` copy of `vm.annotation`.
-
Robert Knight authored
Make `gulp watch` build CSS, files and images
-