- 06 Mar, 2020 4 commits
-
-
Robert Knight authored
The adder toolbar used to set the `display` style property on its buttons to resolve an issue with a site that would add `display:none` to them. The linked issue no longer occurs, possibly because the use of Shadow DOM hides the buttons from `document.querySelectorAll(...)`. A timeout that was used to add/remove the `is-active` class from the toolbar appears to be unnecessary. The "grow and fade in" transition when the toolbar is shown works without it.
-
Robert Knight authored
To enable us to take advantage of the UI tooling that we built for the sidebar app in the "annotator" part of the client (eg. components, linting, testing infrastructure), we're going to convert UI components in the "annotator" code over to Preact as well. As a first step, this commit converts the "adder" toolbar that presents the "Annotate" and "Highlight" buttons. - Extract the logic for creating a shadow DOM root for the adder into a separate module (`annotator/util/shadow-root.js`) so we can re-use it for other UI elements in future and remove Shadow DOM v0 support since Shadow DOM v1 has been available for a long time now. - Replace the `adder.html` template file, manual element manipulation and manual event listener setup with an `AdderToolbar` Preact component (`annotator/components/adder-toolbar.js`), which uses the same tooling as components in the sidebar app In this commit the tests for all the pieces of the adder are covered by `adder-test.js`. Future commits will split out tests for the individual pieces.
-
Robert Knight authored
-
Robert Knight authored
Replace two dependencies that are only used once
-
- 05 Mar, 2020 7 commits
-
-
Lyza Gardner authored
Split `loadAnnotationsService` out of `annotationsService`
-
Lyza Danger Gardner authored
The `load` and `searchAndLoad` methods previously within `annotationsService` didn't have a lot of functional or dependency overlap with the other methods in `annotationsService`. Simplify tests and make module responsibilities clearer by splitting this into two, introducing a new `loadAnnotationsService`. Update the `sidebar-content` controller to use `loadAnnotationsService`.
-
Robert Knight authored
Update browser extension after a new prod client release
-
Robert Knight authored
Trigger a build of the "master" branch of the "browser-extension" project after a new client production release with the `BUILD_TYPE` parameter set to `update-hypothesis-client` to trigger an update to the Hypothesis client. In implementing this, I ran into a couple of issues that caught me out initially: - The `build` command must take a job name rather than a project (which is essentially a folder of jobs), ie. `browser-extension/master` rather than `browser-extension`. See [1]. - To pass a value for a choice parameter, the easiest option is just to pass a string [2] [1] https://stackoverflow.com/questions/46471467/ [2] https://stackoverflow.com/a/41760715/434243
-
Robert Knight authored
Since any long-enough random string will do as an ID for the WebSocket client, use the existing `generateHexString` function from `util/random`.
-
Robert Knight authored
In the one place we use it, this can be replaced with a trivial helper.
-
Robert Knight authored
Remove debug code from production build
-
- 04 Mar, 2020 8 commits
-
-
Kyle Keating authored
Refactor fetch-config.js and allow requestConfigFromFrame to be an object
-
Kyle Keating authored
- Rename fetchConfig to fetchConfigLegacy - Allow the requestConfigFromFrame variable from hypothesisConfig to be either a string containing the origin url (legacy), or an object containing the origin url + the ancestor level value of the parent frame. This is used to directly find the frame which to send RPC requests too so we don't have to guess and create erroneous console errors. - Rename fetchConfig to fetchConfigLegacy (now deprecated) - Add fetchConfigRpc to replace fetchConfigLegacy - Add fetchConfigEmbed for the simple hash fragment case - Refactor fetchConfig to decide how it will fetch the host config (one of 3-ways) 1. simple case from url hash fragment 2. legacy RPC call from (depreciated) 3. RPC call directly to parent frame.
-
Lyza Gardner authored
Move `createAnnotation` to a service
-
Lyza Danger Gardner authored
Move `createAnnotation` out of the store thunk and into a service. Add auto-creation of draft for new annotations. Fixes #1834
-
Lyza Gardner authored
AnnotationOmega: Add “Saving…” message
-
Lyza Danger Gardner authored
Re-implement “Saving…” message from legacy `Annotation` template Fixes #1836
-
Robert Knight authored
-
Robert Knight authored
We use this dependency to guard against accidental mutation of objects and arrays in the store. However the production build was including the development version of the library. To simplify things, replace the library with a small utility.
-
- 03 Mar, 2020 11 commits
-
-
Lyza Gardner authored
Make shortcut keys available with `metaKey` as well as `ctrlKey`
-
Lyza Danger Gardner authored
Update keypress handling to recognize `CMD/META+key` as well as `CTRL+key`. Very nice for the Mac users.
-
Robert Knight authored
Change highlight announcement text to "annotation start"
-
Lyza Gardner authored
Add reply and collapsed classnames to `AnnotationOmega`
-
Robert Knight authored
Move last remaining module out of src/sidebar/directive/test
-
Robert Knight authored
Bump fetch-mock from 8.3.2 to 9.0.0
-
Robert Knight authored
Bump terser from 4.6.3 to 4.6.4
-
Robert Knight authored
Bump preact from 10.3.2 to 10.3.3
-
Robert Knight authored
Bump @sentry/browser from 5.12.4 to 5.13.0
-
Robert Knight authored
Bump sass from 1.25.0 to 1.26.2
-
Robert Knight authored
Bump mocha from 7.0.1 to 7.1.0
-
- 02 Mar, 2020 10 commits
-
-
Lyza Danger Gardner authored
Mirror the current implementation in `Annotation` and `AnnotationThread` for applying stateful CSS classes to `AnnotationOmega` elements. This approach should be reviewed after migration is complete. Fixes #1837
-
dependabot-preview[bot] authored
Bumps [@babel/core](https://github.com/babel/babel) from 7.8.4 to 7.8.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](https://github.com/babel/babel/compare/v7.8.4...v7.8.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@babel/preset-env](https://github.com/babel/babel) from 7.8.4 to 7.8.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](https://github.com/babel/babel/compare/v7.8.4...v7.8.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [mocha](https://github.com/mochajs/mocha) from 7.0.1 to 7.1.0. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](https://github.com/mochajs/mocha/compare/v7.0.1...v7.1.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [eslint-plugin-react-hooks](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks) from 2.4.0 to 2.5.0. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/master/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/HEAD/packages/eslint-plugin-react-hooks) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.624.0 to 2.630.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.624.0...v2.630.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [sass](https://github.com/sass/dart-sass) from 1.25.0 to 1.26.2. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md) - [Commits](https://github.com/sass/dart-sass/compare/1.25.0...1.26.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.12.4 to 5.13.0. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/5.12.4...5.13.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [preact](https://github.com/preactjs/preact) from 10.3.2 to 10.3.3. - [Release notes](https://github.com/preactjs/preact/releases) - [Commits](https://github.com/preactjs/preact/compare/10.3.2...10.3.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [terser](https://github.com/terser/terser) from 4.6.3 to 4.6.4. - [Release notes](https://github.com/terser/terser/releases) - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](https://github.com/terser/terser/compare/v4.6.3...v4.6.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-