- 04 Mar, 2020 1 commit
-
-
Kyle Keating authored
- Rename fetchConfig to fetchConfigLegacy - Allow the requestConfigFromFrame variable from hypothesisConfig to be either a string containing the origin url (legacy), or an object containing the origin url + the ancestor level value of the parent frame. This is used to directly find the frame which to send RPC requests too so we don't have to guess and create erroneous console errors. - Rename fetchConfig to fetchConfigLegacy (now deprecated) - Add fetchConfigRpc to replace fetchConfigLegacy - Add fetchConfigEmbed for the simple hash fragment case - Refactor fetchConfig to decide how it will fetch the host config (one of 3-ways) 1. simple case from url hash fragment 2. legacy RPC call from (depreciated) 3. RPC call directly to parent frame.
-
- 27 Feb, 2020 13 commits
-
-
Lyza Gardner authored
Fix page note initial tab selection when there are replies in the mix
-
Robert Knight authored
Remove non-functional `window-scroll` Angular directive
-
Robert Knight authored
The /stream view is supposed to automatically fetch new annotations as you scroll. However this has been broken for a very long time. The code responsible for making this happen relied on `scroll` events on the `window`. However the stream content has for a long time been contained in a scrollable `.app-content-wrapper` container, so no such events were emitted. For the moment, just remove the non-functional code as that gets us a step closer to completing the migration away from Angular.
-
Robert Knight authored
Remove h-branding Angular directive
-
Robert Knight authored
After the previous commit, this is no longer used in the app.
-
Robert Knight authored
-
Robert Knight authored
Fix top bar failing to display in /stream route
-
Robert Knight authored
Remove unused Angular filters and directives
-
Lyza Danger Gardner authored
Before, the page notes tab would not be selected if any of the page notes had replies. Now will correctly auto-select page notes tab if all top-level (i.e. non-reply) annotations are page notes. Also add some rudimentary tests for the `ADD_ANNOTATIONS` reducer in the `selection` store module as none existed. Fixes #1827
-
Robert Knight authored
This broke in dff1f428 because the `$location` Angular service became unavailable to the `StreamSearchInput` component as it was not registered in the new dependency injection container.
-
Robert Knight authored
This used to contain Angular filters. The last references to this were removed in c978b6b2.
-
Robert Knight authored
-
Robert Knight authored
These directives were only used inside components that have now been converted to Preact.
-
- 26 Feb, 2020 10 commits
-
-
Lyza Gardner authored
Add `autosaveService`; save new highlights automatically
-
Lyza Danger Gardner authored
Add a new `autosaveService`, which subscribes to the store and automatically saves new highlights. Remove implementation of highlight auto-save from `Annotation` controller.
-
Robert Knight authored
Fix compatibility of create-github-release.js with @ocktokit/rest v17
-
Robert Knight authored
https://github.com/hypothesis/client/pull/1824 bumped @ocktokit/rest to v17.0.0 but this contained breaking changes which were not accounted for.
-
Robert Knight authored
Remove unused sourcemap upload scripts
-
Robert Knight authored
-
Robert Knight authored
We currently upload sourcemaps to https://cdn.hypothes.is alongside the JS bundles for a particular client release. Sentry will fetch them from the URLs specified by `//# sourceMappingURL` comments in JS bundles without us having to upload the sourcemaps to Sentry directly. We were not running these scripts as part of the current QA/prod release process on Jenkins.
-
Robert Knight authored
Remove mkdirp dependency
-
Robert Knight authored
Stop loading icon font CSS in sidebar app
-
Robert Knight authored
Remove live-reload functionality from dev server
-
- 25 Feb, 2020 7 commits
-
-
Robert Knight authored
Remove autofill-event dependency
-
Robert Knight authored
All uses of the icon font in the sidebar app have now been replaced by `SvgIcon`.
-
Robert Knight authored
The client's dev server had functionality where it could live-update the sidebar app when certain resources (eg. CSS bundles) were changed without requiring a restart of the app. None of the developers were using this functionality, and reloading the app is not especially painful, so remove it to simplify future maintenance.
-
Robert Knight authored
Fix manifest not rebuilding after source file changes
-
Robert Knight authored
Fix an issue where `build/boot.js` and `build/manifest.json` were not rebuilt after script/style bundles were updated or other resources were updated in the `build/` directory. The `updateManifest` gulp task function was not returning a value so gulp silently treated the task as never completing. I thought this generated a warning at some point in the past, but it looks like that was not happening. This fixes an issue in development where `build/boot.js` would sometimes be generated before `build/scripts/boot.bundle.js` had been fully written and then not regenerated after that file was written. This resulted in an empty or incomplete `build/boot.js` file and as a result the dev client would fail to start.
-
Robert Knight authored
This is an Angular/jQuery-specific package which AFAICS is no longer useful for us. Everything component in the sidebar app that displays an input field of some kind is now built with Preact.
-
Robert Knight authored
Remove a dependency that is no longer needed with current versions of Node.
-
- 24 Feb, 2020 9 commits
-
-
Robert Knight authored
Bump sinon from 8.1.1 to 9.0.0
-
dependabot-preview[bot] authored
Bumps [sinon](https://github.com/sinonjs/sinon) from 8.1.1 to 9.0.0. - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md) - [Commits](https://github.com/sinonjs/sinon/compare/v8.1.1...v9.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
Bump @sentry/browser from 5.12.1 to 5.12.4
-
dependabot-preview[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.12.1 to 5.12.4. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/5.12.1...5.12.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 16.43.1 to 17.0.0. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](https://github.com/octokit/rest.js/compare/v16.43.1...v17.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.620.0 to 2.624.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.620.0...v2.624.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Lyza Gardner authored
Make `NewNoteBtn` show login prompt if user not logged in
-
Lyza Danger Gardner authored
Apply the same UX to `NewNoteBtn` as to the annotator for attempting to create new annotations when not logged in. Display login prompt. Also refactor to remove dependency on `$rootScope` and events
-
dependabot-preview[bot] authored
Bumps [eslint-plugin-react-hooks](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks) from 1.7.0 to 2.4.0. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/master/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/HEAD/packages/eslint-plugin-react-hooks) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-