- 21 Nov, 2019 1 commit
-
-
Robert Knight authored
Fix an issue where elements in the annotation body that were styled with margins, such as headings and block quotes, could cause the bottom of an excerpt to cropped. The issue was that margin collapsing [2] caused the margin to "leak" out of the excerpt's content `<div>` and push it vertically away from the outermost element of the excerpt. The `max-height` applied to the outermost element took into account the content's _height_ but not its vertical offset. The fix here is to make the excerpt content div a new block-formatting context [1] which ensures that any margins on elements inside the content are placed _inside_ the content element. There are various ways of doing this, but `display: inline-block` is backwards compatible down to IE 11. - Fix margin collapsing issue by making content a new block formatting context - Remove unused `excerpt__container` class and an incorrect comment about the excerpt class - Remove an unnecessary `test-name` attribute on the content element and use the class name to find it in tests instead - Add a note about some refactoring that can be done post SASS-module adoption [1] https://developer.mozilla.org/en-US/docs/Web/Guide/CSS/Block_formatting_context [2] https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_Box_Model/Mastering_margin_collapsing Fixes #1518
-
- 20 Nov, 2019 14 commits
-
-
Lyza Gardner authored
Factor out some reusable CSS into mixins
-
Lyza Danger Gardner authored
Extract some reusable button styles, as well as some patterns for lists of linked icons and a "panel" pattern. It is likely organization of this will evolve as a pattern-library approach is implemented, but this avoids copy-pasta and tightens up consistency between uses.
-
dependabot-preview[bot] authored
-
dependabot-preview[bot] authored
Bumps [angular](https://github.com/angular/angular.js) from 1.7.8 to 1.7.9. **This update includes a security fix.** - [Release notes](https://github.com/angular/angular.js/releases) - [Changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md) - [Commits](https://github.com/angular/angular.js/compare/v1.7.8...v1.7.9) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
Revert "Update core-js to current version"
-
Robert Knight authored
-
Lyza Gardner authored
Remove unused form and button classes
-
Lyza Gardner authored
Remove deprecated SCSS `$brand-color` color variable
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
Use `$brand` instead, which has the identical value
-
Robert Knight authored
Update core-js to current version
-
Robert Knight authored
Improve mobile UX of markdown editor and search input
-
Robert Knight authored
Convert excerpt to Preact (2/n)
-
Robert Knight authored
The prop name `overflowHysteresis` was frequently typo-d and is also misleading as the excerpt doesn't remember the history of the overflow value, it just uses it as a fixed threshold. Rename it to `overflowThreshold` instead. Also improve / simplify a few JSDoc comments per PR feedback.
-
- 19 Nov, 2019 15 commits
-
-
Kyle Keating authored
Warn in JSON-RPC server if message is dropped by origin filter
-
Lyza Gardner authored
Remove (some) deprecated SCSS color variables
-
Lyza Danger Gardner authored
`$color-cardinal` and `$gray-lightest` have no references in existing SCSS
-
Lyza Danger Gardner authored
Also remove now-unused utility class for cancel buttons—this pattern is only used in one place and may be on the way out in general.
-
Lyza Danger Gardner authored
Sub with `$grey-4`, which is identical (`#a6a6a6`). Part of consolidating CSS colors.
-
Lyza Danger Gardner authored
Sub with `$grey-1`, which is virtually identical (`$color-seashell` was `#f1f1f1`, `$grey-1` is `#f2f2f2`. Part of consolidating CSS colors.
-
Robert Knight authored
-
Robert Knight authored
- Use `is` prefix for boolean vars consistently - Note that the inline controls are optional - Clarify units of numeric props - Use parens to clarify precedence in a couple of expressions. This required overruling Prettier's formatting of these.
-
Robert Knight authored
-
Robert Knight authored
Convert the `Excerpt` component to Preact. Rather than convert the existing implementation verbatim, this is a completely new implementation which should be easier to understand and use. Instead of requiring callers to provide an input property which represents the displayed data, which triggers a re-measurement if it changes, the new implementation observes the DOM directly for size changes. This component renders caller-provided content (ie. it accepts a `children` prop), which is not supported by the Preact <-> Angular bridge. Therefore it was also necessary to create components (`AnnotationBody`, `AnnotationQuote`) that encapsulate uses of `Excerpt` inside the `<annotation>` component. - Add `observe-element-size` utility module to watch for changes in the size of a DOM node using APIs available in the current browser - Add new `Excerpt` implementation and remove the old one - Remove `excerpt-overflow-monitor` utility that is not used by the new implementation - Add `AnnotationBody` component to render an annotation's markup body inside a (new) excerpt and convert the Angular template for `<annotation>` (annotation.html) to use it. - Add `AnnotationQuote` component to render an annotation's quote inside an excerpt and convert `annotation.html` to use it
-
Robert Knight authored
Convert excerpt to Preact (1/n) - Add a utility to observe element size changes
-
Robert Knight authored
Address some confusion I encountered while testing https://github.com/hypothesis/lms/pull/1157/ where JSON-RPC messages from the lms app to the client would be silently dropped if the `rpcAllowedOrigins` config was not set correctly. Log a console warning when this happens to make the problem more obvious. Before warning though, filter out non JSON-RPC messages because there are various other sources of "message" events which the client is likely to receive and which we don't want to result in warning spam.
-
Robert Knight authored
- Set an `action` on the form so that the virtual keyboard shows a submit button, which makes it easier to trigger a search - Use a larger font size for readability and to prevent iOS from zooming into the field on desktop websites
-
Robert Knight authored
- Increase the font size of the input field to make the text easier to read, and more importantly, stop iOS from zooming into the text field on mobile-optimized sites (ie. those with `<meta name="viewport" content="width=device-width, initial-scale=1">` in the host page) - Make the toolbar buttons bigger when using touch input and add space below the toolbar so that the browser can differentiate taps on the buttons from taps on text selection handles - Prevent toolbar overflowing annotation card on small screens. We use either horizontal scrolling or wrapping depending on the input mode (touch/non-touch). Scrolling saves vertical space, but could be inconvenient to use with a mouse or touchpad. fixup! - Update comments
-
Robert Knight authored
Show focus ring on annotator toolbar buttons when using keyboard focus
-
- 18 Nov, 2019 10 commits
-
-
Robert Knight authored
[Security] Bump https-proxy-agent from 2.2.2 to 2.2.4
-
Robert Knight authored
Reduce test startup time when running a subset of tests
-
dependabot-preview[bot] authored
Bumps [https-proxy-agent](https://github.com/TooTallNate/node-https-proxy-agent) from 2.2.2 to 2.2.4. **This update includes security fixes.** - [Release notes](https://github.com/TooTallNate/node-https-proxy-agent/releases) - [Commits](https://github.com/TooTallNate/node-https-proxy-agent/compare/2.2.2...2.2.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
This package provides polyfills for new ES/DOM APIs for use in IE 11. This was held back to a v2.x version due to a conflict with fetch-mock that is now resolved.
-
Robert Knight authored
Bump fetch-mock from 6.5.2 to 8.0.0
-
Robert Knight authored
The entry point for fetch-mock v8 is an ES module which Browserify does not support natively. Therefore use the CommonJS entry point as described at http://www.wheresrhys.co.uk/fetch-mock/#usageimporting.
-
dependabot-preview[bot] authored
-
Robert Knight authored
Bump npm-packlist from 1.4.6 to 2.0.1
-
Robert Knight authored
Bump @sentry/browser from 5.7.1 to 5.9.0
-
Robert Knight authored
Bump sass from 1.23.3 to 1.23.6
-