1. 22 Sep, 2015 2 commits
    • Nick Stenning's avatar
      Fix detection of PDF URIs · 84867512
      Nick Stenning authored
      70c9b9b broke a number of features of the h client that were toggled on
      for PDF documents, by renaming the Annotator PDF plugin from
      `Annotator.Plugin.PDF` to `Annotator.Plugin.Pdf`.
      
      While it's certainly an ugly side-effect of a straightforward rename,
      the problem is that `Guest#getDocumentInfo` (to pick one example) used
      `@plugins.PDF?` to determine whether to use the PDF metadata
      (provided by the PDF.js `PDFViewerApplication`).
      
      In the absence of PDF metadata, `getDocumentInfo` falls back to using
      `window.location.href`, which explains the behaviour identified
      in #2506.
      
      Fixes #2506.
      84867512
    • Nick Stenning's avatar
      Merge pull request #2518 from robertknight/karma-watch-target · 87665a80
      Nick Stenning authored
      Add make target to run karma tests with auto-watch enabled
      87665a80
  2. 21 Sep, 2015 6 commits
  3. 18 Sep, 2015 1 commit
    • Randall Leeds's avatar
      Clean up socket, threading, mapper with routing · d99347a1
      Randall Leeds authored
      Move all the logic required to set up a clean environment for the
      client views into the dependency resolution mechanism of ngRoute.
      
      The annotation mapper gains an unloadAnnotations method to make the
      isolated code cleaner.
      
      Use angular-websocket to remove the need for our own socket class.
      
      The AppController becomes much more sane.
      d99347a1
  4. 17 Sep, 2015 4 commits
  5. 16 Sep, 2015 1 commit
  6. 15 Sep, 2015 8 commits
  7. 12 Sep, 2015 3 commits
  8. 11 Sep, 2015 4 commits
    • Randall Leeds's avatar
      Simplify the visible highlights state sync · d38b463d
      Randall Leeds authored
      Let each frame just emit the event locally and invoke its own local
      method in response to the RPC call. The widget, acting as the hub
      of the communication bridge, stops infinite RPC loop by only
      propagating the call when it would change the state.
      d38b463d
    • Randall Leeds's avatar
      Merge pull request #2487 from hypothesis/publish-to-a-group · 890447d8
      Randall Leeds authored
      Publish to a group
      890447d8
    • Sean Hammond's avatar
      Rename hashid -> id on the client-side · 8bc602cc
      Sean Hammond authored
      8bc602cc
    • Sean Hammond's avatar
      Enable publishing annotations to a group · 95512b68
      Sean Hammond authored
      Features
      ========
      
      1. If you have a group selected in the groups dropdown when you create
         an annotation, the annotation will be created in that group.
      
      2. Only users who are members of the group can see the group's
         annotations.
      
      3. An annotation can be separately set to public or private, whether it
         is in a group or not, using the separate visibility dropdown on the
         annotation card when creating or editing an annotation.
      
         Private means viewable by the user only, public means viewable by the
         group or by everyone if the annotation has no group. When in a group
         the group's name appears instead of "Public" in the user interface
         (and with a group icon instead of the public icon). So for example if
         I make an annotation in group Foobar I can set its visibility to Only
         Me or to Foobar.
      
      4. New icons and styles for all the group-related parts of the UI,
         should look the same as in Jake's mockups now.
      
      Implementation Notes
      ====================
      
      Auth
      ----
      
      - We add `"group:<hashid>"` principals to `request.effective_principals`
        for each group the user is a member of.
      
      - The existing `"group:admin"` and `"group:staff"` principals are
        renamed to `"group:__admin__"` and `"group:__staff__"` so that they
        never clash with group hashids (hashids never contain _'s).
      
      - A user may only create an annotation in group "x" if they are
        themselves a member of group "x". This is enforced by an ACL
        in `h.api.resources`.
      
      - Users may only view annotations in groups of which they are members.
        This is enforced by a query filter in search: `h.api.groups.search`.
      
      - In `h.api.groups.logic`: A reply's group is always set to that of its
        parent, server-side. It doesn't matter what the client sends.
      
      Search Filtering
      ----------------
      
      - Whether an annotation belongs to a group is recorded in a top-level
        `group` field in the annotation. The value of this field is the
        group's hashid.
      
        For example, it is currently possible to have a private annotation
        (visible only to the user who created it) within a group. This allows
        users to use the privacy controls for "drafting" group annotations and
        replies, only sharing them with the group when they're ready. It also
        allows users to keep private replies to group annotations.
      
        When the sidebar is focused on a group (not yet implemented), the
        search will filter the annotations to those that have the group's
        hashid in the group field, regardless of whether the annotation's
        permissions are private to the user or shared with the group.
      
      - The groups search filtering (`h.api.groups.search`) uses the top-level
        groups field to filter out annotations that belong to groups that the
        user isn't a member of.
      
      - Annotations that are public simply have a group field containing
        `__world__`.
      
      Client-Side
      -----------
      
      - `annotation.coffee` sets the group field on the annotation before
        saving it.
      
      - There's a new group-list-controller to handle the now more interactive
        groups dropdown.
      
      - And a group-service to share state about which group is currently
        focused with different parts of the code.
      
      Misc
      ----
      
      - `h.streamer`: Infinite scroll and live updates filter out annotations
        from groups the user isn't a member of, as well.
      
      - `h.api.search.transform`: the API adds group: '__world__' to any
        annotations without a group field before returning them to the
        client.
      95512b68
  9. 10 Sep, 2015 2 commits
  10. 29 Aug, 2015 1 commit
  11. 28 Aug, 2015 3 commits
  12. 25 Aug, 2015 5 commits