Skip to content

C
coopwire-hypothesis
Switch branch/tag
  1. 04 Sep, 2024 2 commits
    • Robert Knight's avatar
      Make HTML side-by-side tests tolerate more variation in window size · 88aee9d7
      Robert Knight authored 
      The tests previously assumed a window width of 800px. This changed recently and
in Chrome 130, is 1200px. Revise two tests that were failing locally to tolerate
more variation in the window size.
      88aee9d7
    • Robert Knight's avatar
      Relax call count check in `FrameObserver` tests · eeba7ec5
      Robert Knight authored 
      An `onDocumentReady` test was failing in current versions of Chrome, with the
callback being invoked twice with the same error instead of once. This can happen
with this sequence of events:

 1. Watched frame fires an "unload" event. This starts a polling timer.
 2. The timer fires and the callback is invoked with a cross-origin error
 3. Frame fires "load" event, and the callback is invoked a second time with
    a cross-origin error
 4. The test's "load" event handler is run

It is not a problem for current callers of `onDocumentReady` if the callback
fires twice, so just relax the check in the tests.
      eeba7ec5
  3. 02 Sep, 2024 1 commit
  5. 28 Aug, 2024 1 commit
  7. 26 Aug, 2024 4 commits
  9. 22 Aug, 2024 1 commit
  11. 21 Aug, 2024 1 commit
    • Robert Knight's avatar
      Fix failure to fetch groups in VitalSource · ab548854
      Robert Knight authored 
      Before loading groups the client waits for the main document frame to connect in
order to be able to fetch groups associated with that frame's URL. In
VitalSource however there is no "main frame", only the current content frame, so
`GroupsService._loadGroupsForUserAndDocument` waited indefinitely.

This failure to fetch groups did not happen on the initial launch due to a
different bug in `GroupsService._loadGroupsForUserAndDocument`. The
`this_store.route()` call returned `null` during startup and hence the code did
not wait for the main frame to connect. After a subsequent login/logout however,
the `route` call returned "sidebar" and the code did wait for the main frame.

This problem also did not happen in the LMS environment because there the client
loads a set of groups specified by our LMS app, instead of fetching groups based
on the logged-in user and current document.

Solve the first problem by using the `defaultContentFrame` method to get the
frame instead of `mainFrame`. `defaultContentFrame` returns the main frame if
there is one, or the first content frame that connected otherwise.
      ab548854
  13. 20 Aug, 2024 1 commit
  15. 19 Aug, 2024 7 commits
  17. 12 Aug, 2024 8 commits
  19. 05 Aug, 2024 8 commits
  21. 29 Jul, 2024 6 commits