- 07 Feb, 2020 4 commits
-
-
Robert Knight authored
Previously a heuristic based on function naming was used to determine whether `Injector` should construct objects with `new` or not. This is brittle because compiler transforms may alter function names (eg. terser removes them by default). This commit re-works the API so that the caller explicitly indicates how the object should be created (the "provider" to use). As a convenience if a function is passed it is assumed to be a class. ``` // Register a class. register("anObject", SomeClass); register("anObject", { class: SomeClass }); // Register a factory. register("anObject", { factory: makeMeAnObject }); // Register a plain value. register("anObject", { value: "foobar" }); ```
-
Robert Knight authored
This reverts commit ec63961a, reversing changes made to e0f8835c.
-
Lyza Gardner authored
Rename `annotations` -> `annotationsService` (establish service-naming pattern)
-
Lyza Danger Gardner authored
-
- 06 Feb, 2020 6 commits
-
-
Robert Knight authored
Revert "Implement container to replace AngularJS's dependency injector for services"
-
Robert Knight authored
-
Robert Knight authored
Implement container to replace AngularJS's dependency injector for services
-
Robert Knight authored
-
Robert Knight authored
As a step in the migration away from Angular, use the local dependency injector implementation to replace Angular's injection system in the creation of service objects. The constructed services are still registered with Angular for use by Angular components which depend upon them. Once all Angular components have been migrated, and uses of built-in Angular services (`$rootScope`) have been replaced, this step can be removed. The `viewFilter` function was renamed to `ViewFilter` because it relies on access to `this` and the new injector detects whether a function is a class or not based on the capitalization of the name.
-
Robert Knight authored
Implement a dependency injection / Inversion of Control container that can be used to replace Angular's dependency injection.
-
- 05 Feb, 2020 2 commits
-
-
Kyle Keating authored
Improve a11y lint
-
Kyle Keating authored
- Remove unused `onClick` handler from <ul> this was redundant due to `onOpenChanged` prop and caused a lint issue. Note: there were also no previous test for this click handler in group-list-item-test.js - Add alt attribute to <img> in group-list if there is an org name, otherwise its a decorative empty string
-
- 04 Feb, 2020 6 commits
-
-
Robert Knight authored
Build CSS bundles before running Karma
-
Robert Knight authored
This is important for a11y tests which rely on having styles present. This takes about ~1.2s on my machine currently. We can reclaim that time in future by adding some caching to speed up the JS bundle build.
-
Robert Knight authored
Bump karma-browserify from 6.1.0 to 7.0.0
-
Robert Knight authored
Bump codecov from 3.6.2 to 3.6.4
-
Robert Knight authored
Bump @sentry/browser from 5.11.1 to 5.11.2
-
dependabot-preview[bot] authored
Bumps [codecov](https://github.com/codecov/codecov-node) from 3.6.2 to 3.6.4. - [Release notes](https://github.com/codecov/codecov-node/releases) - [Commits](https://github.com/codecov/codecov-node/compare/v3.6.2...v3.6.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
- 03 Feb, 2020 19 commits
-
-
Kyle Keating authored
Improve a11y testing for AutocompleteList and TagEditor
-
Kyle Keating authored
- TagEditor test renders full AutocompleteList for end to end a11y test - AutocompleteList now uses a `is-hidden` class rather than preact to hide itself. This was necessary to pass a11y lint. - Change TagEditor to unset the activeIndex when adding tag - Add `aria-label` to TagEditor <input> filed, `placeholder` attr not sufficient for lint - Very slight color adjust on $grey-5 to keep 4.5:1 contrast spec
-
Robert Knight authored
Move component test utilities to src/test-util/
-
Robert Knight authored
Bump commander from 4.1.0 to 4.1.1
-
Robert Knight authored
Bump puppeteer from 2.0.0 to 2.1.0
-
dependabot-preview[bot] authored
-
dependabot-preview[bot] authored
-
dependabot-preview[bot] authored
-
dependabot-preview[bot] authored
-
dependabot-preview[bot] authored
Merge pull request #1744 from hypothesis/dependabot/npm_and_yarn/babel-plugin-mockable-imports-1.7.0
-
dependabot-preview[bot] authored
Bumps [@babel/core](https://github.com/babel/babel) from 7.8.3 to 7.8.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](https://github.com/babel/babel/compare/v7.8.3...v7.8.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@babel/preset-env](https://github.com/babel/babel) from 7.8.3 to 7.8.4. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](https://github.com/babel/babel/compare/v7.8.3...v7.8.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.11.1 to 5.11.2. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/5.11.1...5.11.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [karma-browserify](https://github.com/nikku/karma-browserify) from 6.1.0 to 7.0.0. - [Release notes](https://github.com/nikku/karma-browserify/releases) - [Commits](https://github.com/nikku/karma-browserify/compare/v6.1.0...v7.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 16.38.3 to 16.43.0. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](https://github.com/octokit/rest.js/compare/v16.38.3...v16.43.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [babel-plugin-mockable-imports](https://github.com/robertknight/babel-plugin-mockable-imports) from 1.6.0 to 1.7.0. - [Release notes](https://github.com/robertknight/babel-plugin-mockable-imports/releases) - [Changelog](https://github.com/robertknight/babel-plugin-mockable-imports/blob/master/CHANGELOG.md) - [Commits](https://github.com/robertknight/babel-plugin-mockable-imports/compare/v1.6.0...v1.7.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [dompurify](https://github.com/cure53/DOMPurify) from 2.0.7 to 2.0.8. - [Release notes](https://github.com/cure53/DOMPurify/releases) - [Commits](https://github.com/cure53/DOMPurify/compare/2.0.7...2.0.8) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 2.0.0 to 2.1.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Commits](https://github.com/puppeteer/puppeteer/compare/v2.0.0...v2.1.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [commander](https://github.com/tj/commander.js) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/tj/commander.js/releases) - [Changelog](https://github.com/tj/commander.js/blob/master/CHANGELOG.md) - [Commits](https://github.com/tj/commander.js/compare/v4.1.0...v4.1.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
- 31 Jan, 2020 2 commits
-
-
Kyle Keating authored
Chrome extension did not upload correctly, bumping version to repeat the travis build
-
Robert Knight authored
Improve organizational clarity by separating tests from utility modules used in tests, and also pave the way for re-using these utilities for UI outside the sidebar app in future (eg. src/annotator/).
-
- 30 Jan, 2020 1 commit
-
-
Kyle Keating authored
Improved tag editor (Part 2/2)
-