1. 31 Jan, 2020 1 commit
    • Robert Knight's avatar
      Move component test utilities to src/test-util/ · 971df23e
      Robert Knight authored
      Improve organizational clarity by separating tests from utility modules
      used in tests, and also pave the way for re-using these utilities for UI
      outside the sidebar app in future (eg. src/annotator/).
      971df23e
  2. 30 Jan, 2020 6 commits
  3. 29 Jan, 2020 3 commits
  4. 28 Jan, 2020 6 commits
  5. 27 Jan, 2020 19 commits
  6. 24 Jan, 2020 4 commits
    • Kyle Keating's avatar
      Merge pull request #1711 from hypothesis/menu-focus-fix · 2c9bf069
      Kyle Keating authored
      Fix Menu tab focus on keyboard navigation
      2c9bf069
    • Kyle Keating's avatar
      Fix <Menu> tab focus on keyboard navigation · 75ed100f
      Kyle Keating authored
      The Publish Annotation popup menu button was not showing a focus halo on keyboard navigation.  This was due to the child content of the button.menu__toggle having position:absolute elements and so that was not providing a width or height directly on the focusable button.
      
      Removing the absolute styling and instead using a flex layout remedies this, but there also needs to be a block display applied to the button.toggle_menu element so can be treated as a flex item, rather than flex container, with a height of 100% to match the size of its parent “.menu”.  In order to ensure everything still laid out the same, namely the {label} and {menuIndicator}, a pseudo flex container “.menu__toggle-wrapper” needed to be added.
      
      Additionally, the triangle content is moved from DOM to css so it is not read out by screen readers.
      75ed100f
    • Lyza Gardner's avatar
      Merge pull request #1709 from hypothesis/update-publish-control · 7dca1629
      Lyza Gardner authored
      Move more annotation-related state logic into sub-components, store
      7dca1629
    • Lyza Danger Gardner's avatar
      Add temporary logic to instantiate a draft for new annotations · 26b8192a
      Lyza Danger Gardner authored
      Add a temporary bit of logic to instantiate drafts of new (non-highlight)
      annotations. Also add a wrapper div to `AnnotationPublishControl` for
      better layout.
      26b8192a
  7. 23 Jan, 2020 1 commit