- 31 Jan, 2020 1 commit
-
-
Robert Knight authored
Improve organizational clarity by separating tests from utility modules used in tests, and also pave the way for re-using these utilities for UI outside the sidebar app in future (eg. src/annotator/).
-
- 30 Jan, 2020 6 commits
-
-
Kyle Keating authored
Improved tag editor (Part 2/2)
-
Kyle Keating authored
- Fix add new tag bug in Edge - Remove tag-editor’s Chrome hack fix to limit suggestions to 20 - Add ARIA 1.1 Combobox a11y model to TagEditor
-
Robert Knight authored
Add accessibility unit test using axe-core
-
Robert Knight authored
"default" is the default name for an a11y scenario unless one is specified.
-
Robert Knight authored
Remove the global react/display-name lint suppression for the src/sidebar/components/test directory with individual line-level suppressions. The reason for having a global rule wasn't obvious when looking at .eslintrc and there aren't that many occurrences.
-
Robert Knight authored
Improve handling of text in RTL languages
-
- 29 Jan, 2020 3 commits
-
-
Kyle Keating authored
-
Robert Knight authored
-
Robert Knight authored
This enables axe-core tests which depend on CSS rules being available to work, such as checking that elements have sufficient color contrast.
-
- 28 Jan, 2020 6 commits
-
-
Robert Knight authored
Remove obsolete references to shallow rendering
-
Robert Knight authored
`checkAccessibility` calls often violate this rule because the `content` key is assigned a function which returns an element, but is not actually a component.
-
Kyle Keating authored
Add Datalist component (Part 1/2)
-
Kyle Keating authored
- Use as a replacement for the native <datalist> tag - Fix UI differences between Chrome, FF, Safari and Edge with respect to the <datalist> - Fix performance issues experienced in Chrome when used with <datalist> - Allow for future enhanced customization of list including substring highlighting that <datalist> could not do
-
Robert Knight authored
Add infrastructure for running a11y tests using axe-core and add an initial set of tests for existing components. A small number of components (3) fail these checks. These tests have been temporarily skipped so that we can incrementally fix them later. One trivial issue with an un-labeled link in `LoggedOutMessage` was fixed by adding a `title` attribute.
-
Robert Knight authored
We replaced use of Enzyme's shallow rendering for component unit tests some time ago in https://github.com/hypothesis/client/pull/1470.
-
- 27 Jan, 2020 19 commits
-
-
Robert Knight authored
Add eslint-plugin-jsx-a11y to the lint configuration
-
Robert Knight authored
Bump cross-env from 6.0.3 to 7.0.0
-
Robert Knight authored
Bump fetch-mock from 8.3.1 to 8.3.2
-
Robert Knight authored
Bump sinon from 8.1.0 to 8.1.1
-
Robert Knight authored
This helps detect accessibility errors in markup as part of `make lint`. Flag the current set of known errors with a `FIXME-A11Y` comment and suppress them temporarily, so that we can fix them incrementally while guarding against new errors. Part of #1727
-
Robert Knight authored
Bump codecov from 3.6.1 to 3.6.2
-
Robert Knight authored
Bump mocha from 7.0.0 to 7.0.1
-
Robert Knight authored
Bump autoprefixer from 9.7.3 to 9.7.4
-
dependabot-preview[bot] authored
Bumps [autoprefixer](https://github.com/postcss/autoprefixer) from 9.7.3 to 9.7.4. - [Release notes](https://github.com/postcss/autoprefixer/releases) - [Changelog](https://github.com/postcss/autoprefixer/blob/master/CHANGELOG.md) - [Commits](https://github.com/postcss/autoprefixer/compare/9.7.3...9.7.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
-
dependabot-preview[bot] authored
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.606.0 to 2.610.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.606.0...v2.610.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 16.36.0 to 16.38.3. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](https://github.com/octokit/rest.js/compare/v16.36.0...v16.38.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [mocha](https://github.com/mochajs/mocha) from 7.0.0 to 7.0.1. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](https://github.com/mochajs/mocha/compare/v7.0.0...v7.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [cross-env](https://github.com/kentcdodds/cross-env) from 6.0.3 to 7.0.0. - [Release notes](https://github.com/kentcdodds/cross-env/releases) - [Changelog](https://github.com/kentcdodds/cross-env/blob/master/CHANGELOG.md) - [Commits](https://github.com/kentcdodds/cross-env/compare/v6.0.3...v7.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [codecov](https://github.com/codecov/codecov-node) from 3.6.1 to 3.6.2. - [Release notes](https://github.com/codecov/codecov-node/releases) - [Commits](https://github.com/codecov/codecov-node/compare/v3.6.1...v3.6.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [sinon](https://github.com/sinonjs/sinon) from 8.1.0 to 8.1.1. - [Release notes](https://github.com/sinonjs/sinon/releases) - [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md) - [Commits](https://github.com/sinonjs/sinon/compare/v8.1.0...v8.1.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [fetch-mock](https://github.com/wheresrhys/fetch-mock) from 8.3.1 to 8.3.2. - [Release notes](https://github.com/wheresrhys/fetch-mock/releases) - [Commits](https://github.com/wheresrhys/fetch-mock/compare/v8.3.1...v8.3.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
Robert Knight authored
Improve display of user-controlled text in Right-To-Left (RTL) languages by applying the `dir="auto"` attribute to: - Input fields (annotation body editor, search bar) - The rendered annotation body's container element - The rendered annotation quote (ie. the `<blockquote>` element) This will cause these elements to switch to their "base" direction for text layout [1] to RTL or LTR automatically depending on the content [2]. Fixes https://github.com/hypothesis/lms/issues/1372 [1] https://www.w3.org/International/articles/inline-bidi-markup/uba-basics [2] https://www.w3.org/International/questions/qa-html-dir
-
- 24 Jan, 2020 4 commits
-
-
Kyle Keating authored
Fix Menu tab focus on keyboard navigation
-
Kyle Keating authored
The Publish Annotation popup menu button was not showing a focus halo on keyboard navigation. This was due to the child content of the button.menu__toggle having position:absolute elements and so that was not providing a width or height directly on the focusable button. Removing the absolute styling and instead using a flex layout remedies this, but there also needs to be a block display applied to the button.toggle_menu element so can be treated as a flex item, rather than flex container, with a height of 100% to match the size of its parent “.menu”. In order to ensure everything still laid out the same, namely the {label} and {menuIndicator}, a pseudo flex container “.menu__toggle-wrapper” needed to be added. Additionally, the triangle content is moved from DOM to css so it is not read out by screen readers.
-
Lyza Gardner authored
Move more annotation-related state logic into sub-components, store
-
Lyza Danger Gardner authored
Add a temporary bit of logic to instantiate drafts of new (non-highlight) annotations. Also add a wrapper div to `AnnotationPublishControl` for better layout.
-
- 23 Jan, 2020 1 commit
-
-
Lyza Danger Gardner authored
Update `AnnotationThread` to render EITHER `Annotation` or `AnnotationOmega` based on feature-flag setting, not both at the same time. This avoids potential state contention between the two components.
-