- 10 Apr, 2019 6 commits
-
-
Hannah Stepanek authored
-
Hannah Stepanek authored
-
Hannah Stepanek authored
-
Hannah Stepanek authored
-
Hannah Stepanek authored
-
Robert Knight authored
Fix feature flag race condition
-
- 09 Apr, 2019 23 commits
-
-
Hannah Stepanek authored
Previously, a test that should have failed passed when uri=null, because none of the test groups had uri patterns to check against. Make the test groups more realistic by adding in the scopes attribute for at least one of them.
-
Hannah Stepanek authored
In cases like: https://hypothes.is/a/rGSnNwCKSuiG3VT__k3VvA where the sidebar is not being used, the document uri is set to null in the groups service and passed to the combineGroups function. This means that the isScopedToUri logic must handle the case where uri=null.
-
Hannah Stepanek authored
-
Hannah Stepanek authored
Since the feature flag isn't available until the profile api request completes, and the profile api request is run asynchronously with the group api requests, it doesn't make sense to load conditionaly. Instead, call all the group api requests and filter the groups for the old groups menu later. In this case, filtering is done in the groups.all conditionally based on the feature flag.
-
Hannah Stepanek authored
Since the isScopedToUri is no longer dependent on scope enforcement and scope enforcement is now taken into account as part of whether a group is selectable or not, disableOosGroupSelection is no longer necessary. Group selection can be determined purely from isScopedToUri and scopes.enforced.
-
Hannah Stepanek authored
Previously, if the scope was not enforced, isScopedToUri would always return true. Now, isScopedToUri is true only when the scopes.uri_patterns match.
-
Hannah Stepanek authored
getInScopeGroups returns the list of groups for the old groups menu. Aka: only groups that are in scope are returned.
-
Hannah Stepanek authored
Revert "Remove feature flag from group service"
-
Hannah Stepanek authored
-
Hannah Stepanek authored
Remove feature flag from group service
-
Robert Knight authored
Convert `<svg-icon>` component to React
-
Robert Knight authored
-
Robert Knight authored
Merge pull request #1055 from hypothesis/dependabot/npm_and_yarn/babel-plugin-transform-async-to-promises-0.8.9 Bump babel-plugin-transform-async-to-promises from 0.8.8 to 0.8.9
-
Robert Knight authored
Bump mocha from 6.1.1 to 6.1.2
-
Robert Knight authored
Bump enzyme-adapter-preact-pure from 1.10.3 to 1.10.4
-
dependabot[bot] authored
Bumps [babel-plugin-transform-async-to-promises](https://github.com/rpetrich/babel-plugin-transform-async-to-promises) from 0.8.8 to 0.8.9. - [Release notes](https://github.com/rpetrich/babel-plugin-transform-async-to-promises/releases) - [Commits](https://github.com/rpetrich/babel-plugin-transform-async-to-promises/compare/v0.8.8...v0.8.9) Signed-off-by: dependabot[bot] <support@dependabot.com>
-
dependabot[bot] authored
Bumps [mocha](https://github.com/mochajs/mocha) from 6.1.1 to 6.1.2. - [Release notes](https://github.com/mochajs/mocha/releases) - [Changelog](https://github.com/mochajs/mocha/blob/master/CHANGELOG.md) - [Commits](https://github.com/mochajs/mocha/compare/v6.1.1...v6.1.2) Signed-off-by: dependabot[bot] <support@dependabot.com>
-
dependabot[bot] authored
Bumps [enzyme-adapter-preact-pure](https://github.com/robertknight/enzyme-adapter-preact-pure) from 1.10.3 to 1.10.4. - [Release notes](https://github.com/robertknight/enzyme-adapter-preact-pure/releases) - [Changelog](https://github.com/robertknight/enzyme-adapter-preact-pure/blob/master/CHANGELOG.md) - [Commits](https://github.com/robertknight/enzyme-adapter-preact-pure/commits) Signed-off-by: dependabot[bot] <support@dependabot.com>
-
Hannah Stepanek authored
-
Hannah Stepanek authored
Previously, isScopedToUri took into account enforcement but now it does not. Thus, isSelectable logic based on scopes.enforced and isScopedToUri was added to the group-list-section controller to determine whether a group should be out of scope/not selectable.
-
Hannah Stepanek authored
Since the feature flag isn't available until the profile api request completes, and the profile api request is run asynchronously with the group api requests, it doesn't make sense to load conditionaly. Instead, call all the group api requests and filter the groups for the old groups menu later. In this case, filtering is done in the groups.all conditionally based on the feature flag.
-
Hannah Stepanek authored
Previously, if the scope was not enforced, isScopedToUri would always return true. Now, isScopedToUri is true only when the scopes.uri_patterns match.
-
Hannah Stepanek authored
getInScopeGroups returns the list of groups for the old groups menu. Aka: only groups that are in scope are returned.
-
- 08 Apr, 2019 11 commits
-
-
Robert Knight authored
Convert `<annotation-action-button>` component to React
-
Sean Hammond authored
Bump @babel/preset-env from 7.4.2 to 7.4.3
-
dependabot[bot] authored
Bumps [@babel/preset-env](https://github.com/babel/babel) from 7.4.2 to 7.4.3. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](https://github.com/babel/babel/compare/v7.4.2...v7.4.3) Signed-off-by: dependabot[bot] <support@dependabot.com>
-
Sean Hammond authored
Bump @octokit/rest from 16.22.0 to 16.23.2
-
Sean Hammond authored
Bump @babel/core from 7.4.0 to 7.4.3
-
Sean Hammond authored
Bump enzyme-adapter-preact-pure from 1.10.2 to 1.10.3
-
Sean Hammond authored
Bump preact from 10.0.0-alpha.2 to 10.0.0-alpha.4
-
Sean Hammond authored
Bump codecov from 3.2.0 to 3.3.0
-
Sean Hammond authored
Bump mocha from 6.0.2 to 6.1.1
-
Sean Hammond authored
Bump commander from 2.19.0 to 2.20.0
-
Sean Hammond authored
Bump autoprefixer from 9.5.0 to 9.5.1
-