1. 09 Mar, 2021 2 commits
  2. 08 Mar, 2021 22 commits
  3. 05 Mar, 2021 9 commits
    • Lyza Danger Gardner's avatar
      9cb70c87
    • Lyza Danger Gardner's avatar
      Make links to annotation documents open in new tab/window · 37803f91
      Lyza Danger Gardner authored
      Open links to documents in a new tab. This is important in the Notebook
      view at present to "escape" the Notebook's frame, but makes sense in
      all contexts as it more closely adheres to our pattern of opening links
      to external properties in new windows.
      37803f91
    • Lyza Danger Gardner's avatar
      Adjust styling on document metadata · 76d03be3
      Lyza Danger Gardner authored
      Make sure document titles that are not linked don't look like links.
      76d03be3
    • Lyza Danger Gardner's avatar
      Simplify `AnnotationTimestamps` · bc58c21c
      Lyza Danger Gardner authored
      Make `AnnotationTimestamps` align with changes to `ShowDocumentInfo`;
      it is now a dumb component. Centralize logic in `AnnotationHeader`.
      bc58c21c
    • Lyza Danger Gardner's avatar
      Do not link to documents for third-party annotations · 0aa62e16
      Lyza Danger Gardner authored
      - Refactor `ShowDocumentInfo`: don't link to documents for third-party
        annotations. This is a possibly-temporary measure to prevent linking
        to documents that are not directly accessible, e.g. in an LMS context.
      - Remove unnecessary forwarding of `showDocumentInfo` through several
        components.
      - Centralize some logic in `AnnotationHeader` and make `ShowDocumentInfo`
        a dumb component.
      0aa62e16
    • Eduardo Sanz García's avatar
      Avoid leaving elements from bucket-bar test · 72208f96
      Eduardo Sanz García authored
      These changes enforce that the bucket-bar is destroyed and allows
      multiple creations of the bucket bar, if needed.
      72208f96
    • Robert Knight's avatar
      Generalize a comment · cebe7dbd
      Robert Knight authored
      The sidebar is not the only other frame that may be interested in new
      annotations. The notebook is too.
      cebe7dbd
    • Robert Knight's avatar
      Improve tests for `getDocumentInfo` event handling in Guest · 6bcf0b8c
      Robert Knight authored
       - Extract the repeated logic for checking the data passed to the
         event's callback into a `createCallback` helper
      
       - Add separate tests for HTML and PDF documents
      
       - Add test for the error path when getting the URL of a PDF fails
      6bcf0b8c
    • Robert Knight's avatar
      Replace the "plugin" functionality in the Guest · bcd65da1
      Robert Knight authored
      Replace the "plugin" functionality in the Guest that indirectly
      instantiates the `DocumentMeta`, `PDF` and `CrossFrame` classes with
      direct instantiation of those classes.
      
      The annotator part of the Hypothesis client is no longer a pluggable
      toolbox which can be arbitrarily extended by user-provided plugins.
      Removing the "plugins" logic and replacing it with direct construction
      of the necessary classes removes a lot of indirection that made the code
      harder to follow and also makes it easier for TypeScript to statically
      check the code. It will also enable the `config` object that is passed
      to `Guest` to be paired down to just the fields that are actually needed
      and properly typed.
      
      In future we will need some kind of plugin/integration facility to
      support different document viewers. For we will build a more specific
      document type integration facility when the time comes.
      
       - Remove `this.plugins` field from `Guest` class and `pluginClasses`
         config and replace with direct construction of `PDFIntegration`,
         `DocumentMeta` and `CrossFrame` classes
      
       - Update the `AnchoringImpl` typedef to correctly reflect that some anchoring
         implementations (HTML) have a synchronous `describe` method
      
       - Remove unnecessary `config` argument to `PDF` constructor
      
       - Replace the `PDF: {}` content in the guest config with `documentType:
         'pdf'` as a more obvious way for the annotator entry point to
         configure which document viewer integration is loaded. In future we
         can generalize this to support different types of viewer integration.
      bcd65da1
  4. 03 Mar, 2021 7 commits