- 23 Mar, 2017 2 commits
-
-
Sean Hammond authored
Just the minimal changes necessary to stop `make lint` from complaining, while still having `make test` pass. Some code can be deleted because (eslint informs us) it was unused.
-
Sean Hammond authored
`annotation-sync-test.js` is the unmodified output of `coffee -bc src/annotator/test/annotation-sync-test.coffee`.
-
- 21 Mar, 2017 1 commit
-
-
Robert Knight authored
* Implement <moderation-banner> component Implement the UI component for the moderation banner at the top of annotation cards, following the designs on [1]. [1] https://github.com/hypothesis/product-backlog/issues/183 * Add reducer and actions for managing moderation app state Add a module which defines the state and actions related to moderation status of annotations. * Display moderation banner at the top of annotation cards The moderation banner is currently only supported on top-level annotations. It will need to be adjusted and moved to a different component in order to support replies. * Support displaying moderation banner above replies. * Move the `<moderation-banner>` component to `<annotation-thread>` so that it can be displayed for replies as well as annotations. * Customize the styling of the banner when the annotation is a reply. * Add a simple test for display change when moderation banner is used on a reply * Add additional parameter documentation * Convert `<moderation-banner>` to a component As per hypothesis/client#292, all element directives are being converted to components. * Add tooltips to moderation banner buttons. The "Hide" and "Undo" labels for the button were potentially ambiguous. The final labels are still being discussed but improve the UI by adding tooltips and changing "Undo" to "Unhide". * Correct a reference to a button label in tests The label changed from "Undo" to "Unhide".
-
- 20 Mar, 2017 1 commit
-
-
- 17 Mar, 2017 13 commits
-
-
Robert Knight authored
Say "h" not "the Hypothesis web service"
-
Sean Hammond authored
Move ng components from src/sidebar/directive to src/sidebar/components
-
Robert Knight authored
Docs adrs tweaks
-
Robert Knight authored
This makes the dir name match the type of object these modules export.
-
Robert Knight authored
Convert element directives to components
-
Sean Hammond authored
-
Sean Hammond authored
-
Sean Hammond authored
Add ADR for adopting a component-based architecture for the UI
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Query from url
-
Robert Knight authored
-
Robert Knight authored
* Separate the 'Context' section into relevant background information and client-specific context. * Explicitly state in the 'Decision' section that `angular.component()` will be used.
-
- 16 Mar, 2017 2 commits
-
-
Sean Hammond authored
The docs for h now refer to it as just "h" and not "the Hypothesis web service": https://github.com/hypothesis/h/pull/4434 https://github.com/hypothesis/h/pull/4435 Update this repo's docs to just say "h" not "Hypothesis web service" when referring to the web app as opposed to the specific instance of the web app hosted at hypothes.is.
-
Robert Knight authored
This ADR provides an explicit write-up of how the UI is structured and describes some changes we can make to the client to make this structure more obvious and eliminate inconsistencies.
-
- 15 Mar, 2017 19 commits
-
-
Robert Knight authored
Components should use `bindings` rather than `scope` to declare inputs and outputs.
-
Robert Knight authored
Several directives should be registered as components but will require refactoring before this is possible.
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
As part of an effort to make it clearer how the client uses Angular, register UI components with `component()` instead of `directive()`. Components in Angular 1.x [1] are essentially directives with "best practices" defaults set (restricted to elements, isolated scope, bound to controller) and deprecated/discouraged features of $compile disallowed. These defaults/restrictions match how we are already using Angular for most UI components. [1] See https://docs.angularjs.org/guide/component
-
greebie authored
-
- 14 Mar, 2017 2 commits
-
-
Sean Hammond authored
Correct the title of the documentation
-
Sean Hammond authored
-