- 13 Feb, 2020 9 commits
-
-
Lyza Gardner authored
Convert ‘Log in’ and ‘Sign up’ links to `Button` components
-
Lyza Danger Gardner authored
Part of #1727
-
Robert Knight authored
Highlights a11y (2/2) - Make highlights "visible" to screen readers
-
Robert Knight authored
Use CSS `::before` and `::after` to add "comment start" and "commend end" notices around highlighted text which screen readers will read but which are not visible. This pattern follows the example of how highlights are presented in Google Docs and also a suggestion in a blog post from the Paciello Group. This will get quite audibly "noisy" if there are a lot of overlapping highlights, but I think it is better than not having the highlights be visible to screen reader users at all.
-
Robert Knight authored
Highlight a11y (1/2) - Rename highlights CSS styles and move to separate module
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
We're renaming CSS classes to have a `hypothesis-` prefix to make it more obvious what they are associated with, so update the selector accordingly.
-
Robert Knight authored
- Remove the vestigial "annotator-" prefix for the hypothesis highlight CSS rules and replace with "hypothesis-". - Move the highlights styles to a separate module for consistency with the sidebar styles, where each component's styles goes in its own module and also to simplify the entry point (annotator.scss) module
-
- 12 Feb, 2020 9 commits
-
-
Kyle Keating authored
Fix eslint issues in HelpPanel component
-
Robert Knight authored
Decouple `wrapReactComponent` from Angular `$injector`
-
Robert Knight authored
Pass the service container directly to `wrapReactComponent` instead of looking up services via Angular's `$injector` service. This removes the need to register services with Angular if only other services or Preact components use them. This will enable us to incrementally remove these service registrations as the migration continues. As a starting point, remove the "tags" service registration, as all the UI components and services that use it have been migrated.
-
Robert Knight authored
Add missing effect dependencies in StreamSearchInput
-
Robert Knight authored
Remove unnecessary registration of several classes / functions with Angular
-
Lyza Gardner authored
Add `save` method to `AnnotationsService`; use it in `AnnotationOmega`
-
Lyza Danger Gardner authored
-
Lyza Danger Gardner authored
Also add polyfill for `Promise.prototype.finally`
-
Robert Knight authored
This fixes an issue, and corresponding warning in tests, where an effect would unnecessarily run on every render. See https://hypothes-is.slack.com/archives/C1M8NH76X/p1581517940185900
-
- 10 Feb, 2020 14 commits
-
-
Kyle Keating authored
- <a> tags without real href attributes should be converted to buttons. - Did not use our button component in this instance because we don’t have control over the icon position relative to the text.
-
Robert Knight authored
Bump axe-core from 3.4.1 to 3.4.2
-
Robert Knight authored
Bump codecov from 3.6.4 to 3.6.5
-
Robert Knight authored
Bump puppeteer from 2.1.0 to 2.1.1
-
Robert Knight authored
Bump @sentry/browser from 5.11.2 to 5.12.1
-
Robert Knight authored
Bump preact from 10.2.1 to 10.3.1
-
dependabot-preview[bot] authored
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.610.0 to 2.614.0. - [Release notes](https://github.com/aws/aws-sdk-js/releases) - [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-js/compare/v2.610.0...v2.614.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@octokit/rest](https://github.com/octokit/rest.js) from 16.43.0 to 16.43.1. - [Release notes](https://github.com/octokit/rest.js/releases) - [Commits](https://github.com/octokit/rest.js/compare/v16.43.0...v16.43.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.18.0 to 7.18.3. - [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases) - [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](https://github.com/yannickcr/eslint-plugin-react/compare/v7.18.0...v7.18.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.11.2 to 5.12.1. - [Release notes](https://github.com/getsentry/sentry-javascript/releases) - [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md) - [Commits](https://github.com/getsentry/sentry-javascript/compare/5.11.2...5.12.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 2.1.0 to 2.1.1. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Commits](https://github.com/puppeteer/puppeteer/compare/v2.1.0...v2.1.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [codecov](https://github.com/codecov/codecov-node) from 3.6.4 to 3.6.5. - [Release notes](https://github.com/codecov/codecov-node/releases) - [Commits](https://github.com/codecov/codecov-node/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [axe-core](https://github.com/dequelabs/axe-core) from 3.4.1 to 3.4.2. - [Release notes](https://github.com/dequelabs/axe-core/releases) - [Changelog](https://github.com/dequelabs/axe-core/blob/v3.4.2/CHANGELOG.md) - [Commits](https://github.com/dequelabs/axe-core/compare/v3.4.1...v3.4.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
dependabot-preview[bot] authored
Bumps [preact](https://github.com/preactjs/preact) from 10.2.1 to 10.3.1. - [Release notes](https://github.com/preactjs/preact/releases) - [Commits](https://github.com/preactjs/preact/compare/10.2.1...10.3.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
-
- 07 Feb, 2020 8 commits
-
-
Robert Knight authored
- Stop using dependency injection to mock `OAuthClient`, `Discovery` `VirtualThreadList` and `serviceConfig` in tests. Use our modern mocking tools instead. This removes unnecessary indirection and runtime overhead. - Remove unused `random` and `time` values from the dependency injection container. The code that used to rely on these has since been rewritten to import the modules directly.
-
Kyle Keating authored
Add `disabled` prop to the Button component
-
Kyle Keating authored
Fix a11y lint issues in menu.js
-
Robert Knight authored
No other code referenced this filter.
-
Robert Knight authored
Services that are only used by other services no longer need to be registered with Angular, since the new dependency injection container handles wiring them up.
-
Robert Knight authored
Implement container to replace AngularJS's dependency injector for services (v2)
-
Robert Knight authored
Previously a heuristic based on function naming was used to determine whether `Injector` should construct objects with `new` or not. This is brittle because compiler transforms may alter function names (eg. terser removes them by default). This commit re-works the API so that the caller explicitly indicates how the object should be created (the "provider" to use). As a convenience if a function is passed it is assumed to be a class. ``` // Register a class. register("anObject", SomeClass); register("anObject", { class: SomeClass }); // Register a factory. register("anObject", { factory: makeMeAnObject }); // Register a plain value. register("anObject", { value: "foobar" }); ```
-
Robert Knight authored
This reverts commit ec63961a, reversing changes made to e0f8835c.
-