Skip to content

C
coopwire-hypothesis
Switch branch/tag
  1. 18 Jan, 2019 3 commits
  3. 17 Jan, 2019 12 commits
  5. 16 Jan, 2019 16 commits
  7. 15 Jan, 2019 1 commit
  9. 09 Jan, 2019 3 commits
    • Robert Knight's avatar
      Update to Angular 1.7.x · c29e31e3
      Robert Knight authored
      c29e31e3
    • Robert Knight's avatar
      Remove usage of bindings in component constructors · f2fcb297
      Robert Knight authored 
      In Angular 1.6 the behavior where inputs to components ("bindings")
were accessible in the controller's constructor was deprecated [1] but a
switch was made available to re-enable the old behavior to assist migration.
This switch has been removed in Angular 1.7, so we need to stop relying
on it before we can upgrade.

The correct thing to do is to put all init logic which accesses bindings
(`this.someBindingName`) in the `$onInit` lifecycle method.

This commit makes the minimal amount of changes to enable the app and
tests to run without requiring pre-assigned bindings.

[1] https://toddmotto.com/angular-1-6-is-here
      f2fcb297
    • Robert Knight's avatar
      Upgrade to gulp 4 · 205d7818
      Robert Knight authored 
      This should make future maintenance easier since Gulp v4 has better
documentation [1], more checks for incorrect usage and a simpler API for
expressing what should run in parallel vs sequentially during build
steps. This also eliminates a bunch of old transitive dependencies that
gulp v3 had, which sometimes caused problems (eg. with Node upgrades).

Changes required:

 - Make sure `gulp.task` functions return a value, so Gulp knows when
   the task is finished
 - `gulp.watch` now requires a function rather than a task name
 - Task no longer support a list of dependencies but need a task
   function. Dependencies are expressed using `gulp.series` or
   `gulp.parallel` to compose other functions
 - Give several functions names so that there are fewer `<anonymous>
   {starting, finished}` messages in log output.

[1] https://gulpjs.com/docs/en/api/concepts
      205d7818
  11. 13 Dec, 2018 2 commits
    • Robert Knight's avatar
      Merge pull request #828 from hypothesis/refactor-Makefile · b75882bf
      Robert Knight authored 
      Refactor Makefile
      b75882bf
    • Sean Hammond's avatar
      Refactor Makefile · b778c9ad
      Sean Hammond authored 
      Refactor Makefile to be the same as for our other projects:

    $ make help
    make help              Show this help message
    make dev               Run the app in the development server
    make lint              Run the code linter(s) and print any warnings
    make test              Run the unit tests
    make docs              Build docs website and serve it locally
    make checkdocs         Crash if building the docs website fails
    make clean             Delete development artefacts (cached files,
                           dependencies, etc)

Other make commands that our other projects have but the client doesn't
yet:

`make shell` -- Not relevant to the client? (Unless we can get a useful
JavaScript shell in the terminal.)

`make sql` -- Not relevant.

`make format` and `checkformatting` -- We can't use Black code
formatting for the client of course but maybe we could use Prettier or
something else. (Our Python apps could also be extended to have `make
format` format the JavaScript code as well.)

`make coverage` and `codecov` -- Print the unit test coverage report to
the terminal, and post it to codecov. These should be doable?
      b778c9ad
  13. 11 Dec, 2018 3 commits