- 12 Jul, 2017 1 commit
-
-
Sean Roberts authored
-
- 11 Jul, 2017 7 commits
-
-
Robert Knight authored
We should review whether or not to include this file in the source tree, given that we use Yarn primarily for package management, but since it is here, keep it up to date.
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Fix adder position when document or body position is offset.
-
Robert Knight authored
-
Robert Knight authored
Use OAuth for first party login if enabled.
-
Robert Knight authored
Respond to CR feedback in https://github.com/hypothesis/client/pull/476#discussion_r126539329
-
- 10 Jul, 2017 2 commits
-
-
Sean Roberts authored
Avoid mutating frames array in DESTROY_FRAME action.
-
Robert Knight authored
Fix positioning of the adder when the document or body elements are positioned and offset relative to their default position. There were two problems: 1. When converting from viewport to "document" coordinates, code in `adder.js` and `range-util.js` failed to account for the document element's position being offset from the default (0, 0) location. 2. When setting the adder's top/left coords, `Adder#showAt` did not take into account the offset of the body element from the document. This commit fixes the issue by: 1. Using viewport coordinates as far as possible in the range-util and Adder functions to reduce the need for converting coordinates. 2. Calculating the position of the adder by comparing the target viewport coordinates for the adder and the viewport coordinates of the adder's nearest positioned ancestor. Fixes #487
-
- 07 Jul, 2017 1 commit
-
-
Robert Knight authored
The state is supposed to be immutable. `Array#splice` modifies its argument. Use `Array#filter` instead which returns a new array.
-
- 06 Jul, 2017 6 commits
-
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Emit an event on the Guest element, ‘scrollToRange’
-
Juan Corona authored
Follows DOM event name conventions.
-
Robert Knight authored
If the service provides an OAuth client ID and sets the "oauthEnabled" flag in the app configuration, use OAuth for first party login. This initial implementation does not persist the token for future use, so the user has to login every time they use the app.
-
Juan Corona authored
-
- 05 Jul, 2017 11 commits
-
-
Juan Corona authored
This allows attached handlers to hook into the behaviour of bringing a highlight anchor into view. The event.detail property contains a native DOM range representing the anchor. The default scroll behaviour can be prevented with the event.preventDefault method. The event bubbles upward, meaning a handler could be attached at the guest root element - right now the document’s body element - and any ancestor. body -> documentElement -> document -> window
-
Juan Corona authored
The latest version makes it work for sub-document frames
-
Robert Knight authored
-
Robert Knight authored
-
Robert Knight authored
Merge pull request #481 from hypothesis/dont-show-view-switcher-until-first-batch-of-annotations-received Don't show view switcher until annotations received
-
Sean Hammond authored
Don't show the view switcher until the first batch of annotations has been received. (This first batch will be all the annotations, unless there are more than 200 annotations of the page.) This is an attempt to reduce "popping" caused by the annotation switcher suddenly changing a brief time after first render, when annotations are loaded: https://github.com/hypothesis/product-backlog/issues/327#issuecomment-312657968
-
Robert Knight authored
Increase robustness of frame destruction
-
Robert Knight authored
Find the true URI record for a Document when there’s conflicting info
-
Juan Corona authored
The previous implementation of this used the iframe’s `src` uri as the key for identifying which frames needed to be removed from the sidebar’s frame-sync state. We can’t rely on this uri because there could be one or more iframes sharing the same src uri, for example ‘about:blank’ with/without `srcdoc` attribute usage. Another problem is with a `blob:` uri as the src. Once again the uri in the src can’t be used as the key since it won’t match what frame-sync thinks the proper uri is if it’s being substituted with `baseURI`. The way this works now is by tagging the frame info with a random ID called the frameIdentifier. The handling of this tag is coordinated with the relevant modules, cross frame, bridge, frame-sync, etc.
-
Juan Corona authored
Modified to fit our needs of course..
-
Juan Corona authored
This happens when an href is set with a URI using the 'blob:' protocol and the document could possibly set a different URI through a <base> tag. Use the URI from the base URI instead if this is the case.
-
- 04 Jul, 2017 3 commits
-
-
Sean Hammond authored
Fix decoding of the query section in "#annotations" fragments.
-
Robert Knight authored
Fix view switcher flash on iOS
-
Robert Knight authored
Use `decodeURIComponent` instead of `decodeURI` because `decodeURIComponent` decodes reserved characters (eg. ":", "/") whereas `decodeURI` does not. Avoid stubbing decodeURIComponent() in the tests and instead just use a malformed escape sequence which triggers an actual URIError when decoding.
-
- 03 Jul, 2017 1 commit
-
-
Sean Hammond authored
The view switcher tabs at the top of the sidebar would flash grey for a moment after you clicked one. This removes the flash. This webkit "tap highlight" is actually an iOS Safari usability feature, it indicates to the user that their tap is being successfully recognized, and indicates which element they're tapping on. But I don't think it looks good with these tabs of ours, and it seems to interact badly with the background colour animated transition we're using (it seems to do the animated transition first and _then_ flash the tap highlight colour for a second). We're providing this indication by changing the colour of the tab anyway, so disable it.
-
- 30 Jun, 2017 2 commits
-
-
Sean Hammond authored
-
Sean Hammond authored
-
- 29 Jun, 2017 6 commits
-
-
Sean Roberts authored
Frame destruction
-
Sean Roberts authored
Set the visibleHighlights state for multiple Guests
-
Sean Hammond authored
Convert Unicode service & tests to JS
-
Sean Hammond authored
Replace selection tabs with view switcher (feature flagged)
-
Sean Hammond authored
-
Sean Hammond authored
If the 'view-switcher' feature flat is enabled then use the new view switcher component, otherwise uses the old selection tabs component. The view switcher component is just a placeholder for now.
-