- 30 Mar, 2016 4 commits
-
-
Robert Knight authored
CSP Violation: form input onfocus
-
Robert Knight authored
Merge pull request #3124 from hypothesis/sheetaluk/257-add-explanatory-text-below-public-focused-annotation-when-logged-out Add message when user logged out and directed to an annotation.
-
Sheetal Umesh Kumar authored
When non-hypothesis users(or logged out users) are viewing a direct linked annotation, we want to help them understand what they are looking at and encourage them to sign up(or sign in). Display a CTA message when: * user is logged out * user has landed on a DL * there is a selection * user has permissions to view the selection Also, * Add logo svg * Update icomoon css * Pull variables\.scss from 03cbef2
-
Christof Dorner authored
Fix the signature of NSQ error/exception handlers
-
- 29 Mar, 2016 4 commits
-
-
chdorner authored
Which fixes a CSP violation with having inline JavaScript.
-
Christof Dorner authored
Merge pull request #3146 from hypothesis/sheetaluk/294-as-a-user-i-want-to-be-able-to-find-out-who-is-a-member-of-a-group-i-m-in Show list of group members in the group page.
-
Sheetal Umesh Kumar authored
Users want to see other users in the groups they belong to and annotations each of these users have made and shared with a group. This will help them decide how to share annotations with their groups. https://trello.com/c/rSUQLuos/294-as-a-user-i-want-to-be-able-to-find-out-who-is-a-member-of-a-group-i-m-in
-
Robert Knight authored
List group memberships of user in admin interface
-
- 24 Mar, 2016 6 commits
-
-
Nick Stenning authored
Convert AnnotationUI, AnnotationUISync from CoffeeScript to JS
-
Nick Stenning authored
Add Visual Studio Code project config file for JS
-
Robert Knight authored
Merge pull request #3130 from hypothesis/sheetaluk/303-add-explanation-text-to-the-sharer-on-only-me-and-group-annotations Add message to private and group annotations sharer.
-
Robert Knight authored
Use specific Sentry DSN for the client part of H
-
Robert Knight authored
Fix CSP violation on new homepage
-
chdorner authored
Since we are not allowing inline styles with our CSP policy.
-
- 23 Mar, 2016 5 commits
-
-
Sheetal Umesh Kumar authored
-
Robert Knight authored
rearranging annotation icons
-
Sheetal Umesh Kumar authored
* Rearrange the annotation action icon positions. * Add new colours for annotation action button labels. * Replace icons for reply, edit, delete and share. * Update style for loggedout users too. * Update share icon in top-bar.
-
Robert Knight authored
-
Robert Knight authored
In combination with JSDoc annotations, this enables IntelliSense, project navigation, inline documentation, refactoring and other goodies using Visual Studio Code and other IDEs that integrate with TypeScript's Language Service for JavaScript (aka. 'Salsa'). See https://code.visualstudio.com/docs/languages/javascript The project file can be named either `jsconfig.json` without 'allowJs' or `tsconfig.json` with the 'allowJs' config option enabled. I've opted for `tsconfig.json` because that turns up better documentation on the web and is recognized by more tools. The project config file lives in h/static/scripts so that Visual Studio only tries to parse and process .js files under that directory. The config file does support specifying the set of files to include, but each file currently has to be listed individually. Glob support is planned for the future. See https://github.com/Microsoft/TypeScript/issues/1927
-
- 22 Mar, 2016 6 commits
-
-
Nick Stenning authored
Support filtering test suites to run using '--grep' argument to gulp
-
Robert Knight authored
Remove user status bitfield
-
Nick Stenning authored
Display message if a direct-linked annotation is not available
-
Robert Knight authored
The image is specified using the `background-image` property since that makes it easy to use the same relative URL when the app is served from the extension and when it is served from the site.
-
Robert Knight authored
If an annotation is selected but was not successfully loaded, display a message in the sidebar indicating that the user does not have permission to see that annotation.
-
Robert Knight authored
Add support for filtering the tests that are run by Gulp test tasks using '--grep <pattern>'. This avoids the need to use the `(describe|it).only` test modifiers to filter the tests that are run. The pattern argument is a JS regex expression which is passed directly to mocha as the 'grep' option. eg. To start the app test suite in auto-restart mode, but only run tests for the markdown editor, run: gulp test-watch-app --grep markdown
-
- 21 Mar, 2016 15 commits
-
-
Nick Stenning authored
Replace '@p <ident>' with `ident` in JSDoc comments
-
Robert Knight authored
Using '@p <ident>' to refer to parameters in JSDoc comments is not legal syntax. Use Markdown backticks instead, ala. Angular's docs.
-
Nick Stenning authored
Switch to appropriate group and scroll to direct linked annotation when sidebar loads
-
Nick Stenning authored
Use more Pythonic way for the argument default value
-
Nick Stenning authored
Refactor feature caching
-
Robert Knight authored
Change icon size in the bucket bar
-
Conor Delahunty authored
-
Robert Knight authored
Also avoid using `@p` to refer to parameter names in function documentation, since this isn't valid JSDoc syntax. Use markdown backticks instead, following conventions in Angular's docs.
-
Robert Knight authored
The sidebar supports multiple client pages connecting to it and displaying annotations for all of the connected clients. As far as I am aware, this functionality is not actually used anywhere, but this commit fixes an issue where annotations would be loaded multiple times for some clients if multiple clients connected.
-
Robert Knight authored
This was duplicated with varying levels of explanation in several places. Although the function is trivial, having it in its own module is useful for documentation on why it should be used by default.
-
Robert Knight authored
When the selection is initialized as a result of following a direct link to an annotation, focus and scroll to the annotation after it has been successfully fetched from the service.
-
Robert Knight authored
When the sidebar loads as a result of an '#annotations' fragment, we do not know which group that annotation is in. Handle this by first fetching annotations in all groups, then finding the group containing the selected annotation(s) and finally filtering the results by that group. An alternative approach would be to first fetch the selected annotations in order to determine the group and then fetching annotations in that group. This approach however avoids an extra round-trip to the server in the common case where the total number of annotations across all groups is less than the default chunk size (200).
-
Robert Knight authored
widget-controller.js triggers a reload of annotations whenever a GROUP_FOCUSED event is emitted. Avoid reloading annotations unnecessarily if group.focus() is called with the currently focused group.
-
Robert Knight authored
Extract the logic for paging through search results from the API into a separate module.
-
Nick Stenning authored
Fix list/quote toolbar command when selection is empty and cursor is at start of line
-