1. 28 Jun, 2014 2 commits
    • Randall Leeds's avatar
      Fix regressions in auth errors and state resume · baf9906d
      Randall Leeds authored
      Fix two recent regressions with authentication. The first is the lack
      of form error reporting. The second is the issue that ongoing highlight
      mode switches and edits don't proceed after login.
      
      - Unify all the interceptors related to sessioning. The interceptor for
        flash messages, csrf, and extracting the model from the session view
        responses is now all in session.coffee. This is better because it
        means other requests that don't return data in the same format aren't
        processed by these interceptors. It also makes it clearer which data
        the interceptors are processing; the CSRF interceptor may have been
        broken because the flash interceptor was discarding the data outside
        the model object.
      - The CSRF interceptor was also not returning a rejected promise on
        errors. This mistake caused the errors not to be propagated to the
        Auth form controller. Fix #1266.
      - The interaction between the Auth controller, session model changes,
        and scope resets is improved. The timeouts on the auth sheet are
        fixed so that they don't lose the ongoing mode switches and edits
        when the sheet is closed. Fix #1214.
      baf9906d
    • Randall Leeds's avatar
      Merge pull request #1274 from hypothesis/travis-timeouts · bf74c788
      Randall Leeds authored
      Re-jig the integration tests 
      bf74c788
  2. 27 Jun, 2014 3 commits
  3. 25 Jun, 2014 1 commit
  4. 24 Jun, 2014 5 commits
  5. 18 Jun, 2014 2 commits
  6. 17 Jun, 2014 2 commits
    • Randall Leeds's avatar
      Remove _annotator_mapsrc directory · 3b4fe339
      Randall Leeds authored
      It's not reasonable to be shipping this here. We should be including
      the source in the source map files or even including the source map
      inline in the source map comment. The Annotator master branch does
      this. For now, I'm putting the pressure on here. No source maps until
      we get off this damn fork.
      3b4fe339
    • Randall Leeds's avatar
      Update to typed-anchors@5c36e53 · 4dae28ce
      Randall Leeds authored
      Fix #1265
      4dae28ce
  7. 14 Jun, 2014 1 commit
  8. 12 Jun, 2014 2 commits
  9. 11 Jun, 2014 1 commit
    • Ujvari Gergely's avatar
      Handle spaces in tags · a5016d5b
      Ujvari Gergely authored
      The tag-it library is now configured to allow spaces.
      However by default the window.open() function converts
      the space characters in the query part of the uri to +
      The streamsearch controller is now handling this conversion too.
      
      Fixes #1254
      a5016d5b
  10. 05 Jun, 2014 5 commits
  11. 04 Jun, 2014 1 commit
    • Randall Leeds's avatar
      Clean up streamer and base URI usage · 5bfb0834
      Randall Leeds authored
      Factor out a socket factory into a service and send the client ID only
      before the first message. Configure the client ID and this service in a
      new module, h.socket. Fix the base URI to end in a slash and to be the
      root URL of the server.
      5bfb0834
  12. 03 Jun, 2014 4 commits
  13. 30 May, 2014 2 commits
  14. 29 May, 2014 3 commits
  15. 28 May, 2014 6 commits
    • csillag's avatar
      Update Annotator to 2542d55a (typed-packaging branch) · 83a727fd
      csillag authored
      This update fixes the XPath creation, so that our highlights won't leak into them.
      83a727fd
    • Randall Leeds's avatar
      Include the query when rebasing heatmap SVG refs · d7b9dbf8
      Randall Leeds authored
      Some browsers seem to care about this. Close #1241.
      d7b9dbf8
    • csillag's avatar
      ffaf4253
    • csillag's avatar
      Revert "Add simple on/off option to whether load dtm or not" · b09290fc
      csillag authored
      This reverts commit 4eb0de8ea0de8098e2771c8a276d75434f2c99f6.
      b09290fc
    • Ujvari Gergely's avatar
      Add simple on/off option to whether load dtm or not · cf210db6
      Ujvari Gergely authored
      This commit removes the dtm plugin and all dtm dependent plugins from
      the guest.coffee and introduces a dtm parameter inside the embed.txt
      If this parameter is true (by default  it is) it loads the
      DomTextMapper, TextPosition, FuzzyTextAnchors, PDF plugins.
      
      Fixes #1233
      cf210db6
    • Randall Leeds's avatar
      beforeAnnotationCreated before setupAnnotation · ee7b3c18
      Randall Leeds authored
      When always on highlights and the highlighter mode were introduced in
      ddf17189fbf2d428b21fd31065a1c2d2bc6ab08b the beforeAnnotationCreated
      event was not fired in the guest frame. Instead, a special inject call
      was added to the bridge to send the annotation and the event fired in
      the iframe first. Later, when I removed this, I added the event after
      the call to setupAnnotation.
      
      The change in 3613c7d91682a438b1d243b9573cb941b26cdc43 uses the
      annotationsLoaded event to notify listeners when highlights change as a
      result of realizing anchors. This presents a problem because the bridge
      ignores the beforeAnnotationCreated event for annotations that have
      already been tagged by the bridge, but this load event causes the new
      highlight to be tagged and serialized.
      
      Move the beforeAnnotationCreated event to before the setupAnnotation
      call, which is the order of things in non-highlighter mode, so that
      the event is properly propagated to the sidebar iframe.
      
      Close #1240
      ee7b3c18